Match Java's key bound when serializing deletion vector bitmaps

Java's RoaringPositionBitmap.readKey rejects keys above
Integer.MAX_VALUE - 1, while the serializer allowed one more key, so
PyIceberg could write a deletion vector Java cannot read.

Author: moomindani

pyiceberg/table/deletion_vector.py

@@ -112,8 +112,11 @@ def _serialize_bitmap(bitmaps: list[BitMap]) -> bytes:
         with io.BytesIO() as out:
             out.write(len(non_empty).to_bytes(8, "little"))
             for key, bitmap in non_empty:
-                if key > MAX_JAVA_SIGNED:
-                    raise ValueError(f"Key {key} is too large, max {MAX_JAVA_SIGNED} to maintain compatibility with Java impl")
+                # Java's RoaringPositionBitmap.readKey rejects keys above Integer.MAX_VALUE - 1
+                if key > MAX_JAVA_SIGNED - 1:
+                    raise ValueError(
+                        f"Key {key} is too large, max {MAX_JAVA_SIGNED - 1} to maintain compatibility with Java impl"
+                    )
                 out.write(key.to_bytes(4, "little"))
                 # Run-length encode before serializing so run-heavy vectors (e.g. contiguous
                 # deletes) stay compact, matching Java's BitmapPositionDeleteIndex.