refactor: remove unnecessary std::move in name mapping

Joe-Abraham · Joe-Abraham · commit dcf00cf150e0 · 2026-03-19T17:06:33.000+05:30
diff --git a/src/iceberg/name_mapping.cc b/src/iceberg/name_mapping.cc
@@ -409,7 +409,7 @@ class UpdateMappingVisitor {
     }
 
     if (fields_to_add.empty()) {
-      return std::move(mapping);
+      return mapping;
     }
 
     std::vector<MappedField> new_fields;

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ class UpdateMappingVisitor {`
`409`	`409`	`}`
`410`	`410`
`411`	`411`	`if (fields_to_add.empty()) {`
`412`		`- return std::move(mapping);`
	`412`	`+ return mapping;`
`413`	`413`	`}`
`414`	`414`
`415`	`415`	`std::vector<MappedField> new_fields;`