Skip to content

Commit c4149ce

Browse files
committed
refactor: mark aggregate parameters as maybe unused in expression visitor
1 parent ff5d830 commit c4149ce

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/iceberg/expression/expression_visitor.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,15 +82,17 @@ class ICEBERG_EXPORT ExpressionVisitor {
8282

8383
/// \brief Visit a bound aggregate.
8484
/// \param aggregate The bound aggregate to visit.
85-
virtual Result<R> Aggregate(const std::shared_ptr<BoundAggregate>& aggregate) {
85+
virtual Result<R> Aggregate(
86+
[[maybe_unused]] const std::shared_ptr<BoundAggregate>& aggregate) {
8687
ICEBERG_DCHECK(aggregate != nullptr, "Bound aggregate cannot be null");
8788
return NotSupported("Visitor {} does not support bound aggregate",
8889
typeid(*this).name());
8990
}
9091

9192
/// \brief Visit an unbound aggregate.
9293
/// \param aggregate The unbound aggregate to visit.
93-
virtual Result<R> Aggregate(const std::shared_ptr<UnboundAggregate>& aggregate) {
94+
virtual Result<R> Aggregate(
95+
[[maybe_unused]] const std::shared_ptr<UnboundAggregate>& aggregate) {
9496
ICEBERG_DCHECK(aggregate != nullptr, "Unbound aggregate cannot be null");
9597
return NotSupported("Visitor {} does not support unbound aggregate",
9698
typeid(*this).name());

0 commit comments

Comments
 (0)