Add test

Author: arturobernalg

httpcore5-h2/src/test/java/org/apache/hc/core5/http2/nio/support/TestH2OverH2TunnelSupport.java

@@ -288,6 +288,42 @@ void testGracefulCloseEndsStreamAfterDrain() throws Exception {
         Assertions.assertTrue(session.isOpen(), "Ending tunnel stream must not close physical HTTP/2 connection");
     }
 
+    @Test
+    void testStreamEndAfterEstablishedTunnelDoesNotFireFailure() {
+        final ScriptedProxySession session = new ScriptedProxySession(HttpStatus.SC_OK, true, false, false, false, true);
+        final RecordingCallback<ProtocolIOSession> callback = new RecordingCallback<>();
+
+        H2OverH2TunnelSupport.establish(
+                session,
+                new HttpHost("http", "example.org", 80),
+                Timeout.ofSeconds(1),
+                false,
+                null,
+                callback);
+
+        Assertions.assertTrue(callback.completed, "Tunnel should complete successfully");
+        Assertions.assertNull(callback.failed, "streamEnd after established tunnel must not overwrite with failure");
+    }
+
+    @Test
+    void testStreamEndBeforeTunnelEstablishedFiresFailure() {
+        // 200 but no entity details -> consumeResponse throws -> fail() fires
+        // then streamEnd arrives on the already-failed handler
+        final ScriptedProxySession session = new ScriptedProxySession(HttpStatus.SC_OK, false, false, false, false, true);
+        final RecordingCallback<ProtocolIOSession> callback = new RecordingCallback<>();
+
+        H2OverH2TunnelSupport.establish(
+                session,
+                new HttpHost("http", "example.org", 80),
+                Timeout.ofSeconds(1),
+                false,
+                null,
+                callback);
+
+        Assertions.assertFalse(callback.completed);
+        Assertions.assertNotNull(callback.failed, "streamEnd with no tunnel must report failure");
+    }
+
     static class RecordingCallback<T> implements FutureCallback<T> {
 
         volatile boolean completed;
@@ -389,6 +425,7 @@ static class ScriptedProxySession implements IOSession {
         private final boolean signalCapacity;
         private final boolean emitInputData;
         private final boolean provideStreamControl;
+        private final boolean sendStreamEnd;
 
         private final Lock lock;
         private Timeout socketTimeout;
@@ -401,11 +438,11 @@ static class ScriptedProxySession implements IOSession {
         final AtomicBoolean endStreamCalled;
 
         ScriptedProxySession(final int responseCode, final boolean withTunnelStream) {
-            this(responseCode, withTunnelStream, false, false, false);
+            this(responseCode, withTunnelStream, false, false, false, false);
         }
 
         ScriptedProxySession(final int responseCode, final boolean withTunnelStream, final boolean signalCapacity) {
-            this(responseCode, withTunnelStream, signalCapacity, false, false);
+            this(responseCode, withTunnelStream, signalCapacity, false, false, false);
         }
 
         ScriptedProxySession(
@@ -414,11 +451,22 @@ static class ScriptedProxySession implements IOSession {
                 final boolean signalCapacity,
                 final boolean emitInputData,
                 final boolean provideStreamControl) {
+            this(responseCode, withTunnelStream, signalCapacity, emitInputData, provideStreamControl, false);
+        }
+
+        ScriptedProxySession(
+                final int responseCode,
+                final boolean withTunnelStream,
+                final boolean signalCapacity,
+                final boolean emitInputData,
+                final boolean provideStreamControl,
+                final boolean sendStreamEnd) {
             this.responseCode = responseCode;
             this.withTunnelStream = withTunnelStream;
             this.signalCapacity = signalCapacity;
             this.emitInputData = emitInputData;
             this.provideStreamControl = provideStreamControl;
+            this.sendStreamEnd = sendStreamEnd;
 
             this.lock = new ReentrantLock();
             this.socketTimeout = Timeout.ofSeconds(30);
@@ -511,6 +559,10 @@ public void endStream(final java.util.List<? extends org.apache.hc.core5.http.He
                         exchangeHandler.consume(ByteBuffer.wrap(new byte[]{1, 2, 3}));
                     }
                 }
+
+                if (sendStreamEnd) {
+                    exchangeHandler.streamEnd(null);
+                }
             } catch (final Exception ex) {
                 exchangeHandler.failed(ex);
             }