FINERACT-2421: Fix shortName collisions in integration tests by routing all generation through uniqueRandomStringContainer

Author: oleksii-novikov-onix

integration-tests/src/test/java/org/apache/fineract/integrationtests/WorkingCapitalLoanDelinquencyActionIntegrationTest.java

@@ -432,7 +432,7 @@ private Long createWorkingCapitalLoanDelinquencyBucket(final int frequencyDays)
 
     private Long createProduct(final Long delinquencyBucketId) {
         final String uniqueName = "WCL Product " + Utils.randomStringGenerator("", 8);
-        final String uniqueShortName = Utils.randomStringGenerator("", 4);
+        final String uniqueShortName = Utils.uniqueRandomStringGenerator("", 4);
         return productHelper.createWorkingCapitalLoanProduct(new WorkingCapitalLoanProductTestBuilder().withName(uniqueName)
                 .withShortName(uniqueShortName).withDelinquencyBucketId(delinquencyBucketId).build()).getResourceId();
     }

integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/helpers/FeignLoanHelper.java

@@ -34,6 +34,7 @@
 import org.apache.fineract.client.models.PostLoansOriginatorData;
 import org.apache.fineract.client.models.PostLoansRequest;
 import org.apache.fineract.client.models.PostLoansResponse;
+import org.apache.fineract.integrationtests.common.Utils;
 
 public class FeignLoanHelper {
 
@@ -46,7 +47,7 @@ public FeignLoanHelper(FineractFeignClient fineractClient) {
     public Long createSimpleLoanProduct() {
         PostLoanProductsRequest request = new PostLoanProductsRequest()//
                 .name("Simple Loan Product " + System.currentTimeMillis())//
-                .shortName(java.util.UUID.randomUUID().toString().substring(0, 4).toUpperCase())//
+                .shortName(Utils.uniqueRandomStringGenerator("", 4))//
                 .currencyCode("USD")//
                 .digitsAfterDecimal(2)//
                 .inMultiplesOf(1)//

integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/tests/FeignTrialBalanceSummaryReportTest.java

@@ -429,7 +429,7 @@ private Long createFlatFeeCharge(double amount) {
     private Long createLoanProduct() {
         return loanHelper.createLoanProduct(new PostLoanProductsRequest()//
                 .name("TrialBal Product " + System.currentTimeMillis())//
-                .shortName(UUID.randomUUID().toString().substring(0, 4).toUpperCase())//
+                .shortName(Utils.uniqueRandomStringGenerator("", 4))//
                 .currencyCode("USD")//
                 .digitsAfterDecimal(2)//
                 .inMultiplesOf(1)//