FINERACT-2567: Fix error messages in exception classes

Author: rhopman

fineract-accounting/src/main/java/org/apache/fineract/accounting/glaccount/exception/GLAccountInvalidUpdateException.java

@@ -32,7 +32,7 @@ public enum GlAccountInvalidUpdateReason {
 
         public String errorMessage() {
             if (name().equalsIgnoreCase("TRANSANCTIONS_LOGGED")) {
-                return "This Usage of this (detail) GL Account as it already has transactions logged against it";
+                return "This (detail) GL Account cannot be updated as it already has transactions logged against it";
             }
             return name();
         }

fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBeDeletedException.java

@@ -22,7 +22,7 @@
 
 public class LoanChargeCannotBeDeletedException extends AbstractPlatformDomainRuleException {
 
-    /*** enum of reasons of why Loan Charge cannot be waived **/
+    /*** enum of reasons of why Loan Charge cannot be deleted **/
     public enum LoanChargeCannotBeDeletedReason {
 
         ALREADY_PAID, //

fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBePayedException.java

@@ -22,7 +22,7 @@
 
 public class LoanChargeCannotBePayedException extends AbstractPlatformDomainRuleException {
 
-    /*** enum of reasons of why Loan Charge cannot be waived **/
+    /*** enum of reasons of why Loan Charge cannot be paid **/
     public enum LoanChargeCannotBePayedReason {
 
         ALREADY_PAID, //
@@ -37,11 +37,11 @@ public String errorMessage() {
             } else if (name().equalsIgnoreCase("ALREADY_WAIVED")) {
                 return "This loan charge has already been waived";
             } else if (name().equalsIgnoreCase("LOAN_INACTIVE")) {
-                return "This loan charge can be payed as the loan associated with it is currently inactive";
+                return "This loan charge cannot be paid as the loan associated with it is currently inactive";
             } else if (name().equalsIgnoreCase("CHARGE_NOT_ACCOUNT_TRANSFER")) {
-                return "This loan charge can be payed as the charge payment mode is not account transfer";
+                return "This loan charge cannot be paid as the charge payment mode is not account transfer";
             } else if (name().equalsIgnoreCase("CHARGE_NOT_PAYABLE")) {
-                return "This loan charge is not Payable through account transfer";
+                return "This loan charge is not payable through account transfer";
             }
 
             return name();

fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBeUpdatedException.java

@@ -22,7 +22,7 @@
 
 public class LoanChargeCannotBeUpdatedException extends AbstractPlatformDomainRuleException {
 
-    /*** enum of reasons of why Loan Charge cannot be waived **/
+    /*** enum of reasons of why Loan Charge cannot be updated **/
     public enum LoanChargeCannotBeUpdatedReason {
 
         ALREADY_PAID, //

fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeCannotBeWaivedException.java

@@ -36,9 +36,9 @@ public String errorMessage() {
             } else if (name().equalsIgnoreCase("ALREADY_WAIVED")) {
                 return "This loan charge has already been waived";
             } else if (name().equalsIgnoreCase("LOAN_INACTIVE")) {
-                return "This loan charge can be waived as the loan associated with it is currently inactive";
+                return "This loan charge cannot be waived as the loan associated with it is currently inactive";
             } else if (name().equalsIgnoreCase("WAIVE_NOT_ALLOWED_FOR_CHARGE")) {
-                return "This loan charge can be waived";
+                return "This loan charge cannot be waived";
             }
 
             return name();

fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeWaiveCannotBeReversedException.java

@@ -35,13 +35,13 @@ public enum LoanChargeWaiveCannotUndoReason {
         public String errorMessage() {
 
             if (name().equalsIgnoreCase("ALREADY_PAID")) {
-                return "This loan charge has been completely paid";
+                return "This loan charge waive cannot be reversed as the charge has already been paid";
             } else if (name().equalsIgnoreCase("ALREADY_WAIVED")) {
                 return "This loan charge has already been waived";
             } else if (name().equalsIgnoreCase("LOAN_INACTIVE")) {
-                return "This loan charge can be waived as the loan associated with it is currently inactive";
+                return "This loan charge waive cannot be reversed as the loan associated with it is currently inactive";
             } else if (name().equalsIgnoreCase("WAIVE_NOT_ALLOWED_FOR_CHARGE")) {
-                return "This loan charge can be waived";
+                return "This loan charge waive cannot be reversed";
             } else if (name().equalsIgnoreCase("NOT_WAIVED")) {
                 return "This loan charge waive cannot be reversed as this charge is not waived";
             } else if (name().equalsIgnoreCase("ALREADY_REVERSED")) {

fineract-provider/src/main/java/org/apache/fineract/portfolio/collateral/exception/CollateralCannotBeCreatedException.java

@@ -22,7 +22,7 @@
 
 public class CollateralCannotBeCreatedException extends AbstractPlatformDomainRuleException {
 
-    /*** enum of reasons of why Loan Charge cannot be waived **/
+    /*** enum of reasons of why Collateral cannot be created **/
     public enum LoanCollateralCannotBeCreatedReason {
 
         LOAN_NOT_IN_SUBMITTED_AND_PENDING_APPROVAL_STAGE;

fineract-provider/src/main/java/org/apache/fineract/portfolio/collateral/exception/CollateralCannotBeDeletedException.java

@@ -22,14 +22,14 @@
 
 public class CollateralCannotBeDeletedException extends AbstractPlatformDomainRuleException {
 
-    /*** enum of reasons of why Loan Charge cannot be waived **/
+    /*** enum of reasons of why Collateral cannot be deleted **/
     public enum LoanCollateralCannotBeDeletedReason {
 
         LOAN_NOT_IN_SUBMITTED_AND_PENDING_APPROVAL_STAGE;
 
         public String errorMessage() {
             if (name().toString().equalsIgnoreCase("LOAN_NOT_IN_SUBMITTED_AND_PENDING_APPROVAL_STAGE")) {
-                return "This collateral cannot be updated as the loan it is associated with is not in submitted and pending approval stage";
+                return "This collateral cannot be deleted as the loan it is associated with is not in submitted and pending approval stage";
             }
             return name().toString();
         }

fineract-provider/src/main/java/org/apache/fineract/portfolio/collateral/exception/CollateralCannotBeUpdatedException.java

@@ -22,7 +22,7 @@
 
 public class CollateralCannotBeUpdatedException extends AbstractPlatformDomainRuleException {
 
-    /*** enum of reasons of why Loan Charge cannot be waived **/
+    /*** enum of reasons of why Collateral cannot be updated **/
     public enum LoanCollateralCannotBeUpdatedReason {
 
         LOAN_NOT_IN_SUBMITTED_AND_PENDING_APPROVAL_STAGE;

fineract-provider/src/main/java/org/apache/fineract/portfolio/collateralmanagement/exception/ClientCollateralCannotBeDeletedException.java

@@ -22,7 +22,7 @@
 
 public class ClientCollateralCannotBeDeletedException extends AbstractPlatformDomainRuleException {
 
-    /*** enum of reasons of why Collateral cannot be waived **/
+    /*** enum of reasons of why Client Collateral cannot be deleted **/
     public enum ClientCollateralCannotBeDeletedReason {
 
         CLIENT_COLLATERAL_IS_ALREADY_ATTACHED;