FINERACT-2421: Fix backward compatible liquibase check

Author: adamsaghy

.github/workflows/verify-liquibase-backward-compatibility.yml

@@ -31,12 +31,20 @@ jobs:
       TZ: Asia/Kolkata
 
     steps:
-      - name: Checkout the base branch (`develop`)
+      - name: Checkout base commit
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           repository: ${{ github.event.pull_request.base.repo.full_name }}
-          ref: ${{ github.event.pull_request.base.ref }}
+          ref: ${{ github.event.pull_request.base.sha }}
           fetch-depth: 0
+          path: baseline
+
+      - name: Checkout PR merge commit
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          ref: ${{ github.sha }}
+          fetch-depth: 0
+          path: current
 
       - name: Set up JDK 21
         uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5
@@ -52,11 +60,29 @@ jobs:
           done
 
       - name: Init base schema
+        working-directory: baseline
         run: |
           ./gradlew --no-daemon createPGDB -PdbName=fineract_tenants
           ./gradlew --no-daemon createPGDB -PdbName=$DB_NAME
 
-      - name: Start backend on base branch
+      - name: Print checked out revisions
+        run: |
+          echo "Base branch ref: ${{ github.event.pull_request.base.ref }}"
+          echo "Base branch event SHA:"
+          echo "${{ github.event.pull_request.base.sha }}"
+          echo "PR head SHA:"
+          echo "${{ github.event.pull_request.head.sha }}"
+          echo "GitHub merge SHA:"
+          echo "${{ github.sha }}"
+          echo "Baseline revision:"
+          git -C baseline rev-parse HEAD
+          git -C baseline log -1 --oneline
+          echo "Merged PR revision:"
+          git -C current rev-parse HEAD
+          git -C current log -1 --oneline
+
+      - name: Start backend on base commit
+        working-directory: baseline
         run: |
           ./gradlew :fineract-provider:devRun --args="\
           --spring.datasource.hikari.driverClassName=org.postgresql.Driver \
@@ -79,19 +105,16 @@ jobs:
 
           start_ts=$(date +%s)
           while true; do
-            # If the process died, fail fast
             if ! kill -0 "$BACKEND_PID" 2>/dev/null; then
               echo "Backend process exited before Actuator became available."
               exit 1
             fi
 
-            # Check endpoint
             if curl -kfsS "$ACTUATOR_URL" >/dev/null 2>&1; then
               echo "Actuator is up."
               break
             fi
 
-            # Timeout
             now_ts=$(date +%s)
             if [ $((now_ts - start_ts)) -ge "$TIMEOUT_SECONDS" ]; then
               echo "Timed out waiting for Actuator."
@@ -101,19 +124,15 @@ jobs:
             sleep "$INTERVAL_SECONDS"
           done
 
-      - name: Stop backend
+      - name: Stop baseline backend
+        if: always()
+        working-directory: baseline
         run: |
           kill $(cat backend.pid)
           sleep 10
 
-      - name: Checkout the PR branch
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-        with:
-          repository: ${{ github.event.pull_request.head.repo.full_name }}
-          ref: ${{ github.event.pull_request.head.sha }}
-          fetch-depth: 0
-
-      - name: Start backend on PR branch
+      - name: Start backend on merged PR commit
+        working-directory: current
         run: |
           ./gradlew :fineract-provider:devRun --args="\
           --spring.datasource.hikari.driverClassName=org.postgresql.Driver \
@@ -136,19 +155,16 @@ jobs:
 
           start_ts=$(date +%s)
           while true; do
-            # If the process died, fail fast
             if ! kill -0 "$BACKEND_PID" 2>/dev/null; then
               echo "Backend process exited before Actuator became available."
               exit 1
             fi
 
-            # Check endpoint
             if curl -kfsS "$ACTUATOR_URL" >/dev/null 2>&1; then
               echo "Actuator is up."
               break
             fi
 
-            # Timeout
             now_ts=$(date +%s)
             if [ $((now_ts - start_ts)) -ge "$TIMEOUT_SECONDS" ]; then
               echo "Timed out waiting for Actuator."
@@ -157,7 +173,10 @@ jobs:
 
             sleep "$INTERVAL_SECONDS"
           done
-      - name: Stop backend
+
+      - name: Stop PR backend
+        if: always()
+        working-directory: current
         run: |
           kill $(cat backend.pid)
           sleep 10

fineract-core/src/main/java/org/apache/fineract/infrastructure/event/external/service/ExternalEventConfigurationValidationService.java

@@ -78,10 +78,6 @@ private void validateEventConfigurationForIndividualTenant(FineractPlatformTenan
             log.debug("Missing from eventConfigurations: {}", CollectionUtils.subtract(eventConfigurations, eventClasses));
         }
 
-        if (eventClasses.size() != eventConfigurations.size()) {
-            throw new ExternalEventConfigurationNotFoundException();
-        }
-
         for (String eventTypeClass : eventClasses) {
             if (!eventConfigurations.contains(eventTypeClass)) {
                 throw new ExternalEventConfigurationNotFoundException(eventTypeClass);

fineract-provider/src/test/java/org/apache/fineract/infrastructure/event/external/service/ExternalEventConfigurationValidationServiceTest.java

@@ -150,7 +150,7 @@ public void givenNoEventConfigurationWhenValidatedThenThrowException() throws Ex
                 () -> underTest.afterPropertiesSet());
 
         // then
-        String expectedMessage = "No external events configured";
+        String expectedMessage = "Configuration not found for external event LoanAccountsStayedLockedBusinessEvent";
 
         String actualMessage = exceptionThrown.getMessage();