From 24a5536f8d58db83c756facd6dd37534e3226baf Mon Sep 17 00:00:00 2001 From: Aleksandr Efimov Date: Tue, 1 Sep 2026 19:40:45 +0300 Subject: [PATCH 1/2] docs: the Substrait round-trip test command needs the substrait feature --- datafusion/sqllogictest/README.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/datafusion/sqllogictest/README.md b/datafusion/sqllogictest/README.md index 76c28b5ecd2ec..687f3b9bddc28 100644 --- a/datafusion/sqllogictest/README.md +++ b/datafusion/sqllogictest/README.md @@ -397,17 +397,18 @@ generated DataFusion logical plan (SQL statement → DF logical → Substrait Not all statements will be round-tripped, some statements like CREATE, INSERT, SET or EXPLAIN statements will be issued as is, but any other statement will be round-tripped to/from Substrait. -_WARNING_: as there are still a lot of failures in this mode (https://github.com/apache/datafusion/issues/16248), -it is not enforced in the CI, instead, it needs to be run manually with the following command: +_WARNING_: this mode lives behind the `substrait` feature, and it still reports failures, so it is not enforced +in the CI and needs to be run manually. Some of the failures are collected in +https://github.com/apache/datafusion/issues/16248. ```shell -cargo test --test sqllogictests -- --substrait-round-trip +cargo test --test sqllogictests --features substrait -- --substrait-round-trip ``` For focusing on one specific failing test, a file:line filter can be used: ```shell -cargo test --test sqllogictests -- --substrait-round-trip binary.slt:23 +cargo test --test sqllogictests --features substrait -- --substrait-round-trip binary.slt:23 ``` ## `.slt` file format From 28a9140791eef6eabc3c22fa2d0d6d78bbd6aa75 Mon Sep 17 00:00:00 2001 From: Aleksandr Efimov Date: Tue, 1 Sep 2026 19:46:07 +0300 Subject: [PATCH 2/2] docs: CI runs the round-trip mode over one file, not none --- datafusion/sqllogictest/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/datafusion/sqllogictest/README.md b/datafusion/sqllogictest/README.md index 687f3b9bddc28..4781dae3f09b3 100644 --- a/datafusion/sqllogictest/README.md +++ b/datafusion/sqllogictest/README.md @@ -397,9 +397,9 @@ generated DataFusion logical plan (SQL statement → DF logical → Substrait Not all statements will be round-tripped, some statements like CREATE, INSERT, SET or EXPLAIN statements will be issued as is, but any other statement will be round-tripped to/from Substrait. -_WARNING_: this mode lives behind the `substrait` feature, and it still reports failures, so it is not enforced -in the CI and needs to be run manually. Some of the failures are collected in -https://github.com/apache/datafusion/issues/16248. +_WARNING_: this mode lives behind the `substrait` feature, and the full suite still reports failures. CI therefore +runs it over a single file, through `cargo xtask ci step test substrait`, which filters to `limit.slt`. Some of the +failures are collected in https://github.com/apache/datafusion/issues/16248. To run it over every file: ```shell cargo test --test sqllogictests --features substrait -- --substrait-round-trip