Cover pragma value failures and simplify literal backtracking

Author: LucaCappelletti94

src/parser/mod.rs

@@ -20586,9 +20586,9 @@ impl<'a> Parser<'a> {
                 return self.expected_ref("number, name or string", self.peek_token_ref());
             }
         }
-        match self.maybe_parse(|parser| parser.parse_value())? {
-            Some(value) => Ok(Expr::Value(value)),
-            None => Ok(Expr::Identifier(self.parse_identifier()?)),
+        match self.try_parse(|parser| parser.parse_value()) {
+            Ok(value) => Ok(Expr::Value(value)),
+            Err(_) => Ok(Expr::Identifier(self.parse_identifier()?)),
         }
     }
 

tests/sqlparser_sqlite.rs

@@ -1335,8 +1335,20 @@ fn pragma_values() {
             "PRAGMA x = NULL",
             "Expected: number, name or string, found: NULL",
         ),
+        ("PRAGMA x()", "Expected: identifier, found: )"),
+        ("PRAGMA x = )", "Expected: identifier, found: )"),
+        ("PRAGMA x(=)", "Expected: identifier, found: ="),
     ] {
         let actual = sqlite_and_generic().parse_sql_statements(sql).unwrap_err();
         assert!(actual.to_string().contains(error), "{sql}: {actual}");
     }
 }
+
+#[cfg(feature = "bigdecimal")]
+#[test]
+fn pragma_values_reject_unrepresentable_signed_numbers() {
+    let error = sqlite_and_generic()
+        .parse_sql_statements("PRAGMA x = -1e999999999999999999999999")
+        .unwrap_err();
+    assert!(matches!(error, ParserError::ParserError(_)));
+}