From ee66fa5aa988d52010d94a5e3941851bd5313639 Mon Sep 17 00:00:00 2001 From: aibrahiim Date: Thu, 22 Oct 2026 11:33:14 +0300 Subject: [PATCH] drop transformers 428 --- .../trigger_files/beam_PostCommit_Python_Dependency.json | 2 +- sdks/python/test-suites/tox/py311/build.gradle | 8 +++----- sdks/python/tox.ini | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/.github/trigger_files/beam_PostCommit_Python_Dependency.json b/.github/trigger_files/beam_PostCommit_Python_Dependency.json index 9bc6afbb0969..0c0e8ca6a12b 100644 --- a/.github/trigger_files/beam_PostCommit_Python_Dependency.json +++ b/.github/trigger_files/beam_PostCommit_Python_Dependency.json @@ -1,4 +1,4 @@ { "comment": "Modify this file in a trivial way to cause this test suite to run", - "modification": 5 + "modification": 8 } diff --git a/sdks/python/test-suites/tox/py311/build.gradle b/sdks/python/test-suites/tox/py311/build.gradle index 433b0052b08b..3228469cd6bd 100644 --- a/sdks/python/test-suites/tox/py311/build.gradle +++ b/sdks/python/test-suites/tox/py311/build.gradle @@ -145,11 +145,9 @@ toxTask "testPy311tensorflow-212", "py311-tensorflow-212", "${posargs}" test.dependsOn "testPy311tensorflow-212" postCommitPyDep.dependsOn "testPy311tensorflow-212" -// Create a test task for each minor version of transformers -toxTask "testPy311transformers-428", "py311-transformers-428", "${posargs}" -test.dependsOn "testPy311transformers-428" -postCommitPyDep.dependsOn "testPy311transformers-428" - +// Create a test task for each minor version of transformers. +// Dropped transformers-428: sentence-transformers==2.2.2 + torch<1.14 is +// ResolutionImpossible on Python 3.11 (see #30799). toxTask "testPy311transformers-447", "py311-transformers-447", "${posargs}" test.dependsOn "testPy311transformers-447" postCommitPyDep.dependsOn "testPy311transformers-447" diff --git a/sdks/python/tox.ini b/sdks/python/tox.ini index a1bc7ba3322d..7a822cab7593 100644 --- a/sdks/python/tox.ini +++ b/sdks/python/tox.ini @@ -503,15 +503,15 @@ commands = # Allow exit code 5 (no tests run) so that we can run this command safely on arbitrary subdirectories. /bin/sh -c 'pytest -o junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 -m uses_xgboost {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret' -[testenv:py311-transformers-{428,447,latest}] +[testenv:py311-transformers-{447,latest}] deps = # Environment dependencies are defined in the `setenv` section and installed in the `commands` section. pip_pre = False extras = test setenv = COMMON_DEPS = tensorflow==2.12.0 protobuf==4.25.5 pip==25.0.1 - # sentence-transformers 2.2.2 is the latest version that supports transformers 4.28.x - 428: DEPS = sentence-transformers==2.2.2 'transformers>=4.28.0,<4.29.0' 'torch>=1.9.0,<1.14.0' + # transformers-428 dropped: sentence-transformers==2.2.2 + torch<1.14 is + # ResolutionImpossible on Python 3.11. 447: DEPS = 'transformers>=4.47.0,<4.48.0' 'torch>=1.9.0,<1.14.0' latest: DEPS = 'transformers>=4.55.0' 'torch>=2.0.0' 'accelerate>=1.6.0' commands =