From 9db91a086460582071ef6c85854a67f4463ccf73 Mon Sep 17 00:00:00 2001 From: nitinware Date: Mon, 7 Sep 2026 11:21:08 -0500 Subject: [PATCH] Remove nullness suppression in TimestampCombiner The class-level @SuppressWarnings({"nullness", "keyfor"}) on TimestampCombiner has no matching Checker Framework diagnostic. The enum has no fields, and Iterables.get(timestamps, 0) at END_OF_WINDOW.combine is preceded by checkArgument on size > 0. Compiling sdks:java:core with -PenableCheckerFramework is clean after removing the annotation, so no other changes are needed. Progress on #20507. --- .../apache/beam/sdk/transforms/windowing/TimestampCombiner.java | 1 - 1 file changed, 1 deletion(-) diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/TimestampCombiner.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/TimestampCombiner.java index b5cedebf86aa..e743388a56ea 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/TimestampCombiner.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/TimestampCombiner.java @@ -33,7 +33,6 @@ *

In particular, these govern the timestamp on the output of a grouping transform such as {@link * GroupByKey} or {@link Combine}. */ -@SuppressWarnings({"nullness", "keyfor"}) // TODO(https://github.com/apache/beam/issues/20497) public enum TimestampCombiner { /** * The policy of taking at the earliest of a set of timestamps.