Skip to content

Commit ce77042

Browse files
AXIS2-5948 Proxy settings ignored if username not specified
1 parent c6c756c commit ce77042

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

modules/transport/http/src/main/java/org/apache/axis2/transport/http/impl/httpclient5/HTTPProxyConfigurator.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,16 +145,14 @@ public static void configure(MessageContext messageContext, RequestConfig.Builde
145145

146146
// AXIS2-6051, CredentialsProvider no longer has setCredentialsProvider() however BasicCredentialsProvider
147147
// does have it. clientContext.getCredentialsProvider() returns CredentialsProvider.
148-
HttpHost proxy = new HttpHost(proxyHost, proxyPort);
149148
if (proxyCredentials != null) {
150-
if (clientContext.getCredentialsProvider() == null) {
151-
BasicCredentialsProvider credsProvider = new BasicCredentialsProvider();
152-
clientContext.setCredentialsProvider(credsProvider);
153-
credsProvider.setCredentials(new AuthScope(null, -1), proxyCredentials);
154-
}
155149
requestConfig.setAuthenticationEnabled(true);
156-
requestConfig.setProxy(proxy);
150+
BasicCredentialsProvider credsProvider = new BasicCredentialsProvider();
151+
clientContext.setCredentialsProvider(credsProvider);
152+
credsProvider.setCredentials(new AuthScope(null, -1), proxyCredentials);
157153
}
154+
HttpHost proxy = new HttpHost(proxyHost, proxyPort);
155+
requestConfig.setProxy(proxy);
158156
}
159157

160158
private static OMElement getProxyConfigurationElement(Parameter proxySettingsFromAxisConfig)

0 commit comments

Comments
 (0)