Skip to content

Commit 8fac90e

Browse files
springbootdemo: Gemini review fixes — uri.endsWith consistency and axis2.version property use
- Replace uri.contains(\"/swagger-ui\") with uri.endsWith(\"/swagger-ui\") || uri.contains(\"/swagger-ui/\") in OpenApiServlet (both springbootdemo and springbootdemo-tomcat11) — prevents false matches on URIs that happen to contain /swagger-ui as a non-terminal substring - Use \${axis2.version} property for axis2-openapi dependency version in springbootdemo-tomcat11 pom.xml — consistent with the property already used in the antrun copy tasks added in the previous commit Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent d82edc0 commit 8fac90e

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

modules/samples/userguide/src/userguide/springbootdemo-tomcat11/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@
234234
<dependency>
235235
<groupId>org.apache.axis2</groupId>
236236
<artifactId>axis2-openapi</artifactId>
237-
<version>2.0.1-SNAPSHOT</version>
237+
<version>${axis2.version}</version>
238238
</dependency>
239239
<dependency>
240240
<groupId>org.apache.neethi</groupId>

modules/samples/userguide/src/userguide/springbootdemo-tomcat11/src/main/java/userguide/springboot/configuration/OpenApiServlet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
6868
handler.handleOpenApiJsonRequest(request, response);
6969
} else if (uri.endsWith("/openapi.yaml")) {
7070
handler.handleOpenApiYamlRequest(request, response);
71-
} else if (uri.contains("/swagger-ui")) {
71+
} else if (uri.endsWith("/swagger-ui") || uri.contains("/swagger-ui/")) {
7272
handler.handleSwaggerUIRequest(request, response);
7373
} else {
7474
response.sendError(HttpServletResponse.SC_NOT_FOUND);

modules/samples/userguide/src/userguide/springbootdemo/src/main/java/userguide/springboot/configuration/OpenApiServlet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
6868
handler.handleOpenApiJsonRequest(request, response);
6969
} else if (uri.endsWith("/openapi.yaml")) {
7070
handler.handleOpenApiYamlRequest(request, response);
71-
} else if (uri.contains("/swagger-ui")) {
71+
} else if (uri.endsWith("/swagger-ui") || uri.contains("/swagger-ui/")) {
7272
handler.handleSwaggerUIRequest(request, response);
7373
} else {
7474
response.sendError(HttpServletResponse.SC_NOT_FOUND);

0 commit comments

Comments
 (0)