test(flight-sql-jdbc): cover ResultSet metadata nullability (GH-782)

Author: mjuarros

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/ArrowFlightPreparedStatementTest.java

@@ -272,8 +272,8 @@ public void testReturnColumnNullability() throws SQLException {
     try (final PreparedStatement psmt = connection.prepareStatement(query)) {
       assertAll(
           "Column nullability is as expected",
-          () -> assertThat("nullable", equalTo(psmt.getMetaData().getColumnName(1))),
-          () -> assertThat("required", equalTo(psmt.getMetaData().getColumnName(2))),
+          () -> assertThat(psmt.getMetaData().getColumnName(1), equalTo("nullable")),
+          () -> assertThat(psmt.getMetaData().getColumnName(2), equalTo("required")),
           () ->
               assertThat(
                   psmt.getMetaData().isNullable(1), equalTo(ResultSetMetaData.columnNullable)),

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/ArrowFlightStatementExecuteTest.java

@@ -25,6 +25,7 @@
 
 import java.sql.Connection;
 import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
 import java.sql.SQLException;
 import java.sql.Statement;
 import java.util.Collections;
@@ -153,6 +154,8 @@ public void testExecuteShouldRunSelectQuery() throws SQLException {
     try (final ResultSet resultSet = statement.getResultSet()) {
       final int columnCount = resultSet.getMetaData().getColumnCount();
       assertThat(columnCount, is(1));
+      assertThat(
+          resultSet.getMetaData().isNullable(1), equalTo(ResultSetMetaData.columnNullable));
       int rowCount = 0;
       for (; resultSet.next(); rowCount++) {
         assertThat(numbers.remove(resultSet.getByte(1)), is(true));

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/ResultSetMetadataTest.java

@@ -184,6 +184,13 @@ public void testShouldGetTableName() throws SQLException {
     assertThat(metadata.getTableName(3), equalTo("TABLE_NAME_3"));
   }
 
+  @Test
+  public void testShouldIsNullable() throws SQLException {
+    assertThat(metadata.isNullable(1), equalTo(ResultSetMetaData.columnNullable));
+    assertThat(metadata.isNullable(2), equalTo(ResultSetMetaData.columnNullable));
+    assertThat(metadata.isNullable(3), equalTo(ResultSetMetaData.columnNoNulls));
+  }
+
   @Test
   public void testShouldIsAutoIncrement() throws SQLException {
     assertThat(metadata.isAutoIncrement(1), equalTo(true));

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/utils/ConvertUtilsTest.java

@@ -74,7 +74,7 @@ public void testShouldConvertArrowFieldsToColumnMetaDataList() {
             new Field(
                 "col2",
                 new FieldType(
-                    true,
+                    false,
                     ArrowType.Utf8View.INSTANCE,
                     null,
                     new FlightSqlColumnMetadata.Builder()
@@ -106,7 +106,7 @@ public void testShouldConvertArrowFieldsToColumnMetaDataList() {
                     .setSchemaName("schema1")
                     .setTableName("table1")
                     .setColumnName("col2")
-                    .setNullable(ResultSetMetaData.columnNullable)
+                    .setNullable(ResultSetMetaData.columnNoNulls)
                     .setType(
                         Common.AvaticaType.newBuilder()
                             .setId(SqlTypes.getSqlTypeIdFromArrowType(ArrowType.Utf8View.INSTANCE))

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/utils/CoreMockedSqlProducers.java

@@ -367,7 +367,7 @@ private static void addLegacyMetadataSqlCmdSupport(final MockFlightSqlProducer p
                 new Field(
                     "float2",
                     new FieldType(
-                        true,
+                        false,
                         new ArrowType.FloatingPoint(FloatingPointPrecision.SINGLE),
                         null,
                         new FlightSqlColumnMetadata.Builder()