Commit b7f7de3
[AMORO-4099] Add table-summary metric collection option for non-optimizing tables (#4101)
* [AMORO-4099] Add table-summary metric collection option for non-optimizing tables
- Allow collecting table_summary metrics when self-optimizing is disabled
by setting table-summary.enabled=true
- Fix periodic collection bug: remove optimizingNotNecessary() call in
summary-only branch to prevent snapshot gate from blocking subsequent
collections
- Separate property key from self-optimizing prefix:
self-optimizing.table-summary.enabled -> table-summary.enabled
- Add debug logging for table summary collection path
- Add comprehensive test coverage for summary-only mode
Signed-off-by: Jiwon Park <jpark92@outlook.kr>
* Fix review issues: remove double-append bug and redundant tableSummaryOnly gate
- Remove duplicate newAppend().commit() in test appendData() since
OptimizingTestHelpers.appendBase() already commits
- Remove unused AppendFiles import
- Remove redundant tableSummaryOnly bypass in execute() since
snapshotChanged already covers unoptimized data
- Fix misleading test comment
Signed-off-by: Jiwon Park <jpark92@outlook.kr>
* Fix property key comment to match actual table property name
Signed-off-by: Jiwon Park <jpark92@outlook.kr>
---------
Signed-off-by: Jiwon Park <jpark92@outlook.kr>
Co-authored-by: ConradJam <jam.gzczy@gmail.com>1 parent 10d13d4 commit b7f7de3
5 files changed
Lines changed: 462 additions & 11 deletions
File tree
- amoro-ams/src
- main/java/org/apache/amoro/server
- scheduler/inline
- table
- test/java/org/apache/amoro/server/table
- amoro-common/src/main/java/org/apache/amoro/config
- amoro-format-iceberg/src/main/java/org/apache/amoro/table
Lines changed: 26 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | 73 | | |
75 | 74 | | |
76 | 75 | | |
77 | | - | |
| 76 | + | |
78 | 77 | | |
79 | 78 | | |
80 | 79 | | |
| |||
102 | 101 | | |
103 | 102 | | |
104 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
105 | 115 | | |
106 | 116 | | |
107 | 117 | | |
108 | 118 | | |
109 | | - | |
110 | 119 | | |
111 | 120 | | |
112 | 121 | | |
| |||
147 | 156 | | |
148 | 157 | | |
149 | 158 | | |
150 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
151 | 169 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
| 170 | + | |
158 | 171 | | |
159 | 172 | | |
160 | 173 | | |
161 | 174 | | |
162 | 175 | | |
163 | 176 | | |
164 | | - | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
165 | 180 | | |
166 | 181 | | |
167 | 182 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
235 | 240 | | |
236 | 241 | | |
237 | 242 | | |
| |||
0 commit comments