Skip to content

Commit 9ab90d0

Browse files
MeAkibalan-agius4
authored andcommitted
fixup! fix(@angular/build): only require karma-coverage when coverage is enabled
1 parent 108147a commit 9ab90d0

1 file changed

Lines changed: 4 additions & 25 deletions

File tree

  • packages/angular/build/src/builders/unit-test/runners/karma

‎packages/angular/build/src/builders/unit-test/runners/karma/index_spec.ts‎

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,43 +6,22 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
import assert from 'node:assert';
10-
import { mkdir, mkdtemp, writeFile } from 'node:fs/promises';
11-
import { join } from 'node:path';
129
import type { NormalizedUnitTestBuilderOptions } from '../../options';
1310
import KarmaTestRunner from './index';
1411

1512
describe('KarmaTestRunner', () => {
1613
describe('validateDependencies', () => {
17-
let projectSourceRoot: string;
18-
1914
function createOptions(coverageEnabled: boolean): NormalizedUnitTestBuilderOptions {
2015
return {
21-
projectSourceRoot,
16+
projectSourceRoot: '/non-existent',
2217
coverage: { enabled: coverageEnabled },
2318
} as NormalizedUnitTestBuilderOptions;
2419
}
2520

26-
beforeAll(async () => {
27-
const baseTmpDir = process.env['TEST_TMPDIR'];
28-
assert(baseTmpDir, 'TEST_TMPDIR is not set');
29-
projectSourceRoot = await mkdtemp(join(baseTmpDir, 'angular-cli-karma-runner-'));
30-
31-
// A project with karma and karma-jasmine installed but not karma-coverage
32-
await writeFile(join(projectSourceRoot, 'package.json'), '{"name": "test-project"}');
33-
for (const packageName of ['karma', 'karma-jasmine']) {
34-
const packageRoot = join(projectSourceRoot, 'node_modules', packageName);
35-
await mkdir(packageRoot, { recursive: true });
36-
await writeFile(
37-
join(packageRoot, 'package.json'),
38-
JSON.stringify({ name: packageName, version: '0.0.0', main: 'index.js' }),
39-
);
40-
await writeFile(join(packageRoot, 'index.js'), '');
41-
}
42-
});
43-
4421
it('does not require karma-coverage when coverage is disabled', () => {
45-
expect(() => KarmaTestRunner.validateDependencies?.(createOptions(false))).not.toThrow();
22+
expect(() => KarmaTestRunner.validateDependencies?.(createOptions(false))).toThrowError(
23+
/^(?!.*karma-coverage)/s,
24+
);
4625
});
4726

4827
it('requires karma-coverage when coverage is enabled', () => {

0 commit comments

Comments
 (0)