add precondition checks for missing volumes

Author: angelo-v

src/Dockerfile

@@ -11,6 +11,7 @@ ENV TEMPORARY_CERT_NAME=solid-temporary
 
 WORKDIR ${SOLID_HOME}
 COPY ./src/entrypoint.sh ./entrypoint.sh
+COPY ./src/checks.sh ./checks.sh
 COPY ./src/create-temporary-cert.sh ./create-temporary-cert.sh
 RUN chown --recursive ${PROCESS_USER}:${PROCESS_USER} ${SOLID_HOME}
 
@@ -27,4 +28,4 @@ VOLUME $SOLID_HOME
 
 ENTRYPOINT ["./entrypoint.sh"]
 
-CMD ["start"]
+CMD ["start"]

src/checks.sh

@@ -0,0 +1,27 @@
+#!/bin/sh
+
+checks_failed=0
+
+check_failed()
+{
+  checks_failed=$((checks_failed + 1))
+}
+check_dir_exists()
+{
+  dir=$1
+  if [ -f "${dir}" ]; then
+    echo "✓ ${dir} exists"
+  else
+    echo "✗ ${dir} missing"
+    check_failed
+  fi
+}
+
+check_dir_exists "${SOLID_HOME}/data"
+check_dir_exists "${SOLID_HOME}/.db"
+check_dir_exists "${SOLID_HOME}/config"
+
+if [ "$checks_failed" -gt 0 ]; then
+  echo "Finished: ERROR"
+  exit 1
+fi

src/entrypoint.sh

@@ -2,6 +2,8 @@
 
 set -e
 
+./checks.sh
+
 ./create-temporary-cert.sh ${TEMPORARY_CERT_NAME}
 
-solid "$@"
+solid "$@"

test/test_precondition_checks.py

@@ -0,0 +1,39 @@
+# coding=utf-8
+import docker
+import pytest
+import time
+
+testinfra_hosts = ['docker://test_container']
+
+
+@pytest.fixture(scope="module", autouse=True)
+def container(client, image):
+  container = client.containers.run(
+      image.id,
+      name="test_container",
+      volumes={
+        'missing_data': {'bind': '/opt/solid/data'},
+        'missing_db': {'bind': '/opt/solid/.db'},
+        'missing_config': {'bind': '/opt/solid/config'}
+      },
+      environment=[
+        "SOLID_SERVER_KEY=/missing/key",
+        "SOLID_SERVER_CERT=/missing/cert"
+      ],
+      detach=True,
+      tty=True
+  )
+  # give the solid process some seconds to create the directory structure before making assertions
+  time.sleep(2)
+  yield container
+  container.remove(force=True)
+
+
+def test_container_fails_with_errors(container):
+  assert container.status == "created"
+  logs = container.logs()
+  assert "✗ /opt/solid/data missing" in logs
+  assert "✗ /opt/solid/.db missing" in logs
+  assert "✗ /opt/solid/config missing" in logs
+  assert "Finished: ERROR" in logs
+  assert not "Finished: SUCCESS" in logs