From 8129881f77742b87cae6b38690ee7b89f8e23a6a Mon Sep 17 00:00:00 2001
From: amrali-eg <32075105+amrali-eg@users.noreply.github.com>
Date: Sun, 20 Sep 2026 01:40:14 +0300
Subject: [PATCH 1/2] Make the confirmation dialog tests reach the cases they
 name

ItBuildsWhenNothingIsRefused used a Shift_JIS file, which the policy refuses,
and asserted the absence of prose the dialog no longer uses, so it passed with
the refusal panel showing. ItBuildsForAMixOfEveryOutcome only checked that the
form had some controls, and its fixtures did not cover every outcome.

The first is replaced by a test with an automatically convertible file that
asserts the plan and the absence of the source-choice controls by name. The
second is replaced by a mix with a different number of files in each of the
five categories, checking the plan summary, the count shown beside each label
and the files offered a source choice.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 .../ConversionConfirmationFormTests.cs        | 79 ++++++++++++++++---
 1 file changed, 69 insertions(+), 10 deletions(-)

diff --git a/sources/EncodingChecker.Tests/ConversionConfirmationFormTests.cs b/sources/EncodingChecker.Tests/ConversionConfirmationFormTests.cs
index 0dde6ba..b790124 100644
--- a/sources/EncodingChecker.Tests/ConversionConfirmationFormTests.cs
+++ b/sources/EncodingChecker.Tests/ConversionConfirmationFormTests.cs
@@ -76,37 +76,96 @@ private static IEnumerable<Control> Descendants(Control root)
     private static string AllText(Control root) =>
         string.Join("\n", Descendants(root).Select(c => c.Text));
 
+    private static IEnumerable<Control> Named(Control root, string name) =>
+        Descendants(root).Where(c => c.Name == name);
+
+    // The count the dialog shows beside a category label, or null when the category is hidden.
+    private static string? CountShownFor(Control root, string label)
+    {
+        Label? cell = Descendants(root).OfType<Label>()
+            .FirstOrDefault(l => l.Text == label && l.Parent is TableLayoutPanel);
+
+        if (cell?.Parent is not TableLayoutPanel table)
+            return null;
+
+        return table.GetControlFromPosition(0, table.GetPositionFromControl(cell).Row)?.Text;
+    }
+
     [Fact]
-    public void ItBuildsForAMixOfEveryOutcome()
+    public void TheSummaryShowsEveryOutcomeWithItsCount()
     {
-        Write("jp.txt", "こんにちは世界。日本語のテキストです。", "shift_jis");
-        Write("ambiguous.txt", "Le café était déjà prêt", "windows-1252");
-        Write("plain.txt", "just ascii here", "ascii");
-        Write("already.txt", "already utf-8 世界", "utf-8");
+        // A different number of files in each of the five categories the dialog reports, so a
+        // count shown against the wrong label cannot go unnoticed: 1, 2, 3, 4 and 5.
+        WriteBytes("convertible1.txt", [0xEF, 0xBB, 0xBF, .. "hello world"u8]);
+
+        for (int i = 1; i <= 2; i++)
+            Write($"jp{i}.txt", "こんにちは世界。日本語のテキストです。", "shift_jis");
+
+        for (int i = 1; i <= 3; i++)
+            WriteBytes($"already{i}.txt", Encoding.UTF8.GetBytes("already utf-8 世界"));
+
+        for (int i = 1; i <= 4; i++)
+        {
+            byte[] unidentified = new byte[4096];
+            new Random(418 + i).NextBytes(unidentified);
+            WriteBytes($"unknown{i}.bin", unidentified);
+        }
+
+        for (int i = 1; i <= 5; i++)
+            WriteBytes($"double-bom{i}.txt", [0xEF, 0xBB, 0xBF, 0xEF, 0xBB, 0xBF, .. "hello world"u8]);
 
         ConversionPlan plan = Plan();
+        ConversionPlanSummary summary = plan.Summary;
+
+        // The fixtures reach the outcomes they are named for, or the checks below prove nothing.
+        Assert.Equal(15, summary.Selected);
+        Assert.Equal(1, summary.ReadyToConvert);
+        Assert.Equal(2, summary.NeedsSourceChoice);
+        Assert.Equal(3, summary.AlreadyTarget);
+        Assert.Equal(4, summary.NotIdentified);
+        Assert.Equal(5, summary.OtherRefusals);
 
         UiTest.OnStaThread(() =>
         {
             using var form = new ConversionConfirmationForm(plan);
 
-            Assert.NotEmpty(Descendants(form).ToList());
+            Assert.Equal("1", CountShownFor(form, "Ready to convert"));
+            Assert.Equal("2", CountShownFor(form, "Needs a source encoding"));
+            Assert.Equal("3", CountShownFor(form, "Already in the target encoding"));
+            Assert.Equal("4", CountShownFor(form, "Encoding not identified"));
+            Assert.Equal("5", CountShownFor(form, "Cannot be processed safely"));
+
+            // Only the files that need a source are offered a choice.
+            var refused = Assert.IsType<ListView>(
+                Assert.Single(Named(form, "lstRefusedFiles")));
+            Assert.Equal(
+                ["jp1.txt", "jp2.txt"],
+                refused.Items.Cast<ListViewItem>().Select(i => i.Text).Order());
+            Assert.Single(Named(form, "lstSourceEncoding"));
+            Assert.Single(Named(form, "btnConfirmSourceEncoding"));
         });
     }
 
     [Fact]
-    public void ItBuildsWhenNothingIsRefused()
+    public void ItBuildsWithoutASourceChoicePanelWhenNothingNeedsOne()
     {
-        // The common case, and the one where a refusal panel must not appear at all.
-        Write("jp.txt", "こんにちは世界。日本語のテキストです。", "shift_jis");
+        // The common case, and the one where the refusal panel must not appear at all.
+        WriteBytes("convertible.txt", [0xEF, 0xBB, 0xBF, .. "hello world"u8]);
 
         ConversionPlan plan = Plan();
 
+        PlannedFile planned = Assert.Single(plan.Files);
+        Assert.Equal(PlannedAction.Convert, planned.Action);
+        Assert.False(planned.NeedsSourceChoice);
+
         UiTest.OnStaThread(() =>
         {
             using var form = new ConversionConfirmationForm(plan);
 
-            Assert.DoesNotContain("need an explicit source encoding", AllText(form));
+            Assert.Equal("1", CountShownFor(form, "Ready to convert"));
+            Assert.Empty(Named(form, "lstRefusedFiles"));
+            Assert.Empty(Named(form, "lstSourceEncoding"));
+            Assert.Empty(Named(form, "btnConfirmSourceEncoding"));
         });
     }
 

From 4b6489f37ffddc6a28820bd329b935a290e63710 Mon Sep 17 00:00:00 2001
From: amrali-eg <32075105+amrali-eg@users.noreply.github.com>
Date: Sun, 20 Sep 2026 01:58:31 +0300
Subject: [PATCH 2/2] Check that empty categories are hidden and explain the
 dialog fixtures

The nothing-needs-a-source test now asserts the four empty categories are not
listed, so showing zero-count rows fails it. The mixed-outcome fixture says why
each file lands in its category, and the class summary describes the present
purpose instead of what was once untested.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 .../ConversionConfirmationFormTests.cs        | 21 ++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/sources/EncodingChecker.Tests/ConversionConfirmationFormTests.cs b/sources/EncodingChecker.Tests/ConversionConfirmationFormTests.cs
index b790124..cfe13fb 100644
--- a/sources/EncodingChecker.Tests/ConversionConfirmationFormTests.cs
+++ b/sources/EncodingChecker.Tests/ConversionConfirmationFormTests.cs
@@ -4,11 +4,9 @@
 namespace EncodingChecker.Tests;
 
 /// <summary>
-/// The confirmation dialog is the only part of the safety model a GUI user ever reads,
-/// and until now it was also the only part no test had ever executed. Layout code that
-/// has never run is layout code that throws the first time somebody converts a directory
-/// with an unusual mix of outcomes — and it would throw at exactly the moment the user is
-/// being asked to approve something.
+/// The confirmation dialog is the only part of the safety model a GUI user ever reads, and
+/// it describes the outcomes at exactly the moment the user is asked to approve them. Layout
+/// code that throws on an unusual mix of outcomes would fail there.
 ///
 /// These build it against real plans rather than asserting on pixels: every outcome mix,
 /// on an STA thread, checking that it constructs and that what it says matches the plan
@@ -96,6 +94,12 @@ public void TheSummaryShowsEveryOutcomeWithItsCount()
     {
         // A different number of files in each of the five categories the dialog reports, so a
         // count shown against the wrong label cannot go unnoticed: 1, 2, 3, 4 and 5.
+        //
+        // Each fixture reaches its category for a reason: a UTF-8 BOM the target omits is
+        // rewritten; Shift_JIS text needs the user to name its source; UTF-8 without a BOM
+        // already matches; random bytes identify as no encoding, and the fixed seeds keep them
+        // that way; two leading BOMs are refused for a reason no source choice can fix. If a
+        // detector change moves a fixture, the plan-summary assertions below fail first.
         WriteBytes("convertible1.txt", [0xEF, 0xBB, 0xBF, .. "hello world"u8]);
 
         for (int i = 1; i <= 2; i++)
@@ -163,6 +167,13 @@ public void ItBuildsWithoutASourceChoicePanelWhenNothingNeedsOne()
             using var form = new ConversionConfirmationForm(plan);
 
             Assert.Equal("1", CountShownFor(form, "Ready to convert"));
+
+            // Categories with no files are not listed at all.
+            Assert.Null(CountShownFor(form, "Needs a source encoding"));
+            Assert.Null(CountShownFor(form, "Already in the target encoding"));
+            Assert.Null(CountShownFor(form, "Encoding not identified"));
+            Assert.Null(CountShownFor(form, "Cannot be processed safely"));
+
             Assert.Empty(Named(form, "lstRefusedFiles"));
             Assert.Empty(Named(form, "lstSourceEncoding"));
             Assert.Empty(Named(form, "btnConfirmSourceEncoding"));