devcontainer improvements

Author: aligneddev

.devcontainer/DEVCONTAINER.md

@@ -6,7 +6,7 @@ This project uses a DevContainer for consistent local development across all tea
 
 - **Image Build**: `.devcontainer/Dockerfile` (based on `mcr.microsoft.com/devcontainers/dotnet:1-10.0-noble`)
 - **Features**: Node.js 24+ and GitHub CLI
-- **Post-create bootstrap**: Restores NuGet packages, runs frontend `npm ci`, and builds the solution
+- **Post-create bootstrap**: Configures SSH permissions, trusts dev HTTPS certs, and installs frontend dependencies
 
 ## Git Credentials Setup
 
@@ -66,11 +66,11 @@ The container exports these environment variables:
 
 The `postCreateCommand` runs automatically after container creation:
 
-1. `dotnet restore BikeTracking.slnx`
-2. `npm ci --prefix src/BikeTracking.Frontend`
-3. `dotnet build BikeTracking.slnx`
+1. Copies mounted host SSH files from `/root/.ssh-host` to `/root/.ssh` and applies secure file permissions
+2. `dotnet dev-certs https --trust`
+3. `npm ci --prefix src/BikeTracking.Frontend`
 
-SDK/tool installation (required .NET SDK, CSharpier, Aspire CLI) is baked into the image build in `.devcontainer/Dockerfile`, not installed at container start.
+SDK/tool installation and .NET dependency restore are baked into the image build in `.devcontainer/devcontainer.Dockerfile`, not installed at container start.
 
 **Output**: Terminal shows progress; container is ready when build succeeds.
 

.devcontainer/devcontainer.Dockerfile

@@ -4,13 +4,21 @@ FROM mcr.microsoft.com/devcontainers/dotnet:1-10.0-noble
 
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 
-RUN curl -fsSL https://dl.yarnpkg.com/debian/pubkey.gpg | gpg --dearmor > /usr/share/keyrings/yarn-archive-keyring.gpg
+WORKDIR /workspaces/neCodeBikeTracking
 
-# Install podman
-RUN apt-get update && apt-get install -y podman && rm -rf /var/lib/apt/lists/*
+ENV PATH="/usr/local/share/dotnet-tools:/root/.dotnet/tools:${PATH}"
 
 ARG REQUIRED_DOTNET_SDK_VERSION=10.0.200
 
+# Install podman and Node.js 24 in a single layer.
+# NodeSource nodejs already includes npm; installing distro npm causes conflicts.
+RUN curl -fsSL https://dl.yarnpkg.com/debian/pubkey.gpg | gpg --dearmor > /usr/share/keyrings/yarn-archive-keyring.gpg && apt-get update \
+  && curl -fsSL https://deb.nodesource.com/setup_24.x | bash - \
+  && apt-get update \
+  && apt-get install -y --no-install-recommends podman nodejs \
+  && rm -rf /var/lib/apt/lists/* \
+  && npm --version
+
 # Ensure the SDK version from global.json is available in the image.
 RUN if dotnet --list-sdks | grep -q "^${REQUIRED_DOTNET_SDK_VERSION}"; then \
       echo ".NET SDK ${REQUIRED_DOTNET_SDK_VERSION} already installed."; \
@@ -21,10 +29,26 @@ RUN if dotnet --list-sdks | grep -q "^${REQUIRED_DOTNET_SDK_VERSION}"; then \
       rm -f /tmp/dotnet-install.sh; \
     fi
 
-# Install required CLI tools once at image build time.
-RUN dotnet tool restore
-    
+# Install Aspire workload early — this layer survives .csproj / manifest changes.
 RUN curl -fsSL https://aspire.dev/install.sh | bash
 
-ENV PATH="/usr/local/share/dotnet-tools:/root/.dotnet/tools:${PATH}"
+# Copy dependency manifests first so restore layers can be cached.
+COPY global.json ./
+COPY BikeTracking.slnx ./
+COPY .config/dotnet-tools.json ./.config/dotnet-tools.json
+COPY src/BikeTracking.Api/BikeTracking.Api.csproj src/BikeTracking.Api/
+COPY src/BikeTracking.Api.Tests/BikeTracking.Api.Tests.csproj src/BikeTracking.Api.Tests/
+COPY src/BikeTracking.AppHost/BikeTracking.AppHost.csproj src/BikeTracking.AppHost/
+COPY src/BikeTracking.Domain.FSharp/BikeTracking.Domain.FSharp.fsproj src/BikeTracking.Domain.FSharp/
+COPY src/BikeTracking.Frontend/BikeTracking.Frontend.esproj src/BikeTracking.Frontend/
+COPY src/BikeTracking.ServiceDefaults/BikeTracking.ServiceDefaults.csproj src/BikeTracking.ServiceDefaults/
+
+# Warm NuGet cache and install CLI tools in a single layer.
+RUN dotnet tool restore && dotnet restore BikeTracking.slnx
+
+# Copy npm manifests and warm the npm package cache.
+# ~/.npm is outside the workspace bind mount, so the cache persists at runtime,
+# making postCreateCommand "npm ci" fast without re-downloading packages.
+COPY src/BikeTracking.Frontend/package.json src/BikeTracking.Frontend/package-lock.json /tmp/npm-warmup/
+RUN npm ci --prefix /tmp/npm-warmup && rm -rf /tmp/npm-warmup
 

.devcontainer/devcontainer.json

@@ -5,16 +5,14 @@
     "context": ".."
   },
   "features": {
-    "ghcr.io/devcontainers/features/node:1": {
-      "version": "24"
-    },
     "ghcr.io/devcontainers/features/github-cli:1": {}
   },
   "containerEnv": {
     "NODE_ENV": "development",
+    "ASPIRE_CONTAINER_RUNTIME": "podman",
     "SSL_CERT_DIR": "/root/.aspnet/dev-certs/trust:/usr/lib/ssl/certs"
   },
-  "postCreateCommand": "export ASPIRE_CONTAINER_RUNTIME=podman && mkdir -p /root/.ssh && cp /root/.ssh-host/* /root/.ssh/ && chmod 700 /root/.ssh && chmod 600 /root/.ssh/config /root/.ssh/aligneddev_github /root/.ssh/omnitech_github && chmod 644 /root/.ssh/*.pub /root/.ssh/known_hosts 2>/dev/null; dotnet dev-certs https --trust && dotnet tool restore && dotnet restore BikeTracking.slnx && dotnet build BikeTracking.slnx && npm ci --prefix src/BikeTracking.Frontend",
+  "postCreateCommand": "mkdir -p /root/.ssh && cp /root/.ssh-host/* /root/.ssh/ && chmod 700 /root/.ssh && chmod 600 /root/.ssh/config /root/.ssh/aligneddev_github /root/.ssh/omnitech_github && chmod 644 /root/.ssh/*.pub /root/.ssh/known_hosts 2>/dev/null; dotnet dev-certs https --trust && npm ci --prefix src/BikeTracking.Frontend",
   "customizations": {
     "vscode": {
       "extensions": [
@@ -53,17 +51,25 @@
           "editor.defaultFormatter": "esbenp.prettier-vscode",
           "editor.formatOnSave": true
         },
-        "eslint.validate": ["javascript", "typescript", "typescriptreact"]
+        "eslint.validate": ["javascript", "typescript", "typescriptreact"],
+        "dotnetAcquisitionExtension.existingDotnetPath": [
+          {
+            "extensionId": "ms-dotnettools.csdevkit",
+            "path": "/usr/share/dotnet"
+          },
+          {
+            "extensionId": "ms-dotnettools.csharp",
+            "path": "/usr/share/dotnet"
+          }
+        ]
       }
     }
   },
   "remoteUser": "root",
   "remoteEnv": {
-    "PATH": "${containerEnv:PATH}:/usr/local/share/dotnet-tools:/root/.dotnet/tools",
-    "SSH_AUTH_SOCK": "/ssh-agent"
+    "PATH": "${containerEnv:PATH}:/usr/local/share/dotnet-tools:/root/.dotnet/tools"
   },
   "mounts": [
-    "source=${env:SSH_AUTH_SOCK},target=/ssh-agent,type=bind",
     "source=/mnt/c/Users/klogan/.ssh,target=/root/.ssh-host,type=bind,readonly"
   ]
 }