From da3ffec69d6f8cf8e899a20c5b91d28c658bc208 Mon Sep 17 00:00:00 2001 From: Andreas Kunft Date: Tue, 10 Nov 2026 17:41:57 +0100 Subject: [PATCH] fix(ci): stop using the GCP service account key CI decoded GCP_CREDENTIALS_{STAGING,PRODUCTION} into credentials.json and exported GOOGLE_APPLICATION_CREDENTIALS. The only consumer is platform.generate_signed_url, and every test that reaches it unmocked is skipped (GCS_TEST_SLIDES_REMOVED_REASON), so no running test needs the key. Remove the secret declarations and the setup step from the reusable test workflows, the secret pass-through from their callers (including the paused stress workflow), and the mentions in CLAUDE.md, .github/CLAUDE.md and SPEC-BUILD-CHAIN-CICD-SERVICE.md. If the GCS tests are re-enabled, use Workload Identity Federation with service account impersonation and IAM signBlob instead of a key. --- .github/CLAUDE.md | 3 +-- .github/workflows/_scheduled-test-daily.yml | 12 ------------ .github/workflows/_scheduled-test-hourly.yml | 12 ------------ .github/workflows/_scheduled-test-stress.yml | 12 ------------ .github/workflows/_test.yml | 12 ------------ .github/workflows/ci-cd.yml | 2 -- .../workflows/scheduled-testing-production-daily.yml | 2 -- .../scheduled-testing-production-hourly.yml | 2 -- .../workflows/scheduled-testing-staging-daily.yml | 2 -- .../workflows/scheduled-testing-staging-hourly.yml | 2 -- .github/workflows/stress-testing-staging.yml.paused | 2 -- CLAUDE.md | 1 - specifications/SPEC-BUILD-CHAIN-CICD-SERVICE.md | 1 - 13 files changed, 1 insertion(+), 64 deletions(-) diff --git a/.github/CLAUDE.md b/.github/CLAUDE.md index 18eec701f..95d7f535f 100644 --- a/.github/CLAUDE.md +++ b/.github/CLAUDE.md @@ -173,8 +173,7 @@ and release validation — never in PR CI. GitHub secrets: `ANTHROPIC_API_KEY`, `AIGNOSTICS_CLIENT_ID_DEVICE_{STAGING,PRODUCTION}`, -`AIGNOSTICS_REFRESH_TOKEN_{STAGING,PRODUCTION}`, -`GCP_CREDENTIALS_{STAGING,PRODUCTION}` (base64 JSON), the BetterStack URLs above, +`AIGNOSTICS_REFRESH_TOKEN_{STAGING,PRODUCTION}`, the BetterStack URLs above, `CODECOV_TOKEN`, `SONAR_TOKEN`, `SENTRY_DSN`/`SENTRY_AUTH_TOKEN`, `UV_PUBLISH_TOKEN`, `KETRYX_PROJECT`/`KETRYX_API_KEY`, `SLACK_*_RELEASE_ANNOUNCEMENT`. diff --git a/.github/workflows/_scheduled-test-daily.yml b/.github/workflows/_scheduled-test-daily.yml index 3796d79f6..14762c630 100644 --- a/.github/workflows/_scheduled-test-daily.yml +++ b/.github/workflows/_scheduled-test-daily.yml @@ -13,16 +13,12 @@ on: required: true AIGNOSTICS_REFRESH_TOKEN_STAGING: required: true - GCP_CREDENTIALS_STAGING: - required: true BETTERSTACK_HEARTBEAT_URL_FLOWS_STAGING: required: true AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: required: true AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: required: true - GCP_CREDENTIALS_PRODUCTION: - required: true BETTERSTACK_HEARTBEAT_URL_FLOWS_PRODUCTION: required: true CODECOV_TOKEN: @@ -95,14 +91,6 @@ jobs: envkey_AIGNOSTICS_SENTRY_PROFILES_SAMPLE_RATE: 0 fail_on_empty: false - - name: Set up GCP credentials for bucket access - shell: bash - env: - GCP_CREDENTIALS: ${{ inputs.platform_environment == 'staging' && secrets.GCP_CREDENTIALS_STAGING || secrets.GCP_CREDENTIALS_PRODUCTION }} - run: | - echo "$GCP_CREDENTIALS" | base64 -d > credentials.json - echo "GOOGLE_APPLICATION_CREDENTIALS=$(pwd)/credentials.json" >> $GITHUB_ENV - - name: Validate installation (single Python version) id: validate continue-on-error: true diff --git a/.github/workflows/_scheduled-test-hourly.yml b/.github/workflows/_scheduled-test-hourly.yml index 5022b1cab..50de11b0f 100644 --- a/.github/workflows/_scheduled-test-hourly.yml +++ b/.github/workflows/_scheduled-test-hourly.yml @@ -18,16 +18,12 @@ on: required: true AIGNOSTICS_REFRESH_TOKEN_STAGING: required: true - GCP_CREDENTIALS_STAGING: - required: true BETTERSTACK_HEARTBEAT_URL_STAGING: required: true AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: required: true AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: required: true - GCP_CREDENTIALS_PRODUCTION: - required: true BETTERSTACK_HEARTBEAT_URL_PRODUCTION: required: true SENTRY_DSN: @@ -82,14 +78,6 @@ jobs: envkey_AIGNOSTICS_SENTRY_PROFILES_SAMPLE_RATE: 0 fail_on_empty: false - - name: Set up GCP credentials for bucket access - shell: bash - env: - GCP_CREDENTIALS: ${{ inputs.platform_environment == 'staging' && secrets.GCP_CREDENTIALS_STAGING || secrets.GCP_CREDENTIALS_PRODUCTION }} - run: | - echo "$GCP_CREDENTIALS" | base64 -d > credentials.json - echo "GOOGLE_APPLICATION_CREDENTIALS=$(pwd)/credentials.json" >> $GITHUB_ENV - - name: Test / scheduled env: BETTERSTACK_HEARTBEAT_URL: "${{ inputs.platform_environment == 'staging' && secrets.BETTERSTACK_HEARTBEAT_URL_STAGING || secrets.BETTERSTACK_HEARTBEAT_URL_PRODUCTION }}" diff --git a/.github/workflows/_scheduled-test-stress.yml b/.github/workflows/_scheduled-test-stress.yml index 61c7b133f..00a716722 100644 --- a/.github/workflows/_scheduled-test-stress.yml +++ b/.github/workflows/_scheduled-test-stress.yml @@ -18,14 +18,10 @@ on: required: true AIGNOSTICS_REFRESH_TOKEN_STAGING: required: true - GCP_CREDENTIALS_STAGING: - required: true AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: required: true AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: required: true - GCP_CREDENTIALS_PRODUCTION: - required: true SENTRY_DSN: required: true @@ -78,14 +74,6 @@ jobs: envkey_AIGNOSTICS_SENTRY_PROFILES_SAMPLE_RATE: 0 fail_on_empty: false - - name: Set up GCP credentials for bucket access - shell: bash - env: - GCP_CREDENTIALS: ${{ inputs.platform_environment == 'staging' && secrets.GCP_CREDENTIALS_STAGING || secrets.GCP_CREDENTIALS_PRODUCTION }} - run: | - echo "$GCP_CREDENTIALS" | base64 -d > credentials.json - echo "GOOGLE_APPLICATION_CREDENTIALS=$(pwd)/credentials.json" >> $GITHUB_ENV - - name: Test / stress shell: bash run: | diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml index 97dc12dc6..104c15946 100644 --- a/.github/workflows/_test.yml +++ b/.github/workflows/_test.yml @@ -17,14 +17,10 @@ on: required: false AIGNOSTICS_REFRESH_TOKEN_STAGING: required: false - GCP_CREDENTIALS_STAGING: - required: false AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: required: false AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: required: false - GCP_CREDENTIALS_PRODUCTION: - required: false CODECOV_TOKEN: required: false SONAR_TOKEN: @@ -131,14 +127,6 @@ jobs: envkey_AIGNOSTICS_SENTRY_PROFILES_SAMPLE_RATE: 0 fail_on_empty: false - - name: Set up GCP credentials for bucket access - shell: bash - env: - GCP_CREDENTIALS: ${{ inputs.platform_environment == 'staging' && secrets.GCP_CREDENTIALS_STAGING || secrets.GCP_CREDENTIALS_PRODUCTION }} - run: | - echo "$GCP_CREDENTIALS" | base64 -d > credentials.json - echo "GOOGLE_APPLICATION_CREDENTIALS=$(pwd)/credentials.json" >> $GITHUB_ENV - - name: Validate installation (single Python version) shell: bash run: | diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index e1bcb88ab..70b22ad17 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -138,10 +138,8 @@ jobs: secrets: AIGNOSTICS_CLIENT_ID_DEVICE_STAGING: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_STAGING }} AIGNOSTICS_REFRESH_TOKEN_STAGING: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_STAGING }} - GCP_CREDENTIALS_STAGING: ${{ secrets.GCP_CREDENTIALS_STAGING }} AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION }} AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_PRODUCTION }} - GCP_CREDENTIALS_PRODUCTION: ${{ secrets.GCP_CREDENTIALS_PRODUCTION }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} SENTRY_DSN: ${{ secrets.SENTRY_DSN }} # For metrics diff --git a/.github/workflows/scheduled-testing-production-daily.yml b/.github/workflows/scheduled-testing-production-daily.yml index 4f27d4b05..054ebd4d4 100644 --- a/.github/workflows/scheduled-testing-production-daily.yml +++ b/.github/workflows/scheduled-testing-production-daily.yml @@ -25,11 +25,9 @@ jobs: secrets: AIGNOSTICS_CLIENT_ID_DEVICE_STAGING: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_STAGING }} AIGNOSTICS_REFRESH_TOKEN_STAGING: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_STAGING }} - GCP_CREDENTIALS_STAGING: ${{ secrets.GCP_CREDENTIALS_STAGING }} BETTERSTACK_HEARTBEAT_URL_FLOWS_STAGING: ${{ secrets.BETTERSTACK_HEARTBEAT_URL_FLOWS_STAGING }} AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION }} AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_PRODUCTION }} - GCP_CREDENTIALS_PRODUCTION: ${{ secrets.GCP_CREDENTIALS_PRODUCTION }} BETTERSTACK_HEARTBEAT_URL_FLOWS_PRODUCTION: ${{ secrets.BETTERSTACK_HEARTBEAT_URL_FLOWS_PRODUCTION }} CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} diff --git a/.github/workflows/scheduled-testing-production-hourly.yml b/.github/workflows/scheduled-testing-production-hourly.yml index 4dd960dee..a99c91391 100644 --- a/.github/workflows/scheduled-testing-production-hourly.yml +++ b/.github/workflows/scheduled-testing-production-hourly.yml @@ -22,10 +22,8 @@ jobs: secrets: AIGNOSTICS_CLIENT_ID_DEVICE_STAGING: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_STAGING }} AIGNOSTICS_REFRESH_TOKEN_STAGING: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_STAGING }} - GCP_CREDENTIALS_STAGING: ${{ secrets.GCP_CREDENTIALS_STAGING }} BETTERSTACK_HEARTBEAT_URL_STAGING: ${{ secrets.BETTERSTACK_HEARTBEAT_URL_STAGING }} AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION }} AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_PRODUCTION }} - GCP_CREDENTIALS_PRODUCTION: ${{ secrets.GCP_CREDENTIALS_PRODUCTION }} BETTERSTACK_HEARTBEAT_URL_PRODUCTION: ${{ secrets.BETTERSTACK_HEARTBEAT_URL_PRODUCTION }} SENTRY_DSN: ${{ secrets.SENTRY_DSN }} # For metrics and heartbeat diff --git a/.github/workflows/scheduled-testing-staging-daily.yml b/.github/workflows/scheduled-testing-staging-daily.yml index c38a7e9d8..c9b5a7857 100644 --- a/.github/workflows/scheduled-testing-staging-daily.yml +++ b/.github/workflows/scheduled-testing-staging-daily.yml @@ -25,11 +25,9 @@ jobs: secrets: AIGNOSTICS_CLIENT_ID_DEVICE_STAGING: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_STAGING }} AIGNOSTICS_REFRESH_TOKEN_STAGING: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_STAGING }} - GCP_CREDENTIALS_STAGING: ${{ secrets.GCP_CREDENTIALS_STAGING }} BETTERSTACK_HEARTBEAT_URL_FLOWS_STAGING: ${{ secrets.BETTERSTACK_HEARTBEAT_URL_FLOWS_STAGING }} AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION }} AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_PRODUCTION }} - GCP_CREDENTIALS_PRODUCTION: ${{ secrets.GCP_CREDENTIALS_PRODUCTION }} BETTERSTACK_HEARTBEAT_URL_FLOWS_PRODUCTION: ${{ secrets.BETTERSTACK_HEARTBEAT_URL_FLOWS_PRODUCTION }} CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} diff --git a/.github/workflows/scheduled-testing-staging-hourly.yml b/.github/workflows/scheduled-testing-staging-hourly.yml index 878b8106e..54b315e63 100644 --- a/.github/workflows/scheduled-testing-staging-hourly.yml +++ b/.github/workflows/scheduled-testing-staging-hourly.yml @@ -22,10 +22,8 @@ jobs: secrets: AIGNOSTICS_CLIENT_ID_DEVICE_STAGING: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_STAGING }} AIGNOSTICS_REFRESH_TOKEN_STAGING: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_STAGING }} - GCP_CREDENTIALS_STAGING: ${{ secrets.GCP_CREDENTIALS_STAGING }} BETTERSTACK_HEARTBEAT_URL_STAGING: ${{ secrets.BETTERSTACK_HEARTBEAT_URL_STAGING }} AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION }} AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_PRODUCTION }} - GCP_CREDENTIALS_PRODUCTION: ${{ secrets.GCP_CREDENTIALS_PRODUCTION }} BETTERSTACK_HEARTBEAT_URL_PRODUCTION: ${{ secrets.BETTERSTACK_HEARTBEAT_URL_PRODUCTION }} SENTRY_DSN: ${{ secrets.SENTRY_DSN }} # For metrics and heartbeat diff --git a/.github/workflows/stress-testing-staging.yml.paused b/.github/workflows/stress-testing-staging.yml.paused index 572b86a13..664eee214 100644 --- a/.github/workflows/stress-testing-staging.yml.paused +++ b/.github/workflows/stress-testing-staging.yml.paused @@ -22,8 +22,6 @@ jobs: secrets: AIGNOSTICS_CLIENT_ID_DEVICE_STAGING: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_STAGING }} AIGNOSTICS_REFRESH_TOKEN_STAGING: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_STAGING }} - GCP_CREDENTIALS_STAGING: ${{ secrets.GCP_CREDENTIALS_STAGING }} AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION: ${{ secrets.AIGNOSTICS_CLIENT_ID_DEVICE_PRODUCTION }} AIGNOSTICS_REFRESH_TOKEN_PRODUCTION: ${{ secrets.AIGNOSTICS_REFRESH_TOKEN_PRODUCTION }} - GCP_CREDENTIALS_PRODUCTION: ${{ secrets.GCP_CREDENTIALS_PRODUCTION }} SENTRY_DSN: ${{ secrets.SENTRY_DSN }} # For metrics and heartbeat diff --git a/CLAUDE.md b/CLAUDE.md index df3d8557f..74321bcd4 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -707,7 +707,6 @@ AIGNOSTICS_REFRESH_TOKEN=your-staging-refresh-token * GitHub Actions secrets automatically populate .env * Uses `AIGNOSTICS_CLIENT_ID_DEVICE_STAGING` and `AIGNOSTICS_REFRESH_TOKEN_STAGING` -* GCP credentials for bucket access also configured **Running E2E locally:** diff --git a/specifications/SPEC-BUILD-CHAIN-CICD-SERVICE.md b/specifications/SPEC-BUILD-CHAIN-CICD-SERVICE.md index 7f64e803a..4bf0d3c69 100644 --- a/specifications/SPEC-BUILD-CHAIN-CICD-SERVICE.md +++ b/specifications/SPEC-BUILD-CHAIN-CICD-SERVICE.md @@ -324,7 +324,6 @@ uv run nox -s dist # Package building | `SONAR_TOKEN` | SonarQube authentication | `squ_xxxxxxxx` | | `AIGNOSTICS_CLIENT_ID_DEVICE` | Platform API testing | `client_id_value` | | `AIGNOSTICS_REFRESH_TOKEN` | Platform API testing | `refresh_token_value` | -| `GCP_CREDENTIALS` | Google Cloud authentication | `base64_encoded_json` | ---