From 064890aa9d22b6865e9c59d7a5c01a3136ffddd4 Mon Sep 17 00:00:00 2001 From: Sophia Boettcher Date: Mon, 9 Nov 2026 23:37:23 -0800 Subject: [PATCH 1/2] Close accepted client sockets on poll() early returns Close `conn` before returning `NO_REQUEST` on `EAGAIN`, `ECONNRESET`, `MBEDTLS_ERR_SSL_FATAL_ALERT_MESSAGE`, and `SSLV3_ALERT_CERTIFICATE_UNKNOWN` in `Server.poll()`, and break when `sock.recv_into(...) == 0` in `_receive_header_bytes()` and `_receive_body_bytes()`. Fixes #41 Signed-off-by: Sophia Boettcher --- adafruit_httpserver/server.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/adafruit_httpserver/server.py b/adafruit_httpserver/server.py index b0e3cc8..f79d80c 100644 --- a/adafruit_httpserver/server.py +++ b/adafruit_httpserver/server.py @@ -326,6 +326,8 @@ def _receive_header_bytes(self, sock: _ISocket) -> bytes: while b"\r\n\r\n" not in received_bytes: try: length = sock.recv_into(self._buffer, len(self._buffer)) + if length == 0: + break received_bytes += self._buffer[:length] except TimeoutError: break @@ -347,6 +349,8 @@ def _receive_body_bytes( while len(received_body_bytes) < content_length: try: length = sock.recv_into(self._buffer, len(self._buffer)) + if length == 0: + break received_body_bytes += self._buffer[:length] except TimeoutError: break @@ -511,18 +515,26 @@ def poll( if isinstance(error, OSError): # There is no data available right now, try again later. if error.errno == EAGAIN: + if conn is not None: + conn.close() return NO_REQUEST # Connection reset by peer, try again later. if error.errno == ECONNRESET: + if conn is not None: + conn.close() return NO_REQUEST # Handshake failed, try again later. if error.errno == MBEDTLS_ERR_SSL_FATAL_ALERT_MESSAGE: + if conn is not None: + conn.close() return NO_REQUEST # CPython specific SSL related errors if implementation.name != "circuitpython" and isinstance(error, SSLError): # Ignore unknown SSL certificate errors if getattr(error, "reason", None) == "SSLV3_ALERT_CERTIFICATE_UNKNOWN": + if conn is not None: + conn.close() return NO_REQUEST if self.debug: From f564743c9347eeff774ee6824849ba0251532630 Mon Sep 17 00:00:00 2001 From: Dan Halbert Date: Tue, 10 Nov 2026 08:43:04 -0500 Subject: [PATCH 2/2] Combine poll() early-return error checks into one condition Move the retryable errnos into a module-level tuple so the check doesn't allocate a new tuple on every error. Co-Authored-By: Claude Opus 5.5 --- adafruit_httpserver/server.py | 42 +++++++++++++++-------------------- 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/adafruit_httpserver/server.py b/adafruit_httpserver/server.py index f79d80c..4871589 100644 --- a/adafruit_httpserver/server.py +++ b/adafruit_httpserver/server.py @@ -53,6 +53,15 @@ # CircuitPython does not have these error codes MBEDTLS_ERR_SSL_FATAL_ALERT_MESSAGE = -30592 +# Errors after which poll() closes the connection and returns NO_REQUEST. +# +# Built once here so poll() does not allocate a new tuple on every error. +_RETRYABLE_ERRNOS = ( + EAGAIN, # No data available right now, try again later. + ECONNRESET, # Connection reset by peer, try again later. + MBEDTLS_ERR_SSL_FATAL_ALERT_MESSAGE, # Handshake failed, try again later. +) + class Server: """A basic socket-based HTTP server.""" @@ -512,30 +521,15 @@ def poll( return REQUEST_HANDLED_RESPONSE_SENT except Exception as error: - if isinstance(error, OSError): - # There is no data available right now, try again later. - if error.errno == EAGAIN: - if conn is not None: - conn.close() - return NO_REQUEST - # Connection reset by peer, try again later. - if error.errno == ECONNRESET: - if conn is not None: - conn.close() - return NO_REQUEST - # Handshake failed, try again later. - if error.errno == MBEDTLS_ERR_SSL_FATAL_ALERT_MESSAGE: - if conn is not None: - conn.close() - return NO_REQUEST - - # CPython specific SSL related errors - if implementation.name != "circuitpython" and isinstance(error, SSLError): - # Ignore unknown SSL certificate errors - if getattr(error, "reason", None) == "SSLV3_ALERT_CERTIFICATE_UNKNOWN": - if conn is not None: - conn.close() - return NO_REQUEST + if (isinstance(error, OSError) and error.errno in _RETRYABLE_ERRNOS) or ( + # CPython-specific: ignore unknown SSL certificate errors. + implementation.name != "circuitpython" + and isinstance(error, SSLError) + and getattr(error, "reason", None) == "SSLV3_ALERT_CERTIFICATE_UNKNOWN" + ): + if conn is not None: + conn.close() + return NO_REQUEST if self.debug: _debug_exception_in_handler(error)