Person should be either local user or remote actor

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

Author: keshav-space

fedcode/migrations/0003_remove_package_local_remove_person_local_and_more.py

@@ -0,0 +1,44 @@
+# Generated by Django 5.0.1 on 2024-12-10 10:01
+
+import django.db.models.deletion
+from django.conf import settings
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("fedcode", "0002_alter_package_options_alter_federaterequest_done_and_more"),
+        migrations.swappable_dependency(settings.AUTH_USER_MODEL),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="package",
+            name="local",
+        ),
+        migrations.RemoveField(
+            model_name="person",
+            name="local",
+        ),
+        migrations.AlterField(
+            model_name="person",
+            name="user",
+            field=models.OneToOneField(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.CASCADE,
+                to=settings.AUTH_USER_MODEL,
+            ),
+        ),
+        migrations.AddConstraint(
+            model_name="person",
+            constraint=models.CheckConstraint(
+                check=models.Q(
+                    models.Q(("remote_actor__isnull", True), ("user__isnull", False)),
+                    models.Q(("remote_actor__isnull", False), ("user__isnull", True)),
+                    _connector="OR",
+                ),
+                name="either_local_or_remote",
+            ),
+        ),
+    ]

fedcode/models.py

@@ -64,10 +64,6 @@ class Actor(models.Model):
         blank=False,
     )
 
-    local = models.BooleanField(
-        default=True,
-    )
-
     class Meta:
         abstract = True
 
@@ -237,6 +233,7 @@ def to_ap(self):
             "type": "Note",
             "author": self.acct,
             "content": self.content,
+            "update_date": self.updated_at,
         }
 
 
@@ -365,6 +362,7 @@ class Person(Actor):
     user = models.OneToOneField(
         User,
         null=True,
+        blank=True,
         on_delete=models.CASCADE,
     )
 
@@ -381,6 +379,21 @@ class Person(Actor):
         help_text="Notes created by this user",
     )
 
+    class Meta:
+        constraints = [
+            models.CheckConstraint(
+                check=(
+                    models.Q(user__isnull=False, remote_actor__isnull=True)
+                    | models.Q(user__isnull=True, remote_actor__isnull=False)
+                ),
+                name="either_local_or_remote",
+            ),
+        ]
+
+    @property
+    def local(self):
+        return bool(self.user)
+
     @property
     def avatar_absolute_url(self):
         return f'{"https://"}{FEDERATEDCODE_DOMAIN}{self.avatar.url}'
@@ -410,6 +423,8 @@ def absolute_url_ap(self):
 
     @property
     def inbox_url(self):
+        if not self.local:
+            return self.remote_actor.url
         return full_reverse("user-inbox", self.user.username)
 
     @property
@@ -477,7 +492,10 @@ class Meta:
         ordering = ["-updated_at"]
 
     def __str__(self):
-        return f"{self.person.user.username} - {self.package.purl}"
+        username = self.person.remote_actor.username
+        if self.person.local:
+            username = self.person.user.username
+        return f"{username} - {self.package.purl}"
 
 
 class Repository(models.Model):