Use consistent template for 403/404 error page

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

Author: keshav-space

fedcode/templates/403.html

@@ -5,7 +5,7 @@
 {% endblock %}
 
 {% block content %}
-<section class="hero is-large is-link">
+<section class="hero is-medium is-dark">
     <div class="hero-body">
         <div class="container has-text-centered">
             <h1 class="title is-1 pb-2">
@@ -14,7 +14,7 @@ <h1 class="title is-1 pb-2">
             <p class="subtitle is-4">
                 You do not have permission to access this page.
             </p>
-            <a href="{% url 'purl-list' %}" class="button is-dark">Explore available packages</a>
+            <a href="{% url 'purl-list' %}" class="button is-info">Explore available packages</a>
         </div>
     </div>
 </section>

fedcode/templates/404.html

@@ -5,7 +5,7 @@
 {% endblock %}
 
 {% block content %}
-<section class="hero is-large is-link">
+<section class="hero is-medium is-dark">
     <div class="hero-body">
         <div class="container has-text-centered">
             <h1 class="title is-1 pb-2">
@@ -14,7 +14,7 @@ <h1 class="title is-1 pb-2">
             <p class="subtitle is-4">
                 Sorry, the page you're looking for does not exist.
             </p>
-            <a href="{% url 'purl-list' %}" class="button is-dark">Explore available packages</a>
+            <a href="{% url 'purl-list' %}" class="button is-info">Explore available packages</a>
         </div>
     </div>
 </section>

fedcode/views.py

@@ -234,7 +234,7 @@ def wrapper(request, *args, **kwargs):
         if hasattr(request.user, "service"):
             return view(request, *args, **kwargs)
         else:
-            return HttpResponseForbidden()
+            raise PermissionDenied("You are not authorized to view this page.")
 
     return wrapper
 
@@ -887,11 +887,3 @@ def revoke_token(request):
         },
     )
     return JsonResponse(json.loads(r.content), status=r.status_code, content_type=AP_CONTENT_TYPE)
-
-
-def permission_denied(request, exception=None):
-    return render(request, "403.html", {})
-
-
-def page_not_found(request, exception=None):
-    return render(request, "404.html", {})

federatedcode/settings.py

@@ -280,6 +280,3 @@
     "django.contrib.auth.backends.ModelBackend",
     "oauth2_provider.backends.OAuth2Backend",
 )
-
-HANDLER403 = "fedcode.views.permission_denied"
-HANDLER404 = "fedcode.views.page_not_found"