Use named arguments to support future versions

- In particular this help things work with Click 8.x
- The hidden argument is now standard so remove it together with special
  code.

See: aboutcode-org/scancode-toolkit#2529
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Author: pombredanne

src/commoncode/cliutils.py

@@ -352,6 +352,7 @@ def __init__(
         allow_from_autoenv=True,
         type=None,  # NOQA
         help=None,  # NOQA
+        hidden=False,
         # custom additions #
         # a string that set the CLI help group for this option
         help_group=MISC_GROUP,
@@ -365,24 +366,22 @@ def __init__(
         # a sequence of other option name strings that this option
         # conflicts with if they are set
         conflicting_options=(),
-        # a flag set to True if this option should be hidden from the CLI help
-        hidden=False,
         **kwargs
     ):
-
         super(PluggableCommandLineOption, self).__init__(
-            param_decls,
-            show_default,
-            prompt,
-            confirmation_prompt,
-            hide_input,
-            is_flag,
-            flag_value,
-            multiple,
-            count,
-            allow_from_autoenv,
-            type,
-            help,
+            param_decls=param_decls,
+            show_default=show_default,
+            prompt=prompt,
+            confirmation_prompt=confirmation_prompt,
+            hide_input=hide_input,
+            is_flag=is_flag,
+            flag_value=flag_value,
+            multiple=multiple,
+            count=count,
+            allow_from_autoenv=allow_from_autoenv,
+            type=type,
+            help=help,
+            hidden=hidden,
             **kwargs
         )
 
@@ -413,10 +412,6 @@ def validate_dependencies(self, ctx, value):
         _validate_option_dependencies(ctx, self, value, self.required_options, required=True)
         _validate_option_dependencies(ctx, self, value, self.conflicting_options, required=False)
 
-    def get_help_record(self, ctx):
-        if not self.hidden:
-            return click.Option.get_help_record(self, ctx)
-
 
 def validate_option_dependencies(ctx):
     """