Do not ignore by default sccs and rcs dirs

Fix for aboutcode-org/scancode-toolkit#1422
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

Author: pombredanne

CHANGELOG.rst

@@ -10,6 +10,7 @@ Version 21.6.11
 
 - Do not fail if a Codebase does not have a common shared root #23
 - Consider all Resource attributes when building a VirtualCodebase #23
+- Do not ignore by default sccs and rcs dirs https://github.com/nexB/scancode-toolkit/issues/1422
 
 
 Version 21.6.10

src/commoncode/ignore.py

@@ -184,7 +184,6 @@ def get_ignores(location, include_defaults=True):
 
     'CVS': 'Default ignore: CVS artifact',
     '.cvsignore': 'Default ignore: CVS config artifact',
-    '*/SCCS': 'Default ignore: CVS artifact',
 
     '*/_MTN': 'Default ignore: Monotone artifact',
     '*/_darcs': 'Default ignore: Darcs artifact',

tests/test_resource.py

@@ -13,8 +13,6 @@
 from os.path import exists
 from os.path import join
 
-import pytest
-
 from commoncode.fileutils import parent_directory
 from commoncode.testcase import FileBasedTesting
 from commoncode.resource import Codebase
@@ -42,13 +40,16 @@ def test_walk_defaults(self):
         ]
         assert [(r.name, r.is_file) for r in results] == expected
 
-    @pytest.mark.xfail(reason='FIXME: a fix for ticket #1422 is needed')
-    def test_Codebase_with_only_ignores_should_not_fail_to_create(self):
+    def test_Codebase_do_not_ignore_by_default_older_sccs_and_rcs_dirs(self):
+        # See https://github.com/nexB/scancode-toolkit/issues/1422
         from commoncode.fileutils import create_dir
         test_codebase = self.get_temp_dir()
         create_dir(join(test_codebase, 'sccs', 'a'))
         create_dir(join(test_codebase, 'rcs', 'b'))
-        Codebase(test_codebase)
+        codebase = Codebase(test_codebase)
+        results = list(codebase.walk(topdown=True, skip_root=True))
+        expected = ['rcs', 'b', 'sccs', 'a']
+        assert [r.name for r in results] == expected
 
     def test_walk_topdown(self):
         test_codebase = self.get_test_loc('resource/codebase')
@@ -1055,7 +1056,7 @@ def test_virtual_codebase_can_process_minimal_resources_with_only_path(self):
             ])
         ]
         assert [r.to_dict() for r in codebase.walk()] == expected
-        
+
     def test_VirtualCodebase_account_fingerprint_attribute(self):
         test_file = self.get_test_loc("resource/virtual_codebase/fingerprint_attribute.json")
         codebase = VirtualCodebase(test_file)
@@ -1352,7 +1353,6 @@ def test_VirtualCodebase_can_be_created_without_RecursionError(self):
         VirtualCodebase(test_file)
 
 
-
 class TestResource(FileBasedTesting):
     test_data_dir = join(dirname(__file__), 'data')