From be9442017a3d3f0f18af819b67faf930b5efae71 Mon Sep 17 00:00:00 2001
From: glaude <glaude@traffino.com>
Date: Sat, 30 May 2026 18:47:38 +0200
Subject: [PATCH] chore: fix trivial SonarQube code smells (S1124, S2293,
 S1170)

- S1124 (modifier order): reorder abstract/public and abstract/protected
  in AbstractText.java lines 41 and 43 to comply with JLS
- S2293 (diamond operator): replace explicit type arguments with <>
  in Exceptions.java lines 19 and 27
- S1170 (static final field): add static to private final field
  _hexCharacters in HexCodec.java line 6

No public API changes. Build verified: mvn -q -DskipTests compile passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../com/github/zrdj/java/primitives/codec/hex/HexCodec.java | 2 +-
 .../github/zrdj/java/primitives/exception/Exceptions.java   | 6 +++---
 .../com/github/zrdj/java/primitives/text/AbstractText.java  | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/com/github/zrdj/java/primitives/codec/hex/HexCodec.java b/src/main/java/com/github/zrdj/java/primitives/codec/hex/HexCodec.java
index c89c9de..e00d375 100644
--- a/src/main/java/com/github/zrdj/java/primitives/codec/hex/HexCodec.java
+++ b/src/main/java/com/github/zrdj/java/primitives/codec/hex/HexCodec.java
@@ -3,7 +3,7 @@
 import com.github.zrdj.java.primitives.codec.Codec;
 
 public final class HexCodec implements Codec {
-    private final String _hexCharacters = "0123456789abcdef";
+    private static final String _hexCharacters = "0123456789abcdef";
 
     private StringBuilder internalEncode(final byte[] bytes) {
         StringBuilder result = new StringBuilder(2 * bytes.length);
diff --git a/src/main/java/com/github/zrdj/java/primitives/exception/Exceptions.java b/src/main/java/com/github/zrdj/java/primitives/exception/Exceptions.java
index 738f5fd..e41f1ca 100644
--- a/src/main/java/com/github/zrdj/java/primitives/exception/Exceptions.java
+++ b/src/main/java/com/github/zrdj/java/primitives/exception/Exceptions.java
@@ -16,14 +16,14 @@ static <T> T rethrowFunction(final ExceptionFunction<T> function, final Function
     }
 
     static <T> FunctionExceptionHandler<T> rethrowingFunction(final Function<Exception, RuntimeException> mapper) {
-        return new RethrowingExceptionHandler<T>(mapper);
+        return new RethrowingExceptionHandler<>(mapper);
     }
 
     static <T> T fallbackFunction(final ExceptionFunction<T> function, final Function<Exception, T> mapper) {
-        return new SwallowingFunctionExceptionHandler<T>(mapper).execute(function);
+        return new SwallowingFunctionExceptionHandler<>(mapper).execute(function);
     }
 
     static <T> FunctionExceptionHandler<T> fallbackingFunction(final Function<Exception, T> mapper) {
-        return new SwallowingFunctionExceptionHandler<T>(mapper);
+        return new SwallowingFunctionExceptionHandler<>(mapper);
     }
 }
diff --git a/src/main/java/com/github/zrdj/java/primitives/text/AbstractText.java b/src/main/java/com/github/zrdj/java/primitives/text/AbstractText.java
index 07d5498..b78beb8 100644
--- a/src/main/java/com/github/zrdj/java/primitives/text/AbstractText.java
+++ b/src/main/java/com/github/zrdj/java/primitives/text/AbstractText.java
@@ -38,7 +38,7 @@ public Text findFirst(final String regex) {
     }
 
     @Override
-    abstract public int hashCode();
+    public abstract int hashCode();
 
-    abstract protected boolean isEqualTo(final String other);
+    protected abstract boolean isEqualTo(final String other);
 }