From 9c9554f410823a9f6466d9d562a14cc5e1fd466d Mon Sep 17 00:00:00 2001
From: glaude <glaude@traffino.com>
Date: Sat, 30 May 2026 18:43:48 +0200
Subject: [PATCH] chore: fix trivial SonarQube code smells (S1905, S1118)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Remove three unnecessary (T[]) casts in CollectionPredicates.Default
(java:S1905, lines 88/98/108) — the varargs parameters are already typed
as T[] so the cast is redundant.

Add private constructor to Throws utility class and change abstract to
final (java:S1118, line 3) — prevents implicit public constructor and
accidental subclassing while keeping the static API intact.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../java/predicates/collections/CollectionPredicates.java   | 6 +++---
 .../java/com/github/zrdj/java/predicates/helper/Throws.java | 4 +++-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/main/java/com/github/zrdj/java/predicates/collections/CollectionPredicates.java b/src/main/java/com/github/zrdj/java/predicates/collections/CollectionPredicates.java
index 2b0a571..983bde8 100644
--- a/src/main/java/com/github/zrdj/java/predicates/collections/CollectionPredicates.java
+++ b/src/main/java/com/github/zrdj/java/predicates/collections/CollectionPredicates.java
@@ -85,7 +85,7 @@ public <T> Predicate<Collection<T>> containsAllOf(Collection<T> elements) {
 
         @Override
         public <T> Predicate<Collection<T>> containsAllOf(T[] elements) {
-            return outer -> containsAllOf(Arrays.asList((T[]) elements)).test(outer);
+            return outer -> containsAllOf(Arrays.asList(elements)).test(outer);
         }
 
         @Override
@@ -95,7 +95,7 @@ public <T> Predicate<Collection<T>> containsAnyOf(Collection<T> elements) {
 
         @Override
         public <T> Predicate<Collection<T>> containsAnyOf(T[] elements) {
-            return outer -> containsAnyOf(Arrays.asList((T[]) elements)).test(outer);
+            return outer -> containsAnyOf(Arrays.asList(elements)).test(outer);
         }
 
         @Override
@@ -105,7 +105,7 @@ public <T> Predicate<Collection<T>> containsNoneOf(Collection<T> elements) {
 
         @Override
         public <T> Predicate<Collection<T>> containsNoneOf(T[] elements) {
-            return outer -> containsNoneOf(Arrays.asList((T[]) elements)).test(outer);
+            return outer -> containsNoneOf(Arrays.asList(elements)).test(outer);
         }
 
         @Override
diff --git a/src/main/java/com/github/zrdj/java/predicates/helper/Throws.java b/src/main/java/com/github/zrdj/java/predicates/helper/Throws.java
index 3f48f93..8839b19 100644
--- a/src/main/java/com/github/zrdj/java/predicates/helper/Throws.java
+++ b/src/main/java/com/github/zrdj/java/predicates/helper/Throws.java
@@ -1,6 +1,8 @@
 package com.github.zrdj.java.predicates.helper;
 
-public abstract class Throws {
+public final class Throws {
+    private Throws() {}
+
     public static boolean exception(final Action action) {
         try {
             action.execute();