Skip to content

Commit 5ec5940

Browse files
committed
FIX: 세부 항목 수정
- 오타 수정 "selectNotUseSUbRoutines" -> "selectNotUseSubRoutines" - TimePicker 구분선 색상을 주황색으로 수정
1 parent b09b684 commit 5ec5940

6 files changed

Lines changed: 13 additions & 17 deletions

File tree

app/src/main/res/values/themes.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<resources>
33

4-
<style name="Base.Theme.Bitnagil" parent="android:Theme.Material.Light.NoActionBar" />
4+
<style name="Base.Theme.Bitnagil" parent="Theme.AppCompat.Light.NoActionBar" />
55

66
<style name="Theme.Bitnagil" parent="Base.Theme.Bitnagil">
77
<item name="android:windowIsTranslucent">true</item>

presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/WriteRoutineScreen.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,28 +185,28 @@ private fun WriteRoutineScreen(
185185
placeHolder = getSubRoutinePlaceHolder(0),
186186
value = state.subRoutineNames.getOrNull(0) ?: "",
187187
onValueChange = { setSubRoutineName(0, it) },
188-
enabled = !state.selectNotUseSUbRoutines,
188+
enabled = !state.selectNotUseSubRoutines,
189189
)
190190

191191
SubRoutineField(
192192
resourceId = R.drawable.img_circle_2,
193193
placeHolder = getSubRoutinePlaceHolder(1),
194194
value = state.subRoutineNames.getOrNull(1) ?: "",
195195
onValueChange = { setSubRoutineName(1, it) },
196-
enabled = !state.selectNotUseSUbRoutines,
196+
enabled = !state.selectNotUseSubRoutines,
197197
)
198198

199199
SubRoutineField(
200200
resourceId = R.drawable.img_circle_3,
201201
placeHolder = getSubRoutinePlaceHolder(2),
202202
value = state.subRoutineNames.getOrNull(2) ?: "",
203203
onValueChange = { setSubRoutineName(2, it) },
204-
enabled = !state.selectNotUseSUbRoutines,
204+
enabled = !state.selectNotUseSubRoutines,
205205
)
206206

207207
LabeledCheckBox(
208208
label = "세부 루틴 설정 안함",
209-
checked = state.selectNotUseSUbRoutines,
209+
checked = state.selectNotUseSubRoutines,
210210
onClick = selectNotUseSubRoutines,
211211
)
212212
}

presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/WriteRoutineViewModel.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,10 @@ class WriteRoutineViewModel @AssistedInject constructor(
316316
}
317317

318318
WriteRoutineIntent.SelectNotUseSubRoutines -> {
319-
val toggledSelectNotUseSubRoutines = !state.selectNotUseSUbRoutines
319+
val toggledSelectNotUseSubRoutines = !state.selectNotUseSubRoutines
320320

321321
return state.copy(
322-
selectNotUseSUbRoutines = toggledSelectNotUseSubRoutines,
322+
selectNotUseSubRoutines = toggledSelectNotUseSubRoutines,
323323
subRoutineNames = if (toggledSelectNotUseSubRoutines) listOf("", "", "") else state.subRoutineNames,
324324
)
325325
}
@@ -473,7 +473,7 @@ class WriteRoutineViewModel @AssistedInject constructor(
473473
when (val writeRoutineType = currentState.writeRoutineType) {
474474
WriteRoutineType.Add -> {
475475
sendIntent(WriteRoutineIntent.RegisterRoutineLoading)
476-
val subRoutines = if (currentState.selectNotUseSUbRoutines) emptyList() else currentState.subRoutineNames.filter { it.isNotEmpty() }
476+
val subRoutines = if (currentState.selectNotUseSubRoutines) emptyList() else currentState.subRoutineNames.filter { it.isNotEmpty() }
477477
val noRepeatRoutine = repeatDay.isEmpty()
478478

479479
val registerRoutineResult = registerRoutineUseCase(
@@ -493,7 +493,7 @@ class WriteRoutineViewModel @AssistedInject constructor(
493493
}
494494
is WriteRoutineType.Edit -> {
495495
val currentRoutineId = routineId ?: return@launch
496-
val subRoutines = if (currentState.selectNotUseSUbRoutines) emptyList() else currentState.subRoutineNames.filter { it.isNotEmpty() }
496+
val subRoutines = if (currentState.selectNotUseSubRoutines) emptyList() else currentState.subRoutineNames.filter { it.isNotEmpty() }
497497
val routineUpdateType = if (writeRoutineType.updateRoutineFromNowDate) {
498498
RoutineUpdateType.Today
499499
} else {

presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/component/template/timepickerbottomsheet/TimePickerBottomSheet.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,6 @@ private fun TimePickerBottomSheetContent(
8383
val timePicker = view.findViewById<TimePicker>(R.id.time_picker)
8484
view.tag = timePicker
8585

86-
TimePicker(context).apply {
87-
setIs24HourView(true)
88-
}
89-
9086
view
9187
},
9288
update = {

presentation/src/main/java/com/threegap/bitnagil/presentation/writeroutine/model/mvi/WriteRoutineState.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import kotlinx.parcelize.Parcelize
1313
data class WriteRoutineState(
1414
val routineName: String,
1515
val subRoutineNames: List<String>,
16-
val selectNotUseSUbRoutines: Boolean,
16+
val selectNotUseSubRoutines: Boolean,
1717
val repeatType: RepeatType?,
1818
val repeatDays: List<SelectableDay>,
1919
val startTime: Time?,
@@ -34,7 +34,7 @@ data class WriteRoutineState(
3434
val Init = WriteRoutineState(
3535
routineName = "",
3636
subRoutineNames = listOf("", "", ""),
37-
selectNotUseSUbRoutines = false,
37+
selectNotUseSubRoutines = false,
3838
repeatType = null,
3939
repeatDays = listOf(
4040
SelectableDay(
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<resources>
3-
<style name="CustomTimePickerStyle" parent="@android:style/Theme.Material.Light">
3+
<style name="CustomTimePickerStyle" parent="Theme.AppCompat.Light.NoActionBar">
44
<item name="android:timePickerMode">spinner</item>
55
<item name="android:textColorPrimary">#171719</item>
66
<item name="android:textColorSecondary">#171719</item>
7-
<item name="colorControlNormal">#A9D0FF</item>
7+
<item name="colorControlNormal">#FE7120</item>
88
</style>
99
</resources>

0 commit comments

Comments
 (0)