Skip to content

Commit eb87ef6

Browse files
committed
Partially rework tab link layout for consistency
Most significant improvements are that every tab now has the 'Sort by' and 'Columns' submenus right at the top, with a 'Files..' menu right below it that contains the Open/Unhide options, followed by any file creation commands offered by the tab. Also moved all open/rename/hide/etc. commands into a 'File..' submenu. And finally, tabs that could take advantage of additional basic file commands (e.g. backups and snapshots for saves) have now received them. Also tweaked some link text and help messages to be more accurate/informative. Include readme edits and screenshots for these changes as well as some leftover ones for Beermotor's installers link edits. Also finally made use of the saves tab context menu screenshots.
1 parent 27905c8 commit eb87ef6

48 files changed

Lines changed: 584 additions & 306 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Mopy/Docs/Wrye Bash Advanced Readme.html

Lines changed: 299 additions & 128 deletions
Large diffs are not rendered by default.

Mopy/Docs/Wrye Bash General Readme.html

Lines changed: 125 additions & 51 deletions
Large diffs are not rendered by default.

Mopy/bash/balt.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2619,20 +2619,16 @@ def Execute(self): self.window.open_data_store()
26192619

26202620
class UIList_Hide(ItemLink):
26212621
"""Hide the file (move it to the data store's Hidden directory)."""
2622-
_text = _(u'Hide')
2623-
2624-
def _initData(self, window, selection):
2625-
super(UIList_Hide, self)._initData(window, selection)
2626-
self.hidden_dir = self.window.data_store.hidden_dir
2627-
self._help = _(u"Move %(filename)s to %(hidden_dir)s") % (
2628-
{'filename': selection[0], 'hidden_dir': self.hidden_dir})
2622+
_text = _(u'Hide...')
2623+
_help = _(u"Hide the selected file(s) by moving them to the 'Hidden' "
2624+
u'directory.')
26292625

26302626
@conversation
26312627
def Execute(self):
26322628
if not bass.inisettings['SkipHideConfirmation']:
26332629
message = _(u'Hide these files? Note that hidden files are simply '
2634-
u'moved to the %(hidden_dir)s directory.') % (
2635-
{'hidden_dir': self.hidden_dir})
2630+
u'moved to the %(hdir)s directory.') % (
2631+
{'hdir': self.window.data_store.hidden_dir})
26362632
if not self._askYes(message, _(u'Hide Files')): return
26372633
self.window.hide(self.selected)
26382634
self.window.RefreshUI(refreshSaves=True)

Mopy/bash/basher/files_links.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,8 @@ def Execute(self):
181181

182182
class File_Snapshot(ItemLink):
183183
"""Take a snapshot of the file."""
184-
_help = _(u"Creates a snapshot copy of the current mod in a subdirectory (Bash\Snapshots).")
184+
_help = _(u'Creates a snapshot copy of the selected file(s) in a '
185+
u'subdirectory (Bash\Snapshots).')
185186

186187
def _initData(self, window, selection):
187188
super(File_Snapshot, self)._initData(window, selection)
@@ -268,8 +269,8 @@ class _RevertBackup(OneItemLink):
268269

269270
def __init__(self, first=False):
270271
super(_RevertBackup, self).__init__()
271-
self._text = _(u'Revert to First Backup') if first else _(
272-
u'Revert to Backup')
272+
self._text = _(u'Revert to First Backup...') if first else _(
273+
u'Revert to Backup...')
273274
self.first = first
274275

275276
def _initData(self, window, selection):

Mopy/bash/basher/ini_links.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def Execute(self):
5757
#------------------------------------------------------------------------------
5858
class INI_ListINIs(ItemLink):
5959
"""List errors that make an INI Tweak invalid."""
60-
_text = _(u'List Active INIs...')
60+
_text = _(u'List Active INI Tweaks...')
6161
_help = _(u'Lists all fully applied tweak files.')
6262

6363
def Execute(self):

Mopy/bash/basher/installer_links.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -492,9 +492,8 @@ def Execute(self):
492492

493493
class Installer_Hide(_InstallerLink, UIList_Hide):
494494
"""Hide selected Installers."""
495-
_text = _(u'Hide...')
496-
_help = _(
497-
u"Hide selected installer(s). No installer markers should be selected")
495+
_help = UIList_Hide._help + _(u' Not available if any markers have been '
496+
u'selected.')
498497

499498
def _enable(self):
500499
return not any(map(lambda inf: isinstance(inf, bosh.InstallerMarker),

0 commit comments

Comments
 (0)