FFF FOMOD fixup: crash when installing wizard

Just showcases how much of a hack the fomod as subpackage solution
really is - we should probably do this via a new variable in the BAIN
Installers classes instead and add radio buttons into the GUI to select
between FOMOD and BAIN subpackages, disabling the other component
depending on what's selected.

Author: Infernio

Mopy/bash/basher/installer_links.py

@@ -275,15 +275,12 @@ def _enable(self):
     def Execute(self):
         with balt.BusyCursor():
             installer = self._selected_info
-            subs = []
             idetails = self.iPanel.detailsPanel
             idetails.refreshCurrent(installer)
-            for index in xrange(idetails.gSubList.GetCount()):
-                subs.append(idetails.gSubList.GetString(index))
             default, pageSize, pos = self._get_size_and_pos()
             try:
                 wizard = InstallerWizard(self.window, self._selected_info,
-                                         self.bAuto, subs, pageSize, pos)
+                                         self.bAuto, pageSize, pos)
             except CancelError:
                 return
             balt.ensureDisplayed(wizard)
@@ -294,10 +291,14 @@ def Execute(self):
             return
         #Check the sub-packages that were selected by the wizard
         installer.resetAllEspmNames()
-        for index in xrange(idetails.gSubList.GetCount()):
-            select = installer.subNames[index + 1] in ret.select_sub_packages
+        # TODO(inf) This (the offset by 1 in the xrange) is nothing but a hack.
+        #  We shouldn't even be exposing an FOMOD subpackage. Probably do this
+        #  via a new variable in BAIN installers, and add radio buttons in the
+        #  GUI to select between BAIN subpackages and FOMOD
+        for index in xrange(1, idetails.gSubList.GetCount()):
+            select = installer.subNames[index] in ret.select_sub_packages
             idetails.gSubList.Check(index, select)
-            installer.subActives[index + 1] = select
+            installer.subActives[index] = select
         idetails.refreshCurrent(installer)
         #Check the espms that were selected by the wizard
         espms = idetails.gEspmList.GetStrings()

Mopy/bash/belt.py

@@ -85,7 +85,7 @@ class InstallerWizard(wiz.Wizard):
     """Class used by Wrye Bash, creates a wx Wizard that dynamically creates
     pages based on a script."""
 
-    def __init__(self, parentWindow, installer, bAuto, subs, pageSize, pos):
+    def __init__(self, parentWindow, installer, bAuto, pageSize, pos):
         wiz.Wizard.__init__(self, parentWindow, title=_(u'Installer Wizard'),
                             pos=pos, style=wx.DEFAULT_DIALOG_STYLE |
                                            wx.RESIZE_BORDER | wx.MAXIMIZE_BOX)
@@ -101,7 +101,7 @@ def __init__(self, parentWindow, installer, bAuto, subs, pageSize, pos):
         self.finishing = False
         #parser that will spit out the pages
         self.wizard_file = installer.wizard_file()
-        self.parser = WryeParser(self, installer, subs, bAuto)
+        self.parser = WryeParser(self, installer, bAuto)
         #Intercept the changing event so we can implement 'blockChange'
         set_event_hook(self, Events.WIZARD_PAGE_CHANGING, self.OnChange)
         self.ret = WizardReturn()
@@ -672,7 +672,7 @@ def colorize(text_, color=u'black', link=True):
             outLines = outLines[:lastBlank]
         return outLines
 
-    def __init__(self, parent, installer, subs, bAuto, codebox=False):
+    def __init__(self, parent, installer, bAuto, codebox=False):
         ScriptParser.Parser.__init__(self)
         if not codebox:
             self.parent = parent