Be less cautious in Path.version

Drops a way too broad except clause there. The only reasonable
exception I could see coming from get_file_version is a ValueError from
the new string code, so I added an except there to make sure.

If this does end up breaking something, it points to a way deeper issue
that actually needs investigating, not silencing.

Fix crash on startup due to xSE version check

Turns out that there was a reason for the insanely broad except clause
in Path.version. StatusBar_Button.obseVersion did not check if the xSE
file actually exists before checking its version - which obviously
errors.

Obviously, the correct solution here is not to silence that erorr, but
to make obseVersion check if the file actually exists before calling
strippedVersion on it.

Add support for reading versions of .lnk files

This fixes a crash when any of those are added to the 'Apps' folder and
also shows their versions when the 'app version' status bar feature is
enabled - so we even came out of this with a new feature!

Also added some minor try-except clauses around the win32 api calls
there now that I understand what actually causes them.

Author: Infernio

Mopy/bash/basher/app_buttons.py

@@ -103,11 +103,13 @@ def DoPopupMenu(self,event):
     @property
     def obseVersion(self):
         if bass.inisettings['SteamInstall']:
-            se_exe = bush.game.se.steam_exe
+            se_exe = bass.dirs['app'].join(bush.game.se.steam_exe)
         else:
-            se_exe = bush.game.se.exe
-        version = bass.dirs['app'].join(se_exe).strippedVersion
-        return u'.'.join([u'%s'%x for x in version])
+            se_exe = bass.dirs['app'].join(bush.game.se.exe)
+        if se_exe.isfile():
+            return u'.'.join([u'%s' % x for x in se_exe.strippedVersion])
+        else:
+            return u''
 
 #------------------------------------------------------------------------------
 # App Links -------------------------------------------------------------------

Mopy/bash/bolt.py

@@ -797,13 +797,7 @@ def stat(self):
     def version(self):
         """File version (exe/dll) embedded in the file properties."""
         from env import get_file_version
-        try:
-            version = get_file_version(self._s)
-            if version is None:
-                version = (0,0,0,0)
-        except: # TODO: pywintypes.error?
-            version = (0,0,0,0)
-        return version
+        return get_file_version(self._s)
 
     @property
     def strippedVersion(self):

Mopy/bash/env.py

@@ -339,6 +339,11 @@ def get_file_version(filename):
     :param filename: The file from which the version should be read.
     :return A 4-int tuple, for example (1, 9, 32, 0).
     """
+    # If it's a symbolic link (i.e. a user-added app), resolve it first
+    if win32client and filename.endswith(u'.lnk'):
+        sh = win32client.Dispatch(u'WScript.Shell')
+        shortcut = sh.CreateShortCut(filename)
+        filename = shortcut.TargetPath
     if win32api is None:
         # TODO(inf) The linux method needs support for string fields
         return _linux_get_file_version_info(filename)
@@ -381,7 +386,11 @@ def _query_string_field_version(file_name, version_prefix):
     # We need to ask for language and copepage first, before we can
     # query the actual version.
     l_query = u'\\VarFileInfo\\Translation'
-    lang, codepage = win32api.GetFileVersionInfo(file_name, l_query)[0]
+    try:
+        lang, codepage = win32api.GetFileVersionInfo(file_name, l_query)[0]
+    except win32api.error:
+        # File does not have a string field section
+        return (0, 0, 0, 0)
     ver_query = u'\\StringFileInfo\\%04X%04X\\%s' % (lang, codepage,
                                                      version_prefix)
     full_ver = win32api.GetFileVersionInfo(file_name, ver_query)
@@ -403,7 +412,11 @@ def _query_fixed_field_version(file_name, version_prefix):
     ProductVersion.
     :return: A 4-tuple of integers containing the version of the file.
     """
-    info = win32api.GetFileVersionInfo(file_name, u'\\')
+    try:
+        info = win32api.GetFileVersionInfo(file_name, u'\\')
+    except win32api.error:
+        # File does not have a fixed field section
+        return (0, 0, 0, 0)
     ms = info[u'%sMS' % version_prefix]
     ls = info[u'%sLS' % version_prefix]
     return win32api.HIWORD(ms), win32api.LOWORD(ms), win32api.HIWORD(ls), \