APatchMerger.__init__ must run first

Turns out that my PBash_gui_patchers were:

<type 'list'>: [
<bash.basher.gui_patchers.ActorImporter object at 0x0A4E54D0,
bash.basher.gui_patchers.AlchemicalCatalogs object at 0x0A4E55F0,
bash.basher.gui_patchers.AliasesPatcher object at 0x0A4FE570,
bash.basher.gui_patchers.AssortedTweaker object at 0x0A4FE550,
bash.basher.gui_patchers.CellImporter object at 0x0A4FE590,
bash.basher.gui_patchers.ClothesTweaker object at 0x0A4FE5B0,
bash.basher.gui_patchers.CoblExhaustion object at 0x0A4FE530,
bash.basher.gui_patchers.ContentsChecker object at 0x0A4FE5D0,
bash.basher.gui_patchers.DeathItemPatcher object at 0x0A4FE5F0,
bash.basher.gui_patchers.GmstTweaker object at 0x0A4FE610,
bash.basher.gui_patchers.GraphicsPatcher object at 0x0A4FE630,
bash.basher.gui_patchers.ImportActorsSpells object at 0x0A4FE650,
bash.basher.gui_patchers.ImportFactions object at 0x0A4FE670,
bash.basher.gui_patchers.ImportInventory object at 0x0A4FE690,
bash.basher.gui_patchers.ImportRelations object at 0x0A4FE6B0,
bash.basher.gui_patchers.ImportScripts object at 0x0A4FE6D0,
bash.basher.gui_patchers.KFFZPatcher object at 0x0A4FE6F0,
bash.basher.gui_patchers.ListsMerger object at 0x0A4FE710,
bash.basher.gui_patchers.MFactMarker object at 0x0A4FE730,
bash.basher.gui_patchers.NamesPatcher object at 0x0A4FE750,
bash.basher.gui_patchers.NamesTweaker object at 0x0A4FE770,
bash.basher.gui_patchers.NPCAIPackagePatcher object at 0x0A4FE790,
bash.basher.gui_patchers.NpcFacePatcher object at 0x0A4FE7B0,
bash.basher.gui_patchers.PatchMerger object at 0x0A4FE7D0,
bash.basher.gui_patchers.RacePatcher object at 0x0A4FE7F0,
bash.basher.gui_patchers.RoadImporter object at 0x0A4FE810,
bash.basher.gui_patchers.SEWorldEnforcer object at 0x0A4FE830,
bash.basher.gui_patchers.SoundPatcher object at 0x0A4FE850,
bash.basher.gui_patchers.SpellsPatcher object at 0x0A4FE870,
bash.basher.gui_patchers.StatsPatcher object at 0x0A4FE890,
bash.basher.gui_patchers.TextImporter object at 0x0A4FE8B0,
bash.basher.gui_patchers.TweakActors object at 0x0A4FE8D0,
bash.basher.gui_patchers.UpdateReferences object at 0x0A4FE8F0>]

Note that PatchMerger __init__ runs after

patcher.patchers.importers._AImportInventory.__init__

which uses mergeSet and after

patcher.patchers.importers.ImportInventory.__init__

which uses allSet - both are set in PatchMerger

Author: Utumno

Mopy/bash/game/__init__.py

@@ -260,10 +260,12 @@ class esp(object):
     allTags = set()
 
     # Patcher available when building a Bashed Patch (referenced by class name)
+    # PatchMerger must come first if enabled, see
+    # patcher.base.APatchMerger.__init__
     patchers = ()
 
     # CBash patchers available when building a Bashed Patch
-    CBash_patchers = ()
+    CBash_patchers = () # CBash_PatchMerger must come first if enabled!
 
     # Magic Info
     weaponTypes = ()

Mopy/bash/game/fallout3/__init__.py

@@ -144,15 +144,15 @@ class esp(GameInfo.esp):
     # NamesTweaker, NPCAIPackagePatcher, NpcFacePatcher, PatchMerger, RacePatcher,
     # RoadImporter, SoundPatcher, StatsPatcher, UpdateReferences,
     #--Patcher available when building a Bashed Patch (referenced by class name)
-    patchers = (
+    patchers = (u'PatchMerger', # PatchMerger must come first !
         u'ActorImporter', u'AliasesPatcher', u'CellImporter',
         u'ContentsChecker', u'DeathItemPatcher', u'DestructiblePatcher',
         u'FidListsMerger', u'GmstTweaker', u'GraphicsPatcher',
         u'ImportActorsSpells', u'ImportFactions', u'ImportInventory',
         u'ImportScripts', u'KFFZPatcher', u'ListsMerger', u'NamesPatcher',
         u'NPCAIPackagePatcher', u'NpcFacePatcher', u'ObjectBoundsImporter',
-        u'PatchMerger', u'SoundPatcher', u'SpellsPatcher', u'StatsPatcher',
-        u'TextImporter', u'TweakActors',
+        u'SoundPatcher', u'SpellsPatcher', u'StatsPatcher', u'TextImporter',
+        u'TweakActors',
     )
 
     weaponTypes = (

Mopy/bash/game/fallout4/__init__.py

@@ -128,7 +128,7 @@ class esp(GameInfo.esp):
         u'Deactivate', u'Delev', u'Filter', u'ObjectBounds', u'Relev',
     }
 
-    patchers = (
+    patchers = ( # PatchMerger must come first if enabled!
         u'ListsMerger', u'ObjectBoundsImporter',
     )
 

Mopy/bash/game/oblivion/__init__.py

@@ -146,32 +146,33 @@ class esp(GameInfo.esp):
         u'Voice-F', u'Voice-M',
     }
 
-    patchers = (
-        'ActorImporter', 'AlchemicalCatalogs', 'AliasesPatcher',
-        'AssortedTweaker', 'CellImporter', 'ClothesTweaker', 'CoblExhaustion',
-        'ContentsChecker', 'DeathItemPatcher', 'GmstTweaker',
-        'GraphicsPatcher', 'ImportActorsSpells', 'ImportFactions',
-        'ImportInventory', 'ImportRelations', 'ImportScripts', 'KFFZPatcher',
-        'ListsMerger', 'MFactMarker', 'NamesPatcher', 'NamesTweaker',
-        'NPCAIPackagePatcher', 'NpcFacePatcher', 'PatchMerger', 'RacePatcher',
-        'RoadImporter', 'SEWorldEnforcer', 'SoundPatcher', 'SpellsPatcher',
-        'StatsPatcher', 'TextImporter', 'TweakActors', 'UpdateReferences',
+    patchers = (u'PatchMerger', # PatchMerger must come first !
+        u'ActorImporter', u'AlchemicalCatalogs', u'AliasesPatcher',
+        u'AssortedTweaker', u'CellImporter', u'ClothesTweaker', u'CoblExhaustion',
+        u'ContentsChecker', u'DeathItemPatcher', u'GmstTweaker',
+        u'GraphicsPatcher', u'ImportActorsSpells', u'ImportFactions',
+        u'ImportInventory', u'ImportRelations', u'ImportScripts', u'KFFZPatcher',
+        u'ListsMerger', u'MFactMarker', u'NamesPatcher', u'NamesTweaker',
+        u'NPCAIPackagePatcher', u'NpcFacePatcher', u'RacePatcher',
+        u'RoadImporter', u'SEWorldEnforcer', u'SoundPatcher', u'SpellsPatcher',
+        u'StatsPatcher', u'TextImporter', u'TweakActors', u'UpdateReferences',
     )
 
-    CBash_patchers = (
-        'CBash_ActorImporter', 'CBash_AlchemicalCatalogs',
-        'CBash_AliasesPatcher', 'CBash_AssortedTweaker', 'CBash_CellImporter',
-        'CBash_ClothesTweaker', 'CBash_CoblExhaustion',
-        'CBash_ContentsChecker', 'CBash_DeathItemPatcher', 'CBash_GmstTweaker',
-        'CBash_GraphicsPatcher', 'CBash_ImportActorsSpells',
-        'CBash_ImportFactions', 'CBash_ImportInventory',
-        'CBash_ImportRelations', 'CBash_ImportScripts', 'CBash_KFFZPatcher',
-        'CBash_ListsMerger', 'CBash_MFactMarker', 'CBash_NamesPatcher',
-        'CBash_NamesTweaker', 'CBash_NPCAIPackagePatcher',
-        'CBash_NpcFacePatcher', 'CBash_PatchMerger', 'CBash_RacePatcher',
-        'CBash_RoadImporter', 'CBash_SEWorldEnforcer', 'CBash_SoundPatcher',
-        'CBash_SpellsPatcher', 'CBash_StatsPatcher', 'CBash_TweakActors',
-        'CBash_UpdateReferences',
+    CBash_patchers = (u'CBash_PatchMerger', # PatchMerger must come first !
+        u'CBash_ActorImporter', u'CBash_AlchemicalCatalogs',
+        u'CBash_AliasesPatcher', u'CBash_AssortedTweaker',
+        u'CBash_CellImporter', u'CBash_ClothesTweaker',
+        u'CBash_CoblExhaustion', u'CBash_ContentsChecker',
+        u'CBash_DeathItemPatcher', u'CBash_GmstTweaker',
+        u'CBash_GraphicsPatcher', u'CBash_ImportActorsSpells',
+        u'CBash_ImportFactions', u'CBash_ImportInventory',
+        u'CBash_ImportRelations', u'CBash_ImportScripts', u'CBash_KFFZPatcher',
+        u'CBash_ListsMerger', u'CBash_MFactMarker', u'CBash_NamesPatcher',
+        u'CBash_NamesTweaker', u'CBash_NPCAIPackagePatcher',
+        u'CBash_NpcFacePatcher', u'CBash_RacePatcher', u'CBash_RoadImporter',
+        u'CBash_SEWorldEnforcer', u'CBash_SoundPatcher',
+        u'CBash_SpellsPatcher', u'CBash_StatsPatcher', u'CBash_TweakActors',
+        u'CBash_UpdateReferences',
     )
 
     weaponTypes = (

Mopy/bash/game/skyrim/__init__.py

@@ -154,14 +154,13 @@ class esp(GameInfo.esp):
         u'Sound', u'SpellStats', u'Stats', u'Text',
     }
 
-    patchers = (
+    patchers = (u'PatchMerger', # PatchMerger must come first !
         u'ActorImporter', u'CellImporter', u'ContentsChecker',
         u'DeathItemPatcher', u'DestructiblePatcher', u'GmstTweaker',
         u'GraphicsPatcher', u'ImportActorsSpells', u'ImportInventory',
         u'KeywordsImporter', u'ListsMerger', u'NamesPatcher',
-        u'NPCAIPackagePatcher', u'ObjectBoundsImporter', u'PatchMerger',
-        u'SoundPatcher', u'SpellsPatcher', u'StatsPatcher', u'TextImporter',
-        u'TweakActors',
+        u'NPCAIPackagePatcher', u'ObjectBoundsImporter', u'SoundPatcher',
+        u'SpellsPatcher', u'StatsPatcher', u'TextImporter', u'TweakActors',
     )
 
     weaponTypes = (

Mopy/bash/game/skyrimse/__init__.py

@@ -59,7 +59,7 @@ class SkyrimSEGameInfo(SkyrimGameInfo):
 
     allTags = SkyrimGameInfo.allTags - {u'MustBeActiveIfImported', u'NoMerge',}
 
-    patchers = (
+    patchers = ( # PatchMerger must come first if enabled!
         u'ActorImporter', u'CellImporter', u'ContentsChecker',
         u'DeathItemPatcher', u'DestructiblePatcher', u'GmstTweaker',
         u'GraphicsPatcher', u'ImportActorsSpells', u'ImportInventory',

Mopy/bash/game/skyrimvr/__init__.py

@@ -57,14 +57,13 @@ class SkyrimVRGameInfo(SkyrimSEGameInfo):
     check_esl = False
 
     allTags = SkyrimSEGameInfo.allTags | {u'NoMerge'}
-    patchers = (
+    patchers = (u'PatchMerger', # PatchMerger must come first !
         u'ActorImporter', u'CellImporter', u'ContentsChecker',
         u'DeathItemPatcher', u'DestructiblePatcher', u'GmstTweaker',
         u'GraphicsPatcher', u'ImportActorsSpells', u'ImportInventory',
         u'KeywordsImporter', u'ListsMerger', u'NamesPatcher',
-        u'NPCAIPackagePatcher', u'ObjectBoundsImporter', u'PatchMerger',
-        u'SoundPatcher', u'SpellsPatcher', u'StatsPatcher', u'TextImporter',
-        u'TweakActors',
+        u'NPCAIPackagePatcher', u'ObjectBoundsImporter', u'SoundPatcher',
+        u'SpellsPatcher', u'StatsPatcher', u'TextImporter', u'TweakActors',
     )
 
     class se(SkyrimSEGameInfo.se):