Skip to content

Commit 25fa9be

Browse files
committed
Fix is_esl_capable had not attribute verbose
``` Traceback (most recent call last): File "bash\balt.pyo", line 414, in <lambda> File "bash\basher\app_buttons.pyo", line 731, in Execute File "bash\basher\frames.pyo", line 410, in __init__ File "bash\basher\frames.pyo", line 452, in CheckMods File "bash\bosh\mods_metadata.pyo", line 396, in checkMods TypeError: is_esl_capable() got an unexpected keyword argument 'verbose' ```
1 parent 732dff5 commit 25fa9be

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

Mopy/bash/bosh/_mergeability.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,11 @@ def isPBashMergeable(modInfo, minfos, reasons):
120120

121121
def is_esl_capable(modInfo, minfos, reasons):
122122
"""Returns True or error message indicating whether specified mod is
123-
convertible to a light plugin."""
123+
convertible to a light plugin.
124+
125+
You are doing this wrong, here and in Mod_MarkMergeable.
126+
127+
This entire thing needs to be overhauled."""
124128
verbose = reasons is not None
125129
if modInfo.isBP():
126130
if not verbose: return False

Mopy/bash/bosh/mods_metadata.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ def checkMods(self, showModList=False, showRuleSets=False, showNotes=False,
394394
for m, modinf in modInfos.items():
395395
if not modinf.is_esl():
396396
continue # we check .esl extension and ESL flagged mods
397-
if not is_esl_capable(modinf, modInfos, verbose=False):
397+
if not is_esl_capable(modinf, modInfos, reasons=None):
398398
removeEslFlag.add(m)
399399
shouldDeactivateA, shouldDeactivateB = [], []
400400
for x in active:
@@ -452,7 +452,7 @@ def checkMods(self, showModList=False, showRuleSets=False, showNotes=False,
452452
log(u'* __'+mod.s+u'__')
453453
if removeEslFlag:
454454
log.setHeader(u'=== ' + _(u'Remove ESL Flag'))
455-
log(_(u'Following mods have an ESL flag, but do not qualify.'))
455+
log(_(u'Following mods have an ESL flag, but may not qualify. Check with xEdit.'))
456456
for mod in sorted(removeEslFlag):
457457
log(u'* __' + mod.s + u'__')
458458
if shouldDeactivateB:

0 commit comments

Comments
 (0)