Cache images it does speedup loading them

(although that's probably due to my using balt.Image)

Author: Utumno

Mopy/bash/basher/gui_fomod.py

@@ -262,6 +262,7 @@ def __init__(self, parent, page):
 
         sizer_extra = wx.GridSizer(2, 1, 5, 5)
         self.bmp_item = balt.Picture(self, 0, 0, background=None)
+        self._img_cache = {} # creating images can be really expensive
         self.text_item = balt.RoTextCtrl(self, autotooltip=False)
         sizer_extra.Add(self.bmp_item, 1, wx.EXPAND | wx.ALL)
         sizer_extra.Add(self.text_item, 1, wx.EXPAND | wx.ALL)
@@ -370,11 +371,12 @@ def on_hover(self, event):
 
         self.bmp_item.Freeze()
         img = self.parent.archive_path.join(option.image)
-        if img.isfile():
-            image = wx.Bitmap(img.s)
-            self.bmp_item.SetBitmap(image)
-        else:
-            self.bmp_item.SetBitmap(None)
+        try:
+            image = self._img_cache[img]
+        except KeyError:
+            image = self._img_cache.setdefault(img, (
+                    img.isfile() and balt.Image(img.s).GetBitmap()) or None)
+        self.bmp_item.SetBitmap(image)
         self.bmp_item.Thaw()
         self.text_item.SetValue(
             self._option_type_string[option.type] + option.description)

Mopy/bash/fomod.py

@@ -21,7 +21,7 @@
 #  https://github.com/wrye-bash
 #
 # =============================================================================
-
+"""TODO: notes on the data model here"""
 
 __author__ = "Ganda"
 
@@ -327,14 +327,13 @@ def _test_conditions(self, conditions):
             raise FailedCondition("\n".join(failed))
 
     @staticmethod
-    def _order_list(unordered_list, order):
+    def _order_list(unordered_list, order, _valid_values=frozenset(
+        ("Explicit", "Ascending", "Descending"))):
         if order == "Explicit":
             return unordered_list
-        elif order == "Ascending":
-            return sorted(unordered_list, key=lambda x: x.name)
-        elif order == "Descending":
-            return sorted(unordered_list, key=lambda x: x.name, reverse=True)
-        else:
+        if order not in _valid_values:
             raise ValueError(
                 "Arguments are incorrect: {}, {}".format(unordered_list, order)
             )
+        return sorted(unordered_list, key=lambda x: x.name,
+                      reverse=order == "Descending")