Skip to content

Commit 348e276

Browse files
Merge pull request #479 from WrightonLabCSU/bugfix/info-sheet-A_rank-fix
Bugfix/info sheet a rank fix
2 parents 64da24e + d2a5028 commit 348e276

3 files changed

Lines changed: 14 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,16 @@
22

33
All notable changes to this project will be documented in this file.
44

5+
## 2.0.0-beta22 - 2025-12-17
6+
7+
[64da24e](https://github.com/WrightonLabCSU/DRAM/commit/64da24e51367feaffe2f643dfbb0aa602e28c5c5)...[0933424](https://github.com/WrightonLabCSU/DRAM/commit/093342450e6e49c1a706cdf2c181bd931bab7a6d)
8+
9+
### Bug Fixes
10+
11+
- A_rank from info sheet for hmm parse now parse properly ([0933424](https://github.com/WrightonLabCSU/DRAM/commit/093342450e6e49c1a706cdf2c181bd931bab7a6d))
12+
13+
14+
515
## 2.0.0-beta21 - 2025-12-15
616

717
[3648a77](https://github.com/WrightonLabCSU/DRAM/commit/3648a77ee93cb0e5c72dee5cf3d1b6b4a38a834e)...[1106003](https://github.com/WrightonLabCSU/DRAM/commit/1106003daaab6bea519132c5232cf62c54be2a9b)

bin/hmm_parser.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def main(hmm_domtbl, hmm_info_path, ec_from_info, gene_locs, db_name, output):
123123
print(f"Error reading HMM info file: {e}\n{e2}")
124124
hmm_sheet = False
125125
if hmm_sheet and not hmm_info.empty:
126-
merge_cols = ['score_type', 'threshold', f"{db_name}_EC", "description"]
126+
merge_cols = ['score_type', 'threshold', f"{db_name}_EC", "description", "A_rank", "B_rank"]
127127
raise_on_ec = False
128128
if "description" in hmm_info.columns:
129129
pass
@@ -143,7 +143,8 @@ def main(hmm_domtbl, hmm_info_path, ec_from_info, gene_locs, db_name, output):
143143

144144
hits = hits.merge(hmm_info[merge_cols], how='left', left_on="query_name", right_index=True)
145145
hits_sig = sig_scores_row_by_row(hits, db_name=db_name)
146-
hits_sig = hits_sig.drop(columns=['score_type', 'threshold'])
146+
drop_cols = [col for col in merge_cols if col in hits_sig.columns and col not in [f"{db_name}_EC", "description",]]
147+
hits_sig = hits_sig.drop(columns=drop_cols)
147148
else:
148149
hits_sig = hits[hits["perc_cov"] >= 0.35]
149150

nextflow.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@ manifest {
478478
mainScript = 'main.nf'
479479
defaultBranch = 'master'
480480
nextflowVersion = '!>=24'
481-
version = '2.0.0-beta21'
481+
version = '2.0.0-beta22'
482482
doi = ''
483483
}
484484

0 commit comments

Comments
 (0)