Commit fa52877
committed
Add support for generating a consumer for CSS properties that require custom types for unordered groups
https://bugs.webkit.org/show_bug.cgi?id=289983
Reviewed by Antti Koivisto.
- Adds support for custom types on "match one more any order" (||) groups.
- Adds support for custom types on "match all any order" (&&) groups.
- Adds support for the single item optimization for bounded repetition patterns.
- Adds support for the settings flag annotation on "match one" groups.
Removes CSSLineBoxContainValue CSSValue subclass. Uses CSSValueList instead,
with the option set getting built at style building time.
These allow the generation of:
offset-rotate
-webkit-line-box-contain
text-underline-position
scrollbar-gutter
position-visibility
@page size
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Remove no longer needed files. Add StyleLineBoxContain.h
* Source/WebCore/css/CSSProperties.json:
- Update grammar with annotations.
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/CSSLineBoxContainValue.cpp: Removed.
* Source/WebCore/css/CSSLineBoxContainValue.h: Removed.
* Source/WebCore/css/ComputedStyleExtractor.cpp:
* Source/WebCore/style/values/inline/StyleLineBoxContain.h: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp:
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
* Source/WebCore/rendering/RenderBlock.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/RenderStyleSetters.h:
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
* Source/WebCore/style/StyleBuilderConverter.h:
- By replacing CSSLineBoxContainValue with a CSSValueList, the style representation
had to move as well and now lives in style/values. Update users accordingly.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Overflow.cpp: Removed.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Overflow.h: Removed.
- Remove empty file.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Page.cpp: Removed.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Page.h: Removed.
- Remove no longer used consumeSize. File now empty so removed.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.h:
- Remove no longer used consumePositionVisibility.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Inline.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Inline.h:
- Remove no longer used consumeWebkitLineBoxContain.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.h:
- Remove no longer used consumeOffsetRotate.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Page.cpp: Removed.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Page.h: Removed.
- Remove no longer used consumeSize.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+TextDecoration.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+TextDecoration.h:
- Remove no longer used consumeTextUnderlinePosition.
* Source/WebCore/css/scripts/process-css-properties.py:
- Add new support to parser generators.
* Source/WebCore/css/scripts/test/TestCSSProperties.json:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.gperf:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyNames.h:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyParsing.cpp:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSStyleDeclaration+PropertyNames.idl:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleBuilderGenerated.cpp:
* Source/WebCore/css/scripts/test/TestCSSPropertiesResults/StyleInterpolationWrapperMap.cpp:
- Add new test cases and update results.
Canonical link: https://commits.webkit.org/292558@main1 parent b2323ec commit fa52877
49 files changed
Lines changed: 1894 additions & 789 deletions
File tree
- Source/WebCore
- SaferCPPExpectations
- WebCore.xcodeproj
- css
- parser
- scripts
- test
- TestCSSPropertiesResults
- layout/formattingContexts/inline
- rendering
- style
- updating
- style
- values/inline
- Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
| 203 | + | |
203 | 204 | | |
204 | 205 | | |
205 | 206 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
907 | 907 | | |
908 | 908 | | |
909 | 909 | | |
910 | | - | |
911 | 910 | | |
912 | 911 | | |
913 | 912 | | |
| |||
2714 | 2713 | | |
2715 | 2714 | | |
2716 | 2715 | | |
| 2716 | + | |
| 2717 | + | |
2717 | 2718 | | |
2718 | 2719 | | |
2719 | 2720 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
913 | 913 | | |
914 | 914 | | |
915 | 915 | | |
916 | | - | |
917 | 916 | | |
918 | 917 | | |
919 | 918 | | |
| |||
1055 | 1054 | | |
1056 | 1055 | | |
1057 | 1056 | | |
1058 | | - | |
1059 | | - | |
1060 | 1057 | | |
1061 | 1058 | | |
1062 | 1059 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4847 | 4847 | | |
4848 | 4848 | | |
4849 | 4849 | | |
| 4850 | + | |
4850 | 4851 | | |
4851 | 4852 | | |
4852 | 4853 | | |
| |||
4968 | 4969 | | |
4969 | 4970 | | |
4970 | 4971 | | |
4971 | | - | |
4972 | 4972 | | |
4973 | 4973 | | |
4974 | 4974 | | |
| |||
17899 | 17899 | | |
17900 | 17900 | | |
17901 | 17901 | | |
| 17902 | + | |
17902 | 17903 | | |
17903 | 17904 | | |
17904 | 17905 | | |
| |||
18245 | 18246 | | |
18246 | 18247 | | |
18247 | 18248 | | |
18248 | | - | |
18249 | | - | |
18250 | 18249 | | |
18251 | 18250 | | |
18252 | 18251 | | |
| |||
18651 | 18650 | | |
18652 | 18651 | | |
18653 | 18652 | | |
18654 | | - | |
18655 | | - | |
18656 | 18653 | | |
18657 | 18654 | | |
18658 | 18655 | | |
| |||
18667 | 18664 | | |
18668 | 18665 | | |
18669 | 18666 | | |
18670 | | - | |
18671 | | - | |
18672 | 18667 | | |
18673 | 18668 | | |
18674 | 18669 | | |
| |||
31021 | 31016 | | |
31022 | 31017 | | |
31023 | 31018 | | |
31024 | | - | |
31025 | | - | |
31026 | | - | |
31027 | | - | |
31028 | 31019 | | |
31029 | 31020 | | |
31030 | 31021 | | |
| |||
34627 | 34618 | | |
34628 | 34619 | | |
34629 | 34620 | | |
| 34621 | + | |
| 34622 | + | |
| 34623 | + | |
| 34624 | + | |
| 34625 | + | |
| 34626 | + | |
| 34627 | + | |
| 34628 | + | |
34630 | 34629 | | |
34631 | 34630 | | |
34632 | 34631 | | |
| |||
35098 | 35097 | | |
35099 | 35098 | | |
35100 | 35099 | | |
| 35100 | + | |
35101 | 35101 | | |
35102 | 35102 | | |
35103 | 35103 | | |
| |||
37862 | 37862 | | |
37863 | 37863 | | |
37864 | 37864 | | |
37865 | | - | |
37866 | | - | |
37867 | 37865 | | |
37868 | 37866 | | |
37869 | 37867 | | |
| |||
40697 | 40695 | | |
40698 | 40696 | | |
40699 | 40697 | | |
40700 | | - | |
40701 | 40698 | | |
40702 | 40699 | | |
40703 | 40700 | | |
| |||
44501 | 44498 | | |
44502 | 44499 | | |
44503 | 44500 | | |
| 44501 | + | |
44504 | 44502 | | |
44505 | 44503 | | |
44506 | 44504 | | |
| |||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
0 commit comments