Drop WTF_ALLOW_UNSAFE_BUFFER_USAGE for WTF::makeLatin1CharacterBitSet()

https://bugs.webkit.org/show_bug.cgi?id=294631

Reviewed by Darin Adler.

This tested as performance neutral on Speedometer and JetStream.

* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/WTF/wtf/text/ASCIIFastPath.h:
(WTF::makeLatin1CharacterBitSet):

Canonical link: https://commits.webkit.org/296379@main

Author: cdumez

Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

@@ -570,7 +570,7 @@ JSC_DEFINE_HOST_FUNCTION(globalFuncParseFloat, (JSGlobalObject* globalObject, Ca
 JSC_DEFINE_HOST_FUNCTION(globalFuncDecodeURI, (JSGlobalObject* globalObject, CallFrame* callFrame))
 {
     static constexpr auto doNotUnescapeWhenDecodingURI = makeLatin1CharacterBitSet(
-        "#$&+,/:;=?@"
+        "#$&+,/:;=?@"_s
     );
 
     return JSValue::encode(decode(globalObject, callFrame->argument(0), doNotUnescapeWhenDecodingURI, true));
@@ -588,7 +588,7 @@ JSC_DEFINE_HOST_FUNCTION(globalFuncEncodeURI, (JSGlobalObject* globalObject, Cal
         "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
         "abcdefghijklmnopqrstuvwxyz"
         "0123456789"
-        "!#$&'()*+,-./:;=?@_~"
+        "!#$&'()*+,-./:;=?@_~"_s
     );
     return JSValue::encode(encode(globalObject, callFrame->argument(0), doNotEscapeWhenEncodingURI));
 }
@@ -599,7 +599,7 @@ JSC_DEFINE_HOST_FUNCTION(globalFuncEncodeURIComponent, (JSGlobalObject* globalOb
         "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
         "abcdefghijklmnopqrstuvwxyz"
         "0123456789"
-        "!'()*-._~"
+        "!'()*-._~"_s
     );
     return JSValue::encode(encode(globalObject, callFrame->argument(0), doNotEscapeWhenEncodingURIComponent));
 }
@@ -611,7 +611,7 @@ JSC_DEFINE_HOST_FUNCTION(globalFuncEscape, (JSGlobalObject* globalObject, CallFr
             "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
             "abcdefghijklmnopqrstuvwxyz"
             "0123456789"
-            "*+-./@_"
+            "*+-./@_"_s
         );
 
         VM& vm = globalObject->vm();

Source/WTF/wtf/text/ASCIIFastPath.h

@@ -25,6 +25,7 @@
 #include <unicode/utypes.h>
 #include <wtf/BitSet.h>
 #include <wtf/StdLibExtras.h>
+#include <wtf/text/ASCIILiteral.h>
 #include <wtf/text/LChar.h>
 
 #if CPU(X86_SSE2)
@@ -33,17 +34,13 @@
 
 namespace WTF {
 
-WTF_ALLOW_UNSAFE_BUFFER_USAGE_BEGIN
-template<unsigned charactersCount>
-inline constexpr BitSet<256> makeLatin1CharacterBitSet(const char (&characters)[charactersCount])
+inline constexpr BitSet<256> makeLatin1CharacterBitSet(ASCIILiteral characters)
 {
-    static_assert(charactersCount > 0, "Since string literal is null terminated, characterCount is always larger than 0");
     BitSet<256> bitmap;
-    for (unsigned i = 0; i < charactersCount - 1; ++i)
-        bitmap.set(characters[i]);
+    for (char character : characters.span())
+        bitmap.set(character);
     return bitmap;
 }
-WTF_ALLOW_UNSAFE_BUFFER_USAGE_END
 
 inline constexpr BitSet<256> makeLatin1CharacterBitSet(NOESCAPE const Invocable<bool(LChar)> auto& matches)
 {