Commit b9ce71c
committed
[Safer CPP] Address ForwardDeclChecker warnings under UnifiedPDF files
https://bugs.webkit.org/show_bug.cgi?id=290288
rdar://147691279
Reviewed by Chris Dumez.
Note that this is a best effort attempt, and we will still have warnings
in UnifiedPDFPlugin.mm and in PDFDataDetectorOverlayController.mm. The
warnings that persist are false positives surfaced in open source
configurations, though, since types such as CGPDFPageLayoutRef and
DDHighlightRef are defined in private framework headers.
* Source/WebKit/SaferCPPExpectations/ForwardDeclCheckerExpectations:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
Canonical link: https://commits.webkit.org/292571@main1 parent 7409d44 commit b9ce71c
3 files changed
Lines changed: 2 additions & 1 deletion
File tree
- Source/WebKit
- SaferCPPExpectations
- WebProcess/Plugins/PDF/UnifiedPDF
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
| |||
0 commit comments