Skip to content

Commit b9ce71c

Browse files
committed
[Safer CPP] Address ForwardDeclChecker warnings under UnifiedPDF files
https://bugs.webkit.org/show_bug.cgi?id=290288 rdar://147691279 Reviewed by Chris Dumez. Note that this is a best effort attempt, and we will still have warnings in UnifiedPDFPlugin.mm and in PDFDataDetectorOverlayController.mm. The warnings that persist are false positives surfaced in open source configurations, though, since types such as CGPDFPageLayoutRef and DDHighlightRef are defined in private framework headers. * Source/WebKit/SaferCPPExpectations/ForwardDeclCheckerExpectations: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: Canonical link: https://commits.webkit.org/292571@main
1 parent 7409d44 commit b9ce71c

3 files changed

Lines changed: 2 additions & 1 deletion

File tree

Source/WebKit/SaferCPPExpectations/ForwardDeclCheckerExpectations

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ UIProcess/WebProcessPool.h
3030
WebProcess/Extensions/Bindings/JSWebExtensionWrapper.h
3131
WebProcess/Inspector/WebInspectorClient.cpp
3232
WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm
33-
WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm
3433
WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
3534
WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp
3635
WebProcess/WebCoreSupport/WebChromeClient.cpp

Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include "PDFKitSPI.h"
3434
#include "PDFScrollingPresentationController.h"
3535
#include <WebCore/GraphicsLayer.h>
36+
#include <WebCore/GraphicsLayerFactory.h>
3637
#include <WebCore/LocalFrameView.h>
3738
#include <wtf/CheckedRef.h>
3839
#include <wtf/TZoneMallocInlines.h>

Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
#include <WebCore/GraphicsContext.h>
8181
#include <WebCore/GraphicsLayer.h>
8282
#include <WebCore/GraphicsLayerClient.h>
83+
#include <WebCore/GraphicsLayerFactory.h>
8384
#include <WebCore/GraphicsTypes.h>
8485
#include <WebCore/HTMLNames.h>
8586
#include <WebCore/HTMLPlugInElement.h>

0 commit comments

Comments
 (0)