Skip to content

Commit adb15d9

Browse files
committed
[Safer CPP] Address issues in WebGLRenderingContextBase
https://bugs.webkit.org/show_bug.cgi?id=293792 rdar://152294456 Reviewed by Chris Dumez. Address outstanding Safer CPP issues in WebGLRenderingContextBase. * Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase): (WebCore::WebGLRenderingContextBase::initializeContextState): (WebCore::WebGLRenderingContextBase::clearIfComposited): (WebCore::WebGLRenderingContextBase::surfaceBufferToImageBuffer): (WebCore::WebGLRenderingContextBase::drawingBufferToPixelBuffer): (WebCore::WebGLRenderingContextBase::surfaceBufferToVideoFrame): (WebCore::WebGLRenderingContextBase::transferToImageBuffer): (WebCore::WebGLRenderingContextBase::reshape): (WebCore::WebGLRenderingContextBase::setDrawingBufferColorSpace): (WebCore::WebGLRenderingContextBase::activeTexture): (WebCore::WebGLRenderingContextBase::attachShader): (WebCore::WebGLRenderingContextBase::bindAttribLocation): (WebCore::WebGLRenderingContextBase::validateAndCacheBufferBinding): (WebCore::WebGLRenderingContextBase::bindBuffer): (WebCore::WebGLRenderingContextBase::bindRenderbuffer): (WebCore::WebGLRenderingContextBase::bindTexture): (WebCore::WebGLRenderingContextBase::blendColor): (WebCore::WebGLRenderingContextBase::blendEquation): (WebCore::WebGLRenderingContextBase::blendEquationSeparate): (WebCore::WebGLRenderingContextBase::blendFunc): (WebCore::WebGLRenderingContextBase::blendFuncSeparate): (WebCore::WebGLRenderingContextBase::bufferData): (WebCore::WebGLRenderingContextBase::checkFramebufferStatus): (WebCore::WebGLRenderingContextBase::clear): (WebCore::WebGLRenderingContextBase::clearColor): (WebCore::WebGLRenderingContextBase::clearDepth): (WebCore::WebGLRenderingContextBase::clearStencil): (WebCore::WebGLRenderingContextBase::colorMask): (WebCore::WebGLRenderingContextBase::compileShader): (WebCore::WebGLRenderingContextBase::compressedTexImage2D): (WebCore::WebGLRenderingContextBase::compressedTexSubImage2D): (WebCore::WebGLRenderingContextBase::copyTexSubImage2D): (WebCore::WebGLRenderingContextBase::cullFace): (WebCore::WebGLRenderingContextBase::uncacheDeletedBuffer): (WebCore::WebGLRenderingContextBase::deleteFramebuffer): (WebCore::WebGLRenderingContextBase::deleteRenderbuffer): (WebCore::WebGLRenderingContextBase::deleteTexture): (WebCore::WebGLRenderingContextBase::depthFunc): (WebCore::WebGLRenderingContextBase::depthMask): (WebCore::WebGLRenderingContextBase::depthRange): (WebCore::WebGLRenderingContextBase::detachShader): (WebCore::WebGLRenderingContextBase::disable): (WebCore::WebGLRenderingContextBase::disableVertexAttribArray): (WebCore::WebGLRenderingContextBase::validateVertexArrayObject): (WebCore::WebGLRenderingContextBase::drawArrays): (WebCore::WebGLRenderingContextBase::drawElements): (WebCore::WebGLRenderingContextBase::enable): (WebCore::WebGLRenderingContextBase::enableVertexAttribArray): (WebCore::WebGLRenderingContextBase::finish): (WebCore::WebGLRenderingContextBase::flush): (WebCore::WebGLRenderingContextBase::frontFace): (WebCore::WebGLRenderingContextBase::generateMipmap): (WebCore::WebGLRenderingContextBase::getActiveAttrib): (WebCore::WebGLRenderingContextBase::getActiveUniform): (WebCore::WebGLRenderingContextBase::getAttribLocation): (WebCore::WebGLRenderingContextBase::getBufferParameter): (WebCore::WebGLRenderingContextBase::updateErrors): (WebCore::WebGLRenderingContextBase::getParameter): (WebCore::WebGLRenderingContextBase::getProgramParameter): (WebCore::WebGLRenderingContextBase::getProgramInfoLog): (WebCore::WebGLRenderingContextBase::getRenderbufferParameter): (WebCore::WebGLRenderingContextBase::getShaderParameter): (WebCore::WebGLRenderingContextBase::getShaderInfoLog): (WebCore::WebGLRenderingContextBase::getShaderPrecisionFormat): (WebCore::WebGLRenderingContextBase::getTexParameter): (WebCore::WebGLRenderingContextBase::getUniform): (WebCore::WebGLRenderingContextBase::getUniformLocation): (WebCore::WebGLRenderingContextBase::getVertexAttrib): (WebCore::WebGLRenderingContextBase::getVertexAttribOffset): (WebCore::WebGLRenderingContextBase::hint): (WebCore::WebGLRenderingContextBase::isBuffer): (WebCore::WebGLRenderingContextBase::isEnabled): (WebCore::WebGLRenderingContextBase::isFramebuffer): (WebCore::WebGLRenderingContextBase::isProgram): (WebCore::WebGLRenderingContextBase::isRenderbuffer): (WebCore::WebGLRenderingContextBase::isShader): (WebCore::WebGLRenderingContextBase::isTexture): (WebCore::WebGLRenderingContextBase::lineWidth): (WebCore::WebGLRenderingContextBase::linkProgramWithoutInvalidatingAttribLocations): (WebCore::WebGLRenderingContextBase::pixelStorei): (WebCore::WebGLRenderingContextBase::polygonOffset): (WebCore::WebGLRenderingContextBase::readPixels): (WebCore::WebGLRenderingContextBase::renderbufferStorageImpl): (WebCore::WebGLRenderingContextBase::sampleCoverage): (WebCore::WebGLRenderingContextBase::scissor): (WebCore::WebGLRenderingContextBase::shaderSource): (WebCore::WebGLRenderingContextBase::stencilFunc): (WebCore::WebGLRenderingContextBase::stencilFuncSeparate): (WebCore::WebGLRenderingContextBase::stencilMask): (WebCore::WebGLRenderingContextBase::stencilMaskSeparate): (WebCore::WebGLRenderingContextBase::stencilOp): (WebCore::WebGLRenderingContextBase::stencilOpSeparate): (WebCore::WebGLRenderingContextBase::texImageSource): (WebCore::WebGLRenderingContextBase::texImageArrayBufferViewHelper): (WebCore::WebGLRenderingContextBase::texImageImpl): (WebCore::WebGLRenderingContextBase::texImage2DBase): (WebCore::WebGLRenderingContextBase::texSubImage2DBase): (WebCore::WebGLRenderingContextBase::copyTexImage2D): (WebCore::WebGLRenderingContextBase::texParameter): (WebCore::WebGLRenderingContextBase::uniform1f): (WebCore::WebGLRenderingContextBase::uniform2f): (WebCore::WebGLRenderingContextBase::uniform3f): (WebCore::WebGLRenderingContextBase::uniform4f): (WebCore::WebGLRenderingContextBase::uniform1i): (WebCore::WebGLRenderingContextBase::uniform2i): (WebCore::WebGLRenderingContextBase::uniform3i): (WebCore::WebGLRenderingContextBase::uniform4i): (WebCore::WebGLRenderingContextBase::uniform1fv): (WebCore::WebGLRenderingContextBase::uniform2fv): (WebCore::WebGLRenderingContextBase::uniform3fv): (WebCore::WebGLRenderingContextBase::uniform4fv): (WebCore::WebGLRenderingContextBase::uniform1iv): (WebCore::WebGLRenderingContextBase::uniform2iv): (WebCore::WebGLRenderingContextBase::uniform3iv): (WebCore::WebGLRenderingContextBase::uniform4iv): (WebCore::WebGLRenderingContextBase::uniformMatrix2fv): (WebCore::WebGLRenderingContextBase::uniformMatrix3fv): (WebCore::WebGLRenderingContextBase::uniformMatrix4fv): (WebCore::WebGLRenderingContextBase::useProgram): (WebCore::WebGLRenderingContextBase::validateProgram): (WebCore::WebGLRenderingContextBase::vertexAttribPointer): (WebCore::WebGLRenderingContextBase::viewport): (WebCore::WebGLRenderingContextBase::forceLostContext): (WebCore::WebGLRenderingContextBase::layerContentsDisplayDelegate): (WebCore::WebGLRenderingContextBase::getBooleanParameter): (WebCore::WebGLRenderingContextBase::getBooleanArrayParameter): (WebCore::WebGLRenderingContextBase::getFloatParameter): (WebCore::WebGLRenderingContextBase::getIntParameter): (WebCore::WebGLRenderingContextBase::getUnsignedIntParameter): (WebCore::WebGLRenderingContextBase::getWebGLFloatArrayParameter): (WebCore::WebGLRenderingContextBase::getWebGLIntArrayParameter): (WebCore::WebGLRenderingContextBase::vertexAttribfImpl): (WebCore::WebGLRenderingContextBase::vertexAttribfvImpl): (WebCore::WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent): (WebCore::WebGLRenderingContextBase::maybeRestoreContextSoon): (WebCore::WebGLRenderingContextBase::maybeRestoreContext): (WebCore::WebGLRenderingContextBase::simulateEventForTesting): (WebCore::WebGLRenderingContextBase::maxDrawBuffers): (WebCore::WebGLRenderingContextBase::maxColorAttachments): (WebCore::WebGLRenderingContextBase::setFramebuffer): (WebCore::WebGLRenderingContextBase::drawArraysInstanced): (WebCore::WebGLRenderingContextBase::drawElementsInstanced): (WebCore::WebGLRenderingContextBase::vertexAttribDivisor): (WebCore::WebGLRenderingContextBase::enableSupportedExtension): (WebCore::WebGLRenderingContextBase::prepareForDisplay): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: (WebCore::WebGLRenderingContextBase::protectedBoundVertexArrayObject const): (WebCore::WebGLRenderingContextBase::protectedFramebufferBinding const): Canonical link: https://commits.webkit.org/296020@main
1 parent ebcb318 commit adb15d9

4 files changed

Lines changed: 242 additions & 224 deletions

File tree

Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,6 @@ html/canvas/CanvasRenderingContext2DBase.cpp
326326
html/canvas/CanvasRenderingContext2DBase.h
327327
html/canvas/EXTDisjointTimerQuery.cpp
328328
html/canvas/OffscreenCanvasRenderingContext2D.cpp
329-
html/canvas/WebGLRenderingContextBase.cpp
330329
html/parser/HTMLConstructionSite.cpp
331330
html/parser/HTMLConstructionSite.h
332331
html/parser/HTMLDocumentParser.cpp

Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,6 @@ html/canvas/WebGLMultiDrawInstancedBaseVertexBaseInstance.cpp
605605
html/canvas/WebGLObject.cpp
606606
html/canvas/WebGLObject.h
607607
html/canvas/WebGLProgram.cpp
608-
html/canvas/WebGLRenderingContextBase.cpp
609608
html/canvas/WebGLSync.cpp
610609
html/canvas/WebGLTransformFeedback.cpp
611610
html/canvas/WebGLVertexArrayObject.cpp

0 commit comments

Comments
 (0)