[Model] Handle the error case when the model asset cannot be loaded

https://bugs.webkit.org/show_bug.cgi?id=290244
rdar://147635013

Reviewed by Mike Wyrzykowski.

If the model asset cannot be loaded for some reason (e.g. invalid
format), we should reject the ready promise on the model element.

* LayoutTests/model-element/model-element-ready-expected.txt:
* LayoutTests/model-element/model-element-ready.html:
Check ready promise is rejected when the model source points to an
asset that can't be loaded.
* LayoutTests/model-element/resources/error-case.usdz: Added.
A bad usdz example that doesn't have the expected content.
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::toResourceError):
(WebKit::RKModelLoaderUSD::load):
If no entity is loaded, treat this as a failed case.
(WebKit::ModelProcessModelPlayerProxy::didFailLoading):
Notify the web content side about this failed load.
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp:
(WebKit::ModelProcessModelPlayer::didFailLoading):
Notify the client (HTMLModelElement) about the failed load.
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in:

Canonical link: https://commits.webkit.org/292547@main

Author: achan00

LayoutTests/model-element/model-element-ready-expected.txt

@@ -1,5 +1,6 @@
 
-PASS <model> rejects the ready promise when provided with an unknown resoure.
+PASS <model> rejects the ready promise when provided with an unknown resource.
+PASS <model> rejects the ready promise when provided with a resource that can't be loaded.
 PASS <model> rejects the ready promise when its resource load is aborted.
 PASS <model> resolves the ready promise when provided with a known resource.
 

LayoutTests/model-element/model-element-ready.html

@@ -14,7 +14,15 @@
         value => assert_unreached("Unexpected ready promise resolution."),
         reason => assert_true(reason.toString().includes("NetworkError"), "The ready promise is rejected with a NetworkError.")
     );
-}, `<model> rejects the ready promise when provided with an unknown resoure.`);
+}, `<model> rejects the ready promise when provided with an unknown resource.`);
+
+promise_test(async t => {
+    const [model, source] = createModelAndSource(t, "resources/error-case.usdz");
+    return model.ready.then(
+        value => assert_unreached("Unexpected ready promise resolution."),
+        reason => assert_true(reason.toString().includes("AbortError"), "The ready promise is rejected with an AbortError.")
+    );
+}, `<model> rejects the ready promise when provided with a resource that can't be loaded.`);
 
 promise_test(async t => {
     const [model, source] = createModelAndSource(t, "resources/heart.usdz");
@@ -25,7 +33,7 @@
 
     return modelReady.then(
         value => assert_unreached("Unexpected ready promise resolution."),
-        reason => assert_true(reason.toString().includes("AbortError"), "The ready promise is rejected with a NetworkError.")
+        reason => assert_true(reason.toString().includes("AbortError"), "The ready promise is rejected with an AbortError.")
     );
 }, `<model> rejects the ready promise when its resource load is aborted.`);
 

LayoutTests/model-element/resources/error-case.usdz

@@ -0,0 +1 @@
+Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus hendrerit felis et ex maximus condimentum. Vestibulum eget mattis dui, maximus convallis mi. Suspendisse pharetra id nibh ac volutpat. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Mauris commodo sed ipsum vel elementum. Nam dignissim velit ac neque gravida interdum. Duis eu pellentesque tortor, ac ornare nisi. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Nullam elementum aliquet dignissim. In hac habitasse platea dictumst.

Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm

@@ -177,11 +177,27 @@ void didFail(ResourceError error)
     WeakPtr<REModelLoaderClient> m_client;
 };
 
+static ResourceError toResourceError(String payload, Model& model)
+{
+    return ResourceError { [NSError errorWithDomain:@"RKModelLoaderUSD" code:-1 userInfo:@{
+        NSLocalizedDescriptionKey: (NSString *)payload,
+        NSURLErrorFailingURLErrorKey: (NSURL *)model.url()
+    }] };
+}
+
 void RKModelLoaderUSD::load()
 {
     [getWKSRKEntityClass() loadFromData:m_model->data()->createNSData().get() completionHandler:makeBlockPtr([weakThis = WeakPtr { *this }] (WKSRKEntity *entity) mutable {
-        if (RefPtr protectedThis = weakThis.get())
-            protectedThis->didFinish(entity);
+        RefPtr protectedThis = weakThis.get();
+        if (!protectedThis)
+            return;
+
+        if (!entity) {
+            protectedThis->didFail(toResourceError("Failed to load the entity"_s, protectedThis->m_model));
+            return;
+        }
+
+        protectedThis->didFinish(entity);
     }).get()];
 }
 
@@ -494,7 +510,7 @@ static CGFloat effectivePointsPerMeter(CALayer *caLayer)
 
     RELEASE_LOG_ERROR(ModelElement, "%p - ModelProcessModelPlayerProxy failed to load model id=%" PRIu64 " error=\"%@\"", this, m_id.toUInt64(), error.nsError().localizedDescription);
 
-    // FIXME: Do something sensible in the failure case.
+    send(Messages::ModelProcessModelPlayer::DidFailLoading());
 }
 
 // MARK: - WebCore::ModelPlayer

Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp

@@ -35,6 +35,7 @@
 #include "WebProcess.h"
 #include <WebCore/LayerHostingContextIdentifier.h>
 #include <WebCore/Page.h>
+#include <WebCore/ResourceError.h>
 #include <WebCore/TransformationMatrix.h>
 
 namespace WebKit {
@@ -96,6 +97,14 @@ void ModelProcessModelPlayer::didFinishLoading(const WebCore::FloatPoint3D& boun
     m_client->didUpdateBoundingBox(*this, boundingBoxCenter, boundingBoxExtents);
 }
 
+void ModelProcessModelPlayer::didFailLoading()
+{
+    RELEASE_LOG(ModelElement, "%p - ModelProcessModelPlayer didFailLoading id=%" PRIu64, this, m_id.toUInt64());
+    RELEASE_ASSERT(modelProcessEnabled());
+
+    m_client->didFailLoading(*this, WebCore::ResourceError { WebCore::errorDomainWebKitInternal, 0, { }, "Failed to load model data"_s });
+}
+
 /// This comes from Model Process side, so that Web Process has the most up-to-date knowledge about the transform actually applied to the entity.
 /// Not to be confused with setEntityTransform().
 void ModelProcessModelPlayer::didUpdateEntityTransform(const WebCore::TransformationMatrix& transform)

Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h

@@ -66,6 +66,7 @@ class ModelProcessModelPlayer
     // Messages
     void didCreateLayer(WebCore::LayerHostingContextIdentifier);
     void didFinishLoading(const WebCore::FloatPoint3D&, const WebCore::FloatPoint3D&);
+    void didFailLoading();
     void didUpdateEntityTransform(const WebCore::TransformationMatrix&);
     void didUpdateAnimationPlaybackState(bool isPaused, double playbackRate, Seconds duration, Seconds currentTime, MonotonicTime clockTimestamp);
     void didFinishEnvironmentMapLoading(bool succeeded);

Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in

@@ -30,6 +30,7 @@
 messages -> ModelProcessModelPlayer {
     DidCreateLayer(WebCore::LayerHostingContextIdentifier identifier)
     DidFinishLoading(WebCore::FloatPoint3D center, WebCore::FloatPoint3D extents)
+    DidFailLoading()
     DidUpdateEntityTransform(WebCore::TransformationMatrix transform)
     DidUpdateAnimationPlaybackState(bool isPaused, double playbackRate, Seconds duration, Seconds currentTime, MonotonicTime clockTimestamp)
     DidFinishEnvironmentMapLoading(bool succeeded)