Skip to content

Commit 987a75b

Browse files
committed
Revert "[ARMv7] Disable caches to reduce memory footprint"
This reverts commit 5029e4e.
1 parent 26f7e35 commit 987a75b

2 files changed

Lines changed: 7 additions & 11 deletions

File tree

Source/JavaScriptCore/assembler/AssemblerBuffer.h

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,6 @@ namespace JSC {
119119
// from initialization
120120
poisonInlineBuffer();
121121
#endif
122-
if constexpr (is32Bit())
123-
return;
124122
if constexpr (type == AssemblerDataType::Code)
125123
takeBufferIfLarger(*threadSpecificAssemblerData());
126124
#if ENABLE(JIT_SIGN_ASSEMBLER_BUFFER)
@@ -183,16 +181,14 @@ namespace JSC {
183181

184182
~AssemblerDataImpl()
185183
{
186-
if constexpr (!is32Bit()) {
187-
if constexpr (type == AssemblerDataType::Code)
188-
threadSpecificAssemblerData()->takeBufferIfLarger(*this);
184+
if constexpr (type == AssemblerDataType::Code)
185+
threadSpecificAssemblerData()->takeBufferIfLarger(*this);
189186
#if ENABLE(JIT_SIGN_ASSEMBLER_BUFFER)
190-
if constexpr (type == AssemblerDataType::Hashes)
191-
threadSpecificAssemblerHashes()->takeBufferIfLarger(*this);
187+
if constexpr (type == AssemblerDataType::Hashes)
188+
threadSpecificAssemblerHashes()->takeBufferIfLarger(*this);
192189
#else
193-
static_assert(type != AssemblerDataType::Hashes);
190+
static_assert(type != AssemblerDataType::Hashes);
194191
#endif
195-
}
196192
clear();
197193
}
198194

Source/JavaScriptCore/runtime/OptionsList.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,8 +499,8 @@ bool hasCapacityToUseLargeGigacage();
499499
\
500500
v(Bool, useSuperSampler, false, Normal, nullptr) \
501501
\
502-
v(Bool, useSourceProviderCache, is64Bit(), Normal, "If false, the parser will not use the source provider cache. It's good to verify everything works when this is false. Because the cache is so successful, it can mask bugs."_s) \
503-
v(Bool, useCodeCache, is64Bit(), Normal, "If false, the unlinked byte code cache will not be used."_s) \
502+
v(Bool, useSourceProviderCache, true, Normal, "If false, the parser will not use the source provider cache. It's good to verify everything works when this is false. Because the cache is so successful, it can mask bugs."_s) \
503+
v(Bool, useCodeCache, true, Normal, "If false, the unlinked byte code cache will not be used."_s) \
504504
\
505505
v(Bool, useWasm, true, Normal, "Expose the Wasm global object."_s) \
506506
\

0 commit comments

Comments
 (0)