[JSC] DEFINE_VISIT_AGGREGATE for StringReplaceaCache should be used in source file

https://bugs.webkit.org/show_bug.cgi?id=290251

Reviewed by Yusuke Suzuki.

`DEFINE_VISIT_AGGREGATE` defines not-ininlined functions[1], so it should be used in source file.
However, it is used in `StringReplaceCacheInlines.h`. This patch fixes it.

[1]: https://github.com/WebKit/WebKit/blob/b12ed39572951123a4b5a99c471e0262e9481001/Source/JavaScriptCore/heap/SlotVisitorMacros.h#L54-L60

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/runtime/StringReplaceCache.cpp: Added.
(JSC::StringReplaceCache::visitAggregateImpl):
* Source/JavaScriptCore/runtime/StringReplaceCacheInlines.h:
(JSC::StringReplaceCache::visitAggregateImpl): Deleted.

Canonical link: https://commits.webkit.org/292554@main

Author: sosukesuzuki

Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -4817,6 +4817,7 @@
 		8BC064901E1AD6AC00B2B8CA /* AsyncGeneratorPrototype.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AsyncGeneratorPrototype.h; sourceTree = "<group>"; };
 		8BC064931E1D828B00B2B8CA /* AsyncIteratorPrototype.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AsyncIteratorPrototype.cpp; sourceTree = "<group>"; };
 		8BC064941E1D828B00B2B8CA /* AsyncIteratorPrototype.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AsyncIteratorPrototype.h; sourceTree = "<group>"; };
+		8C469C292D8EBC8A008C6403 /* StringReplaceCache.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = StringReplaceCache.cpp; sourceTree = "<group>"; };
 		8CB955C92C8AF8D000282DA2 /* JSAsyncFromSyncIterator.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = JSAsyncFromSyncIterator.cpp; sourceTree = "<group>"; };
 		8CB955CA2C8AF8E100282DA2 /* JSAsyncFromSyncIterator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSAsyncFromSyncIterator.h; sourceTree = "<group>"; };
 		8CB955CC2C8AF8F500282DA2 /* JSAsyncFromSyncIteratorInlines.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSAsyncFromSyncIteratorInlines.h; sourceTree = "<group>"; };
@@ -8895,6 +8896,7 @@
 				E325A35F2221158A007349A1 /* StringPrototypeInlines.h */,
 				93345A8712D838C400302BE3 /* StringRecursionChecker.cpp */,
 				93345A8812D838C400302BE3 /* StringRecursionChecker.h */,
+				8C469C292D8EBC8A008C6403 /* StringReplaceCache.cpp */,
 				E35B36062A2E981E004EC264 /* StringReplaceCache.h */,
 				E35B36052A2E981E004EC264 /* StringReplaceCacheInlines.h */,
 				E36706292A2705DB00CF892F /* StringSplitCache.h */,

Source/JavaScriptCore/Sources.txt

@@ -1059,6 +1059,7 @@ runtime/StringIteratorPrototype.cpp
 runtime/StringObject.cpp
 runtime/StringPrototype.cpp
 runtime/StringRecursionChecker.cpp
+runtime/StringReplaceCache.cpp
 runtime/Structure.cpp
 runtime/StructureCache.cpp
 runtime/StructureChain.cpp

Source/JavaScriptCore/runtime/StringReplaceCache.cpp

@@ -0,0 +1,42 @@
+/*
+ * Copyright (C) 2025 Sosuke Suzuki <aosukeke@gmail.com>.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "StringReplaceCache.h"
+
+namespace JSC {
+
+DEFINE_VISIT_AGGREGATE(StringReplaceCache);
+
+template<typename Visitor>
+void StringReplaceCache::visitAggregateImpl(Visitor& visitor)
+{
+    for (auto& entry : m_entries) {
+        visitor.appendUnbarriered(entry.m_regExp);
+        visitor.appendUnbarriered(entry.m_result);
+    }
+}
+
+}

Source/JavaScriptCore/runtime/StringReplaceCacheInlines.h

@@ -89,15 +89,4 @@ inline void StringReplaceCache::set(const String& subject, RegExp* regExp, JSImm
     }
 }
 
-template<typename Visitor>
-inline void StringReplaceCache::visitAggregateImpl(Visitor& visitor)
-{
-    for (auto& entry : m_entries) {
-        visitor.appendUnbarriered(entry.m_regExp);
-        visitor.appendUnbarriered(entry.m_result);
-    }
-}
-
-DEFINE_VISIT_AGGREGATE(StringReplaceCache);
-
 } // namespace JSC