Commit 6dc7dda
[GStreamer][WebRTC] increase size of apps max-bytes for video tracks
https://bugs.webkit.org/show_bug.cgi?id=305576
Reviewed by Xabier Rodriguez-Calvar.
The default value for max-bytes in 200000 is not enough and leads to
frame drops during pipeline buildup.
See: #1595
This patch increases the buffering size of the appsrc element used for
video tracks in GStreamerMediaStreamSource so that it can handle enough
buffering to allow for the rest of the pipeline to be built before
buffers start to be lost. The right types are used for the parameters,
according to GObject best practices[1].
Aa an opportunistic cleanup task, types for max-buffer/max-bytes
arguments in GStreamerVideoDecoderFactory are also enforced as guint64.
This seems to be the recommended way to do it according to the GObject
documentation[1],
[1] https://docs.gtk.org/gobject/method.Object.set.html#description
Original author: Eugene Mutavchi <Ievgen_Mutavchi@comcast.com>
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Increase buffering size for video tracks and use proper types for the parameters.
* Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp: Cleanup by properly typing guint64 parameters.
Canonical link: https://commits.webkit.org/305705@main1 parent 0a2922e commit 6dc7dda
2 files changed
Lines changed: 3 additions & 1 deletion
File tree
- Source/WebCore/platform/mediastream
- gstreamer
- libwebrtc/gstreamer
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| 169 | + | |
| 170 | + | |
169 | 171 | | |
170 | 172 | | |
171 | 173 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
0 commit comments