Skip to content

Commit 0cf5fcc

Browse files
committed
[ftrace] write data provided to async markers too
1 parent f329c07 commit 0cf5fcc

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

Source/WTF/wtf/linux/SystemTracingFTrace.h

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ class SystemTracingFTrace {
9494
case TakeSnapshotStart:
9595
case SyntheticMomentumStart:
9696
case CommitLayerTreeStart:
97-
case ProcessLaunchStart:
9897
case InitializeSandboxStart:
9998
case WebXRCPFrameWaitStart:
10099
case WebXRCPFrameStartSubmissionStart:
@@ -154,7 +153,6 @@ class SystemTracingFTrace {
154153
case TakeSnapshotEnd:
155154
case SyntheticMomentumEnd:
156155
case CommitLayerTreeEnd:
157-
case ProcessLaunchEnd:
158156
case InitializeSandboxEnd:
159157
case WebXRCPFrameWaitEnd:
160158
case WebXRCPFrameStartSubmissionEnd:
@@ -167,17 +165,19 @@ class SystemTracingFTrace {
167165
case LayerFlushEnd:
168166
case UpdateLayerContentBuffersEnd:
169167
#endif
170-
endSyncMark(code);
168+
endSyncMark(code, data1, data2, data3, data4);
171169
return;
172170

171+
case ProcessLaunchStart:
173172
case MainResourceLoadDidStartProvisional:
174173
case SubresourceLoadWillStart:
175-
beginAsyncMark(code, data1);
174+
beginAsyncMark(code, data1, data2, data3, data4);
176175
return;
177176

177+
case ProcessLaunchEnd:
178178
case MainResourceLoadDidEnd:
179179
case SubresourceLoadDidEnd:
180-
endAsyncMark(code, data1);
180+
endAsyncMark(code, data1, data2, data3, data4);
181181
return;
182182

183183
case DisplayRefreshDispatchingToMainThread:
@@ -334,23 +334,23 @@ class SystemTracingFTrace {
334334
addMark('B', tracePointCodeName(code).spanIncludingNullTerminator(), "%" PRIu64 ",%" PRIu64 ",%" PRIu64 ",%" PRIu64, data1, data2, data3, data4);
335335
}
336336

337-
inline void endSyncMark(TracePointCode code) {
338-
// "E|<pid>|<name>"
339-
addMark('E', tracePointCodeName(code).spanIncludingNullTerminator());
337+
inline void endSyncMark(TracePointCode code, uint64_t data1, uint64_t data2, uint64_t data3, uint64_t data4) {
338+
// "E|<pid>|<name>|<args>"
339+
addMark('E', tracePointCodeName(code).spanIncludingNullTerminator(), "%" PRIu64 ",%" PRIu64 ",%" PRIu64 ",%" PRIu64, data1, data2, data3, data4);
340340
}
341341

342-
inline void beginAsyncMark(TracePointCode code, uint64_t cookie) {
343-
// "S|<pid>|<name>|<cookie>"
344-
addMark('S', tracePointCodeName(code).spanIncludingNullTerminator(), "%" PRIu64, cookie);
342+
inline void beginAsyncMark(TracePointCode code, uint64_t data1, uint64_t data2, uint64_t data3, uint64_t data4) {
343+
// "S|<pid>|<name>|<cookie>|<args>"
344+
addMark('S', tracePointCodeName(code).spanIncludingNullTerminator(), "%" PRIu64 "|%" PRIu64 ",%" PRIu64 ",%" PRIu64, data1, data2, data3, data4);
345345
}
346346

347-
inline void endAsyncMark(TracePointCode code, uint64_t cookie) {
348-
// "F|<pid>|<name>|<cookie>"
349-
addMark('F', tracePointCodeName(code).spanIncludingNullTerminator(),"%" PRIu64, cookie);
347+
inline void endAsyncMark(TracePointCode code, uint64_t data1, uint64_t data2, uint64_t data3, uint64_t data4) {
348+
// "F|<pid>|<name>|<cookie>|<args>"
349+
addMark('F', tracePointCodeName(code).spanIncludingNullTerminator(), "%" PRIu64 "|%" PRIu64 ",%" PRIu64 ",%" PRIu64, data1, data2, data3, data4);
350350
}
351351

352352
inline void instantMark(TracePointCode code, uint64_t data1, uint64_t data2, uint64_t data3, uint64_t data4) {
353-
// "I|<pid>|<name>"
353+
// "I|<pid>|<name>,<args>"
354354
addMark('I', tracePointCodeName(code).spanIncludingNullTerminator(),"%" PRIu64 ",%" PRIu64 ",%" PRIu64 ",%" PRIu64, data1, data2, data3, data4);
355355
}
356356

0 commit comments

Comments
 (0)