set "noImplicitAny" to true and fix the problems

Author: oltolm

package-lock.json

@@ -1112,6 +1112,7 @@
 		"@istanbuljs/nyc-config-typescript": "^1.0.2",
 		"@types/mocha": "^5.2.6",
 		"@types/node": "^11.11.3",
+		"@types/ssh2": "^1.15.0",
 		"@types/vscode": "^1.55.0",
 		"@typescript-eslint/eslint-plugin": "^5.22.0",
 		"@typescript-eslint/parser": "^5.22.0",

package.json

@@ -60,8 +60,8 @@ export interface IBackend {
 	attach(cwd: string, executable: string, target: string, autorun: string[]): Thenable<any>;
 	connect(cwd: string, executable: string, target: string, autorun: string[]): Thenable<any>;
 	start(runToStart: boolean): Thenable<boolean>;
-	stop();
-	detach();
+	stop(): void;
+	detach(): void;
 	interrupt(): Thenable<boolean>;
 	continue(): Thenable<boolean>;
 	next(): Thenable<boolean>;

src/backend/backend.ts

@@ -1,3 +1,4 @@
+import { VariableObject } from "./backend";
 import { MINode } from "./mi_parse";
 
 const resultRegex = /^([a-zA-Z_\-][a-zA-Z0-9_\-]*|\[\d+\])\s*=\s*/;
@@ -29,7 +30,7 @@ export function isExpandable(value: string): number {
 	else return 0;
 }
 
-export function expandValue(variableCreate: Function, value: string, root: string = "", extra: any = undefined): any {
+export function expandValue(variableCreate: (arg: VariableObject | string, options?: any) => any, value: string, root: string = "", extra: any = undefined): any {
 	const parseCString = () => {
 		value = value.trim();
 		if (value[0] != '"' && value[0] != '\'')
@@ -56,10 +57,10 @@ export function expandValue(variableCreate: Function, value: string, root: strin
 	};
 
 	const stack = [root];
-	let parseValue, parseCommaResult, parseCommaValue, parseResult, createValue;
+	let parseValue: () => any, parseCommaResult: (pushToStack: boolean) => any, parseCommaValue: () => any, parseResult: (pushToStack: boolean) => any, createValue: (name: string, val: any) => any;
 	let variable = "";
 
-	const getNamespace = (variable) => {
+	const getNamespace = (variable: string) => {
 		let namespace = "";
 		let prefix = "";
 		stack.push(variable);
@@ -209,7 +210,7 @@ export function expandValue(variableCreate: Function, value: string, root: strin
 		return createValue(name, val);
 	};
 
-	createValue = (name, val) => {
+	createValue = (name: string, val: any) => {
 		let ref = 0;
 		if (typeof val == "object") {
 			ref = variableCreate(val);
@@ -223,7 +224,7 @@ export function expandValue(variableCreate: Function, value: string, root: strin
 				val = "Object@" + val;
 			}
 		} else if (typeof val == "string" && val.startsWith("@0x")) {
-			ref = variableCreate(getNamespace("*&" + name.substr));
+			ref = variableCreate(getNamespace("*&" + name.substring(1)));
 			val = "Ref" + val;
 		} else if (typeof val == "string" && val.startsWith("<...>")) {
 			ref = variableCreate(getNamespace(name));

src/backend/gdb_expansion.ts

@@ -6,7 +6,7 @@ import * as linuxTerm from '../linux/console';
 import * as net from "net";
 import * as fs from "fs";
 import * as path from "path";
-import { Client } from "ssh2";
+import { Client, ClientChannel, ExecOptions } from "ssh2";
 
 export function escape(str: string) {
 	return str.replace(/\\/g, "\\\\").replace(/"/g, "\\\"");
@@ -29,7 +29,7 @@ export class MI2 extends EventEmitter implements IBackend {
 		super();
 
 		if (procEnv) {
-			const env = {};
+			const env: { [key: string]: string } = {};
 			// Duplicate process.env so we don't override it
 			for (const key in process.env)
 				if (process.env.hasOwnProperty(key))
@@ -57,8 +57,8 @@ export class MI2 extends EventEmitter implements IBackend {
 			this.process = ChildProcess.spawn(this.application, args, { cwd: cwd, env: this.procEnv });
 			this.process.stdout.on("data", this.stdout.bind(this));
 			this.process.stderr.on("data", this.stderr.bind(this));
-			this.process.on("exit", (() => { this.emit("quit"); }).bind(this));
-			this.process.on("error", ((err) => { this.emit("launcherror", err); }).bind(this));
+			this.process.on("exit", () => this.emit("quit"));
+			this.process.on("error", err => this.emit("launcherror", err));
 			const promises = this.initCommands(target, cwd);
 			if (procArgs && procArgs.length)
 				promises.push(this.sendCommand("exec-arguments " + procArgs));
@@ -137,7 +137,7 @@ export class MI2 extends EventEmitter implements IBackend {
 
 			this.sshConn.on("ready", () => {
 				this.log("stdout", "Running " + this.application + " over ssh...");
-				const execArgs: any = {};
+				const execArgs: ExecOptions = {};
 				if (args.forwardX11) {
 					execArgs.x11 = {
 						single: false,
@@ -150,7 +150,7 @@ export class MI2 extends EventEmitter implements IBackend {
 					if (err) {
 						this.log("stderr", "Could not run " + this.application + "(" + sshCMD + ") over ssh!");
 						if (err === undefined) {
-							err = "<reason unknown>";
+							err = new Error("<reason unknown>");
 						}
 						this.log("stderr", err.toString());
 						this.emit("quit");
@@ -161,10 +161,10 @@ export class MI2 extends EventEmitter implements IBackend {
 					this.stream = stream;
 					stream.on("data", this.stdout.bind(this));
 					stream.stderr.on("data", this.stderr.bind(this));
-					stream.on("exit", (() => {
+					stream.on("exit", () => {
 						this.emit("quit");
 						this.sshConn.end();
-					}).bind(this));
+					});
 					const promises = this.initCommands(target, cwd, attach);
 					promises.push(this.sendCommand("environment-cd \"" + escape(cwd) + "\""));
 					if (attach) {
@@ -181,7 +181,7 @@ export class MI2 extends EventEmitter implements IBackend {
 			}).on("error", (err) => {
 				this.log("stderr", "Error running " + this.application + " over ssh!");
 				if (err === undefined) {
-					err = "<reason unknown>";
+					err = new Error("<reason unknown>");
 				}
 				this.log("stderr", err.toString());
 				this.emit("quit");
@@ -235,8 +235,8 @@ export class MI2 extends EventEmitter implements IBackend {
 			this.process = ChildProcess.spawn(this.application, args, { cwd: cwd, env: this.procEnv });
 			this.process.stdout.on("data", this.stdout.bind(this));
 			this.process.stderr.on("data", this.stderr.bind(this));
-			this.process.on("exit", (() => { this.emit("quit"); }).bind(this));
-			this.process.on("error", ((err) => { this.emit("launcherror", err); }).bind(this));
+			this.process.on("exit", () => this.emit("quit"));
+			this.process.on("error", err => this.emit("launcherror", err));
 			const promises = this.initCommands(target, cwd, true);
 			if (target.startsWith("extended-remote")) {
 				promises.push(this.sendCommand("target-select " + target));
@@ -267,8 +267,8 @@ export class MI2 extends EventEmitter implements IBackend {
 			this.process = ChildProcess.spawn(this.application, args, { cwd: cwd, env: this.procEnv });
 			this.process.stdout.on("data", this.stdout.bind(this));
 			this.process.stderr.on("data", this.stderr.bind(this));
-			this.process.on("exit", (() => { this.emit("quit"); }).bind(this));
-			this.process.on("error", ((err) => { this.emit("launcherror", err); }).bind(this));
+			this.process.on("exit", () => this.emit("quit"));
+			this.process.on("error", err => this.emit("launcherror", err));
 			const promises = this.initCommands(target, cwd, true);
 			promises.push(this.sendCommand("target-select remote " + target));
 			promises.push(...autorun.map(value => { return this.sendUserInput(value); }));
@@ -279,7 +279,7 @@ export class MI2 extends EventEmitter implements IBackend {
 		});
 	}
 
-	stdout(data) {
+	stdout(data: any) {
 		if (trace)
 			this.log("stderr", "stdout: " + data);
 		if (typeof data == "string")
@@ -298,7 +298,7 @@ export class MI2 extends EventEmitter implements IBackend {
 		}
 	}
 
-	stderr(data) {
+	stderr(data: any) {
 		if (typeof data == "string")
 			this.errbuf += data;
 		else
@@ -563,7 +563,7 @@ export class MI2 extends EventEmitter implements IBackend {
 	loadBreakPoints(breakpoints: Breakpoint[]): Thenable<[boolean, Breakpoint][]> {
 		if (trace)
 			this.log("stderr", "loadBreakPoints");
-		const promisses = [];
+		const promisses: Thenable<[boolean, Breakpoint]>[] = [];
 		breakpoints.forEach(breakpoint => {
 			promisses.push(this.addBreakPoint(breakpoint));
 		});
@@ -651,7 +651,7 @@ export class MI2 extends EventEmitter implements IBackend {
 		if (trace)
 			this.log("stderr", "clearBreakPoints");
 		return new Promise((resolve, reject) => {
-			const promises = [];
+			const promises: Thenable<void | MINode>[] = [];
 			const breakpoints = this.breakpoints;
 			this.breakpoints = new Map();
 			breakpoints.forEach((k, index) => {
@@ -709,7 +709,7 @@ export class MI2 extends EventEmitter implements IBackend {
 
 		const result = await this.sendCommand(["stack-list-frames"].concat(options).join(" "));
 		const stack = result.result("stack");
-		return stack.map(element => {
+		return stack.map((element: any) => {
 			const level = MINode.valueOf(element, "@frame.level");
 			const addr = MINode.valueOf(element, "@frame.addr");
 			const func = MINode.valueOf(element, "@frame.func");
@@ -856,7 +856,7 @@ export class MI2 extends EventEmitter implements IBackend {
 		//TODO: add `from` and `to` arguments
 		const res = await this.sendCommand(`var-list-children --all-values ${this.quote(name)}`);
 		const children = res.result("children") || [];
-		const omg: VariableObject[] = children.map(child => new VariableObject(child[1]));
+		const omg: VariableObject[] = children.map((child: any) => new VariableObject(child[1]));
 		return omg;
 	}
 
@@ -945,6 +945,6 @@ export class MI2 extends EventEmitter implements IBackend {
 	protected buffer: string;
 	protected errbuf: string;
 	protected process: ChildProcess.ChildProcess;
-	protected stream;
-	protected sshConn;
+	protected stream: ClientChannel;
+	protected sshConn: Client;
 }

src/backend/mi2/mi2.ts

@@ -41,8 +41,8 @@ export class MI2_LLDB extends MI2 {
 			this.process = ChildProcess.spawn(this.application, args, { cwd: cwd, env: this.procEnv });
 			this.process.stdout.on("data", this.stdout.bind(this));
 			this.process.stderr.on("data", this.stderr.bind(this));
-			this.process.on("exit", (() => { this.emit("quit"); }).bind(this));
-			this.process.on("error", ((err) => { this.emit("launcherror", err); }).bind(this));
+			this.process.on("exit", () => this.emit("quit"));
+			this.process.on("error", err => this.emit("launcherror", err));
 			const promises = this.initCommands(target, cwd, true);
 			promises.push(this.sendCommand("file-exec-and-symbols \"" + escape(executable) + "\""));
 			promises.push(this.sendCommand("target-attach " + target));

src/backend/mi2/mi2lldb.ts

@@ -9,8 +9,8 @@ export class MI2_Mago extends MI2_LLDB {
 			this.sendCommand(command).then((result) => {
 				const stack = result.resultRecords.results;
 				const ret: Stack[] = [];
-				const remaining = [];
-				const addToStack = (element) => {
+				const remaining: any = [];
+				const addToStack = (element: any) => {
 					const level = MINode.valueOf(element, "frame.level");
 					const addr = MINode.valueOf(element, "frame.addr");
 					const func = MINode.valueOf(element, "frame.func");

src/backend/mi2/mi2mago.ts

@@ -150,19 +150,19 @@ export function parseMI(output: string): MINode {
 	*/
 
 	let token = undefined;
-	const outOfBandRecord = [];
+	const outOfBandRecord: { isStream: boolean, type: string, asyncClass: string, output: [string, any][], content: string }[] = [];
 	let resultRecords = undefined;
 
 	const asyncRecordType = {
 		"*": "exec",
 		"+": "status",
 		"=": "notify"
-	};
+	} as const;
 	const streamRecordType = {
 		"~": "console",
 		"@": "target",
 		"&": "log"
-	};
+	} as const;
 
 	const parseCString = () => {
 		if (output[0] != '"')
@@ -192,7 +192,7 @@ export function parseMI(output: string): MINode {
 		return str;
 	};
 
-	let parseValue, parseCommaResult, parseCommaValue, parseResult;
+	let parseValue: () => any, parseCommaResult: () => any, parseCommaValue: () => any, parseResult: () => any;
 
 	const parseTupleOrList = () => {
 		if (output[0] != '{' && output[0] != '[')
@@ -274,9 +274,10 @@ export function parseMI(output: string): MINode {
 			output = output.substring(classMatch[0].length);
 			const asyncRecord = {
 				isStream: false,
-				type: asyncRecordType[match[2]],
+				type: asyncRecordType[match[2] as keyof typeof asyncRecordType],
 				asyncClass: classMatch[0],
-				output: []
+				output: [] as any,
+				content: ""
 			};
 			let result;
 			while (result = parseCommaResult())
@@ -285,8 +286,10 @@ export function parseMI(output: string): MINode {
 		} else if (match[3]) {
 			const streamRecord = {
 				isStream: true,
-				type: streamRecordType[match[3]],
-				content: parseCString()
+				type: streamRecordType[match[3] as keyof typeof streamRecordType],
+				content: parseCString(),
+				output: [] as [string, any][],
+				asyncClass: ""
 			};
 			outOfBandRecord.push(streamRecord);
 		}
@@ -310,5 +313,5 @@ export function parseMI(output: string): MINode {
 		output = output.replace(newlineRegex, "");
 	}
 
-	return new MINode(token, <any> outOfBandRecord || [], resultRecords);
+	return new MINode(token, outOfBandRecord || [], resultRecords);
 }