Rework parser define/ifdef conditional logic, no linked list and less allocations

Author: ollydev

Source/ide/codetools/simba.ide_codetools_debug.pas

@@ -121,6 +121,7 @@ procedure DebugCache;
     TreeView.AddNode(n, 'Max Stack Depth: ' + IntToStr(Parser.Stack.Max), IMG_INFO);
     TreeView.AddNode(n, 'Ref Count: ' + IntToStr(TCodetoolsInclude(Parser).RefCount), IMG_INFO);
     TreeView.AddNode(n, 'Last Used: ' + IntToStr(TCodetoolsInclude(Parser).LastUsed), IMG_INFO);
+    TreeView.AddNode(n, 'InDefines: ' + TCodetoolsInclude(Parser).InDefines.ToString);
 
     DebugClassTypes(Parser, TreeView, n);
   end;

Source/ide/codetools/simba.ide_codetools_includes.pas

@@ -63,6 +63,7 @@   TCodetoolsInclude = class(TCodeParser)
     property Plugins: TStringArray read GetPlugins;
     property RefCount: Integer read FRefCount;
     property LastUsed: Integer read FLastUsed;
+    property InDefines: TSaveDefinesRec read FInDefines;
 
     function IsOutdated: Boolean;
     function IncRef: TCodetoolsInclude;
@@ -122,7 +123,7 @@ function TCodetoolsInclude.GetPlugins: TStringArray;
 function TCodetoolsInclude.GetHash: String;
 begin
   if FHash.IsNull then
-    FHash := inherited + FInDefines.Defines + IntToStr(FInDefines.Stack) + FPlugins.Text;
+    FHash := inherited + FInDefines.ToString + FPlugins.Text;
 
   Result := FHash;
 end;
@@ -306,7 +307,7 @@ function TCodetoolsIncludes.GetInclude(Defines: TSaveDefinesRec; IncludedFiles:
       if (FParsers[I].Lexer.FileName = FileName) then
         with TCodetoolsInclude(FParsers[I]) do
         begin
-          if (FInDefines.Stack <> Defines.Stack) or (FInDefines.Defines <> Defines.Defines) then
+          if not FInDefines.IsEqual(Defines) then
           begin
             {$IFDEF PARSER_CACHE_DEBUG}
             DebugLn('[Codetools]: Cache hit "%s" but not used (defines mismatch) %d, %d', [Lexer.FileName, FRefCount, FLastUsed + 1]);

Source/ide/codetools/simba.ide_codetools_parser.pas

@@ -1552,8 +1552,7 @@ function TCodeParser.GetHash: String;
 begin
   if FHash.IsNull then
   begin
-    with Lexer.SaveDefines() do
-      Builder.Append(Defines + IntToStr(Stack));
+    Builder.Append(Lexer.SaveDefines().ToString());
     for I := 0 to fLexers.Count - 1 do
       Builder.Append(fLexers[i].FileName + IntToStr(fLexers[i].FileAge));