Skip to content

Commit bbf0d3f

Browse files
committed
Reduce Owlery 502 log noise: replace full tracebacks with concise warnings
1 parent fa62807 commit bbf0d3f

3 files changed

Lines changed: 16 additions & 21 deletions

File tree

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
here = path.abspath(path.dirname(__file__))
55

6-
__version__ = "1.6.2"
6+
__version__ = "1.6.3"
77

88
# Get the long description from the README file
99
with open(path.join(here, 'README.md')) as f:

src/vfbquery/owlery_client.py

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,9 @@ def gen_short_form(iri):
178178

179179
return short_forms
180180

181-
except requests.RequestException as e:
182-
print(f"ERROR: Owlery request failed: {e}")
181+
except requests.RequestException:
183182
raise
184-
except Exception as e:
185-
print(f"ERROR: Unexpected error in Owlery query: {e}")
183+
except Exception:
186184
raise
187185

188186
def get_instances(self, query: str, query_by_label: bool = True,
@@ -293,18 +291,9 @@ def gen_short_form(iri):
293291

294292
return short_forms
295293

296-
except requests.RequestException as e:
297-
# Show the full URL that was attempted
298-
try:
299-
full_url = f"{self.owlery_endpoint}/instances"
300-
prepared_request = requests.Request('GET', full_url, params=params).prepare()
301-
print(f"ERROR: Owlery instances request failed: {e}")
302-
print(f" Test URL: {prepared_request.url}")
303-
except:
304-
print(f"ERROR: Owlery instances request failed: {e}")
294+
except requests.RequestException:
305295
raise
306-
except Exception as e:
307-
print(f"ERROR: Unexpected error in Owlery instances query: {e}")
296+
except Exception:
308297
raise
309298

310299

src/vfbquery/vfb_queries.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3484,11 +3484,17 @@ def _owlery_query_to_results(owl_query_string: str, short_form: str, return_data
34843484
}
34853485
else:
34863486
# Other errors (500, network issues, etc.) - return error indication
3487-
print(f"ERROR: Owlery {'instances' if query_instances else 'subclasses'} query failed: {e}", file=sys.stderr)
3488-
print(f" Full URL: {owlery_url}", file=sys.stderr)
3489-
print(f" Query string: {owl_query_string}", file=sys.stderr)
3490-
import traceback
3491-
traceback.print_exc()
3487+
import requests as _requests
3488+
is_connection_error = isinstance(e, (_requests.exceptions.RetryError,
3489+
_requests.exceptions.ConnectionError))
3490+
if is_connection_error:
3491+
print(f"WARNING: Owlery unavailable for query '{owl_query_string}': {type(e).__name__}", file=sys.stderr)
3492+
else:
3493+
print(f"ERROR: Owlery {'instances' if query_instances else 'subclasses'} query failed: {e}", file=sys.stderr)
3494+
print(f" Full URL: {owlery_url}", file=sys.stderr)
3495+
print(f" Query string: {owl_query_string}", file=sys.stderr)
3496+
import traceback
3497+
traceback.print_exc()
34923498
# Return error indication with count=-1
34933499
if return_dataframe:
34943500
return pd.DataFrame()

0 commit comments

Comments
 (0)