Commit e1912ba
authored
test(e2e): Skip shopify image cache test when shopify is unconfigured (#1068)
The shopify-image-cache e2e test depends on real products rendering on
/store, which requires SHOPIFY_STORE_DOMAIN and SHOPIFY_STOREFRONT_ACCESS_TOKEN.
CI does not set these, so the store page falls back to a "Store Configuration
Required" panel and the test fails on a missing img[src*="cdn.shopify.com"]
locator.
Fixes:
- Detect the fallback panel at runtime and call test.skip with a clear message
pointing at the env vars required to run the test meaningfully.
- Forward SHOPIFY_STORE_DOMAIN and SHOPIFY_STOREFRONT_ACCESS_TOKEN from the
parent environment to the spawned web server in playwright.config.ts when
available, so future CI runs (with secrets set) or local runs without
reuseExistingServer actually exercise the Shopify path.
Note: a separate service-worker timing bug exists on the offline-reload step
(page.reload after setOffline returns ERR_INTERNET_DISCONNECTED when the SW
has not finished caching the HTML). That is unrelated to Shopify config and
will be filed as a follow-up.1 parent 0e67ad7 commit e1912ba
2 files changed
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
73 | 83 | | |
74 | 84 | | |
75 | 85 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
18 | 31 | | |
19 | 32 | | |
20 | 33 | | |
| |||
0 commit comments