Skip to content

Commit d6345fe

Browse files
committed
performing minor changes.
1 parent ec14c78 commit d6345fe

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

tests/test_pm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ def test_create_policy_with_team(self):
274274
connector.set_policy(zone, policy_specification)
275275
result = connector.get_policy(zone)
276276
self.assertEqual(1, len(result.users))
277-
self.assertEqual("DevOpsTeam", result.users[0])
277+
self.assertEqual(CLOUD_TEAM, result.users[0])
278278

279279
def _create_policy_cloud(self, policy_spec=None, policy=None, defaults=None):
280280
zone = self._get_random_zone()

vcert/connection_cloud.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ def set_policy(self, zone, policy_spec):
625625
for_update, owners_list = self.resolve_owners(policy_spec.users, user_details)
626626
if app_details:
627627
# Application exists. Update with cit and owners
628-
if for_update and len(owners_list) == 1:
628+
if for_update and len(policy_spec.users) == 0:
629629
log.debug("No users provided in the policy specification")
630630
else:
631631
owner_list = build_owner_json(owners_list)

vcert/connection_tpp_abstract.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ def get_tpp_identity(self, username):
598598
log.debug(f"Error while getting contact [{username}]: {err.args[0]}")
599599
if len(response['Identities']) > 1:
600600
raise VenafiError("Extraneous information returned in the identity response. "
601-
"Expected size: 1, more than 1\n")
601+
"Expected size: 1, found more than 1 \n")
602602
identity = build_identity_entry(identities)
603603
return identity
604604

@@ -1014,7 +1014,7 @@ def retrieve_usernames_from_tpp_contacts(self, zone):
10141014
users_list = list()
10151015
contacts = list()
10161016
try:
1017-
status, response = self._get_policy_attr(zone, 'Contact')
1017+
status, response = self._get_policy_attr(zone, SPA.TPP_CONTACT)
10181018
contacts = response['Values']
10191019
except VenafiError as err:
10201020
log.debug(f"Error while getting attribute [Contact] value from policy [{zone}]: {err.args[0]}")

0 commit comments

Comments
 (0)