Missing changes in the previous attempt to avoid nullpointer exceptions

Author: marcos-albornoz

src/main/java/com/venafi/vcert/sdk/connectors/tpp/TppTokenConnector.java

@@ -128,23 +128,18 @@ public TokenInfo getAccessToken(Authentication auth) throws VCertException {
 
     	if (auth != null) {
 
-    		Authentication authTemp = null;
-
-    		if (auth != null) {
-
-    			//creating a temp Authentication object based on the one passed as argument
-    			// in order to avoid to modify that original given it's needed that 
-    			// the Authentication object to be passed to the authenticate() method needs
-    			// that the accessToken and refreshToken doesn't set
-    			authTemp = Authentication.builder()
-    					.user(auth.user())
-    					.password(auth.password())
-    					.clientId(auth.clientId())
-    					.scope(auth.scope())
-    					.state(auth.state())
-    					.redirectUri(auth.redirectUri())
-    					.build();
-    		}
+    		//creating a temp Authentication object based on the one passed as argument
+    		// in order to avoid to modify that original given it's needed that 
+    		// the Authentication object to be passed to the authenticate() method needs
+    		// that the accessToken and refreshToken doesn't set
+    		Authentication authTemp = Authentication.builder()
+    				.user(auth.user())
+    				.password(auth.password())
+    				.clientId(auth.clientId())
+    				.scope(auth.scope())
+    				.state(auth.state())
+    				.redirectUri(auth.redirectUri())
+    				.build();
 
     		authenticate(authTemp);
 

src/test/java/com/venafi/vcert/sdk/VCertTknClientAuthenticationAT.java

@@ -13,6 +13,7 @@
 import org.junit.jupiter.api.Test;
 
 import com.venafi.vcert.sdk.connectors.ConnectorException.MissingCredentialsException;
+import com.venafi.vcert.sdk.connectors.ConnectorException.NullAuthenticationException;
 import com.venafi.vcert.sdk.connectors.tpp.TokenInfo;
 import com.venafi.vcert.sdk.endpoint.Authentication;
 import com.venafi.vcert.sdk.endpoint.ConnectorType;
@@ -219,7 +220,7 @@ void invalidAuthenticationMissingCredentialsInAccessToken() {
 		VCertTknClient client = getClientUnauthenticated();
 
 		//asserting that the credentials were not provided
-		assertThrows(MissingCredentialsException.class, () -> client.getAccessToken());
+		assertThrows(NullAuthenticationException.class, () -> client.getAccessToken());
 
 		//asserting that the credentials were not provided
 		assertThrows(MissingCredentialsException.class, () -> client.getAccessToken(getAuthenticationMissingAccessToken()));